kallithea Changeset - 0a9ddb8cd8c1

Changeset - 0a9ddb8cd8c1

Parent rev.

Child rev.

[Not reviewed]

stable

0 8 0

Mads Kiilerich - 3 years ago 2023-04-13 13:54:24
mads@kiilerich.com

setup: avoid setuptools 67 - it can't handle celery's broken pytz dependency

With setuptools 67 or later, launching Kallithea fails as:

$ gearbox serve -c my.ini --reload
15:56:54,111 ERROR [gearbox] Expected closing RIGHT_PARENTHESIS
pytz (>dev)
~^

The `packaging` vendored in setuptools cannot handle the broken syntax
`Requires-Dist: pytz (>dev)` in
venv/lib/python3.11/site-packages/celery-5.0.5.dist-info/METADATA .

The old celery version currently used by Kallithea is wrong, and setuptools has
moved on after a reasonable grace period. We thus have to work around and avoid
latest setuptools.

See https://github.com/pypa/setuptools/issues/3889 .

8 files changed with 9 insertions and 9 deletions:

Jenkinsfile

docs/contributing.rst

docs/installation.rst

docs/installation_win.rst

docs/installation_win_old.rst

scripts/dbmigrate-test

scripts/validate-commits

scripts/validate-minimum-dependency-versions

0 comments (0 inline, 0 general)

Jenkinsfile

➞

Show inline comments

@@ @@ -25,13 +25,13 @@ node { @@
+        }
+    }
     stage('virtual env') {
         def virtualenvscript = """$createvirtualenv
             $activatevirtualenv
             python -m pip install --upgrade pip
             pip install --upgrade setuptools
+            pip install --upgrade "setuptools<67"
             pip install --upgrade pylint
             pip install --upgrade pytest-cov
             """
         if (isUnix()) {
             virtualenvscript += """
                 pip install --upgrade python-ldap

docs/contributing.rst

➞

Show inline comments

@@ @@ -30,13 +30,13 @@ To get started with Kallithea developmen @@
 bash shell::
         hg clone https://kallithea-scm.org/repos/kallithea
         cd kallithea
         python3 -m venv venv
         . venv/bin/activate
         pip install --upgrade pip setuptools
+        pip install --upgrade pip "setuptools<67"
         pip install --upgrade -e . -r dev_requirements.txt python-ldap python-pam
         kallithea-cli config-create my.ini
         kallithea-cli db-create -c my.ini --user=user --email=user@example.com --password=password --repos=/tmp
         kallithea-cli front-end-build
         gearbox serve -c my.ini --reload &
         firefox http://127.0.0.1:5000/

docs/installation.rst

➞

Show inline comments

@@ @@ -52,13 +52,13 @@ To install Kallithea in a virtualenv usi @@
 repository, use the following commands in your bash shell::
         hg clone https://kallithea-scm.org/repos/kallithea -u stable
         cd kallithea
         python3 -m venv venv
         . venv/bin/activate
         pip install --upgrade pip setuptools
+        pip install --upgrade pip "setuptools<67"
         pip install --upgrade -e .
         python3 setup.py compile_catalog   # for translation of the UI
 .. note::
    This will install all Python dependencies into the virtualenv. Kallithea
    itself will however only be installed as a pointer to the source location.
@@ @@ -95,13 +95,13 @@ An additional benefit of virtualenv is t @@
 - Activate the virtualenv in your current shell session and make sure the
   basic requirements are up-to-date by running the following commands in your
   bash shell::
     . /srv/kallithea/venv/bin/activate
     pip install --upgrade pip setuptools
+    pip install --upgrade pip "setuptools<67"
 .. note:: You can't use UNIX ``sudo`` to source the ``activate`` script; it
    will "activate" a shell that terminates immediately.
 - Install Kallithea in the activated virtualenv::

docs/installation_win.rst

➞

Show inline comments

@@ @@ -101,13 +101,13 @@ Download and install "Microsoft Visual C @@
   You can also install the dependencies using already compiled Windows binaries packages. A good source of compiled Python packages is http://www.lfd.uci.edu/~gohlke/pythonlibs/. However, not all of the necessary packages for Kallithea are on this site and some are hard to find, so we will stick with using the compiler.
 In a command prompt type (adapting paths if necessary)::
   cd C:\Kallithea\Env\Scripts
   activate
   pip install --upgrade pip setuptools
+  pip install --upgrade pip "setuptools<67"
 The prompt will change into "(Env) C:\\Kallithea\\Env\\Scripts" or similar
 (depending of your folder structure). Then type::
   pip install kallithea

docs/installation_win_old.rst

➞

Show inline comments

@@ @@ -167,13 +167,13 @@ to:: @@
 %comspec% /k ""C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\vcvarsall.bat"" amd64
 In that CMD (loaded with VS2008 PATHs) type::
   cd C:\Kallithea\Env\Scripts (or similar)
   activate
   pip install --upgrade pip setuptools
+  pip install --upgrade pip "setuptools<67"
 The prompt will change into "(Env) C:\\Kallithea\\Env\\Scripts" or similar
 (depending of your folder structure). Then type::
  pip install kallithea

scripts/dbmigrate-test

➞

Show inline comments

@@ @@ -91,13 +91,13 @@ install_kallithea() { @@
     "${VIRTUALENV:-virtualenv}" --quiet "$prefix-env"
     HG archive --rev "$rev" "$prefix"
+    (
         cd "$prefix"
         . "$prefix-env/bin/activate"
         pip install --quiet --upgrade pip setuptools mercurial $EXTRA
+        pip install --quiet --upgrade pip "setuptools<67" mercurial $EXTRA
         pip install --quiet -e .
+    )
+}
 install_kallithea "$temp/from" "$from_rev_hash"
+(

scripts/validate-commits

➞

Show inline comments

@@ @@ -39,13 +39,13 @@ for rev in $(hg log -r "$revset" -T '{no @@
     hg log -r "$rev"
     hg update "$rev"
     cleanup
     python3 -m venv "$venv"
     source "$venv/bin/activate"
     pip install --upgrade pip setuptools
+    pip install --upgrade pip "setuptools<67"
     pip install -e . -r dev_requirements.txt python-ldap python-pam
     # run-all-cleanup
     if ! scripts/run-all-cleanup ; then
         echo "run-all-cleanup encountered errors!"
         result="NOK"

scripts/validate-minimum-dependency-versions

➞

Show inline comments

@@ @@ -27,13 +27,13 @@ mkdir -p "$venv" @@
 # while fixating the requirement at the lower bound.
 sed -n 's/.*"\(.*\)>=\(.*\)".*/\1==\2/p' setup.py > "$min_requirements"
 sed 's/>=/==/p' dev_requirements.txt >> "$min_requirements"
 python3 -m venv "$venv"
 source "$venv/bin/activate"
 pip install --upgrade pip setuptools
+pip install --upgrade pip "setuptools<67"
 pip install -e . -r "$min_requirements" python-ldap python-pam 2> >(tee "$log" >&2)
 # Treat any message on stderr as a problem, for the caller to interpret.
 if [ -s "$log" ]; then
     echo
     echo "Error: pip detected following problems:"

0 comments (0 inline, 0 general)