kallithea Changeset - 13b507b73190

Changeset - 13b507b73190

Parent rev.

Child rev.

[Not reviewed]

beta

0 2 0

Marcin Kuzminski - 15 years ago 2011-04-12 19:48:02
marcin@python-works.com

fixes issue #166, made clone-uri use the pylons build in url generators, that way it's more safe.

2 files changed with 21 insertions and 10 deletions:

rhodecode/controllers/shortlog.py

rhodecode/controllers/summary.py

0 comments (0 inline, 0 general)

rhodecode/controllers/shortlog.py

➞

Show inline comments

@@ @@ -25,7 +25,7 @@ @@
 import logging
 from pylons import tmpl_context as c, request
+from pylons import tmpl_context as c, request, url
 from rhodecode.lib.auth import LoginRequired, HasRepoPermissionAnyDecorator
 from rhodecode.lib.base import BaseRepoController, render
@@ @@ -42,10 +42,16 @@ class ShortlogController(BaseRepoControl @@
     def __before__(self):
         super(ShortlogController, self).__before__()
     def index(self):
+    def index(self, repo_name):
         p = int(request.params.get('page', 1))
         size = int(request.params.get('size', 20))
         def url_generator(**kw):
             return url('shortlog_home', repo_name=repo_name, size=size, **kw)
         c.repo_changesets = RepoPage(c.rhodecode_repo, page=p,
                                      items_per_page=20)
                                                        items_per_page=size,
                                                        url=url_generator)
         c.shortlog_data = render('shortlog/shortlog_data.html')
         if request.params.get('partial'):
             return c.shortlog_data

rhodecode/controllers/summary.py

➞

Show inline comments

@@ @@ -70,7 +70,7 @@ class SummaryController(BaseRepoControll @@
                                                 self.rhodecode_user.user_id)
         def url_generator(**kw):
             return url('shortlog_home', repo_name=repo_name, **kw)
+            return url('shortlog_home', repo_name=repo_name, size=10, **kw)
         c.repo_changesets = RepoPage(c.rhodecode_repo, page=1,
                                      items_per_page=10, url=url_generator)
@@ @@ -83,13 +83,18 @@ class SummaryController(BaseRepoControll @@
             username = str(self.rhodecode_user.username)
             password = '@'
         uri = u'%(proto)s://%(user)s%(pass)s%(host)s%(prefix)s/%(repo_name)s' \
                                     % {'proto': e.get('wsgi.url_scheme'),
                                        'user': username,
         if e.get('wsgi.url_scheme') == 'https':
             split_s = 'https://'
         else:
             split_s = 'http://'
         qualified_uri = [split_s] + [url.current(qualified=True)\
                                      .split(split_s)[-1]]
         uri = u'%(proto)s%(user)s%(pass)s%(rest)s' \
                 % {'user': username,
                                        'pass': password,
                                        'host': e.get('HTTP_HOST'),
                                        'prefix': e.get('SCRIPT_NAME'),
                                        'repo_name': repo_name, }
                      'proto': qualified_uri[0],
                      'rest': qualified_uri[1]}
         c.clone_repo_url = uri
         c.repo_tags = OrderedDict()
         for name, hash in c.rhodecode_repo.tags.items()[:10]:

0 comments (0 inline, 0 general)