Changeset - 169539b32b90
Parent rev.
Child rev.
[Not reviewed]
default
0 3 0
Mads Kiilerich - 6 years ago 2020-02-25 18:18:44
mads@kiilerich.com
Grafted from: 779493225629
js: fix missing var declaration of AJAX_COMMENT_URL and AJAX_COMMENT_DELETE_URL (Issue #362)

Tech debt stroke back when fb9550946c26 cleaned things up.

Eslint wearnings for these variables had incorrectly been manually ignored.
3 files changed with 6 insertions and 4 deletions:
kallithea/public/js/base.js
2
kallithea/templates/changeset/changeset.html
2
2
kallithea/templates/pullrequests/pullrequest_show.html
2
2
0 comments (0 inline, 0 general)
kallithea/public/js/base.js
➞
Show inline comments
 
@@ -593,6 +593,7 @@ function _comment_div_append_add($commen
 
}
 

			




	
	
	
		
 
// append a comment form to $comment_div

			




	
	
	
		
 
// Note: var AJAX_COMMENT_URL must have been defined before invoking this function

			




	
	
	
		
 
function _comment_div_append_form($comment_div, f_path, line_no) {

			




	
	
	
		
 
    var $form_div = $('#comment-inline-form-template').children()

			




	
	
	
		
 
        .clone()

			




	
	
		
 
@@ -709,6 +710,7 @@ function _comment_div_append_form($comme

			




	
	
	
		
 
}

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
// Note: var AJAX_COMMENT_URL must have been defined before invoking this function

			




	
	
	
		
 
function deleteComment(comment_id) {

			




	
	
	
		
 
    var url = AJAX_COMMENT_DELETE_URL.replace('__COMMENT_ID__', comment_id);

			




	
	
	
		
 
    var postData = {};

			




        

    


    
    

    

        

                

                    kallithea/templates/changeset/changeset.html
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -23,8 +23,8 @@ ${self.repo_context_bar('changelog', c.c

			




	
	
	
		
 
    ${self.breadcrumbs()}

			




	
	
	
		
 
  </div>

			




	
	
	
		
 
  <script>'use strict';

			




	
	
	
		
 
    AJAX_COMMENT_URL = ${h.js(url('changeset_comment',repo_name=c.repo_name,revision=c.changeset.raw_id))};

			




	
	
	
		
 
    AJAX_COMMENT_DELETE_URL = ${h.js(url('changeset_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))};

			




	
	
	
		
 
    var AJAX_COMMENT_URL = ${h.js(url('changeset_comment',repo_name=c.repo_name,revision=c.changeset.raw_id))};

			




	
	
	
		
 
    var AJAX_COMMENT_DELETE_URL = ${h.js(url('changeset_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))};

			




	
	
	
		
 
  </script>

			




	
	
	
		
 
  <div class="panel-body">

			




	
	
	
		
 
    <div class="panel panel-default">

			




        

    


    
    

    

        

                

                    kallithea/templates/pullrequests/pullrequest_show.html
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -314,8 +314,8 @@ ${self.repo_context_bar('showpullrequest

			




	
	
	
		
 
    </div>

			




	
	
	
		
 
    <script>'use strict';

			




	
	
	
		
 
    // TODO: switch this to pyroutes

			




	
	
	
		
 
    AJAX_COMMENT_URL = ${h.js(url('pullrequest_comment',repo_name=c.repo_name,pull_request_id=c.pull_request.pull_request_id))};

			




	
	
	
		
 
    AJAX_COMMENT_DELETE_URL = ${h.js(url('pullrequest_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))};

			




	
	
	
		
 
    var AJAX_COMMENT_URL = ${h.js(url('pullrequest_comment',repo_name=c.repo_name,pull_request_id=c.pull_request.pull_request_id))};

			




	
	
	
		
 
    var AJAX_COMMENT_DELETE_URL = ${h.js(url('pullrequest_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))};

			




	
	
	
		
 

			




	
	
	
		
 
    pyroutes.register('pullrequest_comment', ${h.js(url('pullrequest_comment',repo_name='%(repo_name)s',pull_request_id='%(pull_request_id)s'))}, ['repo_name', 'pull_request_id']);

			




	
	
	
		
 
    pyroutes.register('pullrequest_comment_delete', ${h.js(url('pullrequest_comment_delete',repo_name='%(repo_name)s',comment_id='%(comment_id)s'))}, ['repo_name', 'comment_id']);

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.0,
        which is
        © 2010–2025 by various authors & licensed under GPLv3.