kallithea Changeset - 1bdda21f186a

Changeset - 1bdda21f186a

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Thomas De Schampheleire - 8 years ago 2018-05-01 21:51:54
thomas.de_schampheleire@nokia.com

repo-scan: don't print empty list of results

If 'gearbox repo-scan' does not add nor remove anything, the output is:

Now scanning root location for new repos ...
Scan completed.
Added: -
Missing: -

These empty lists of results are not very helpful.
Instead, rework the code so that a list of added/removed/missing
repositories is only printed if it actually contains something.

1 file changed with 5 insertions and 7 deletions:

kallithea/lib/paster_commands/repo_scan.py

0 comments (0 inline, 0 general)

kallithea/lib/paster_commands/repo_scan.py

➞

Show inline comments

@@ @@ -37,32 +37,30 @@ from kallithea.lib.utils import repo2db_ @@
 class Command(BasePasterCommand):
     """Kallithea: Scan file system for repositories
     Search under the repository root configured in the database,
     all new repositories, and report missing ones with an option of removing them.
     """
     def take_action(self, args):
         rm_obsolete = args.delete_obsolete
         print 'Now scanning root location for new repos ...'
         added, removed = repo2db_mapper(ScmModel().repo_scan(),
                                         remove_obsolete=rm_obsolete)
         added = ', '.join(added) or '-'
         removed = ', '.join(removed) or '-'
         print 'Scan completed.'
         print 'Added: %s' % added
         if rm_obsolete:
             print 'Removed: %s' % removed
         else:
             print 'Missing: %s' % removed
         if added:
             print 'Added: %s' % ', '.join(added)
         if removed:
             print '%s: %s' % ('Removed' if rm_obsolete else 'Missing',
                               ', '.join(removed))
     def get_parser(self, prog_name):
         parser = super(Command, self).get_parser(prog_name)
         parser.add_argument(
             '--delete-obsolete',
             action='store_true',
             help="Use this flag do delete repositories that are "
                  "present in Kallithea database but not on the filesystem",
+        )
         return parser

0 comments (0 inline, 0 general)