kallithea Changeset - 1e7befa639cc

Changeset - 1e7befa639cc

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 12 years ago 2013-06-12 02:13:05
madski@unity3d.com

Grafted from: def4a0a688b3

pull request comments: implement 'close' as a checkbox that always is visible but sometimes disabled

2 files changed with 12 insertions and 5 deletions:

rhodecode/public/css/style.css

rhodecode/templates/changeset/changeset_file_comment.html

0 comments (0 inline, 0 general)

rhodecode/public/css/style.css

➞

Show inline comments

@@ @@ -3698,6 +3698,10 @@ div.gravatar img { @@
     border-color: rgba(0, 0, 0, 0.1) rgba(0, 0, 0, 0.1) rgba(0, 0, 0, 0.25);
+}
 label.disabled {
     color: #aaa;
+}
 .ui-btn.blue.hidden {
     display: none;
+}

rhodecode/templates/changeset/changeset_file_comment.html

➞

Show inline comments

@@ @@ -159,6 +159,10 @@ @@
                         <label for="${status}">${lbl}</label>
                     </div>
                 %endfor
                 %if close_btn and change_status:
                 <input id="save_close" type="checkbox" name="save_close" disabled="${'1' if cur_status in ['not_reviewed','under_review'] else ''}">
                 <label id="save_close_label" for="save_close" class="${'disabled' if cur_status in ['not_reviewed','under_review'] else ''}">${_("Close (when approved or rejected)")}</label>
                 %endif
             </div>
             %endif
             <div class="mentions-container" id="mentions_container"></div>
@@ @@ -175,9 +179,6 @@ @@
         <div class="comment-button">
         ${h.submit('save', _('Comment'), class_="ui-btn large")}
         %if close_btn and change_status:
            ${h.submit('save_close', _('Comment and close'), class_='ui-btn blue large %s' % ('hidden' if cur_status in ['not_reviewed','under_review'] else ''))}
         %endif
         </div>
         ${h.end_form()}
     </div>
@@ @@ -196,9 +197,11 @@ YUE.onDOMReady(function () { @@
    YUE.on(YUQ('.status_change_radio'), 'change',function(e){
        var val = e.currentTarget.value;
        if (val == 'approved' || val == 'rejected') {
            YUD.removeClass('save_close', 'hidden');
            YUD.removeClass('save_close_label', 'disabled');
            YUD.get('save_close').disabled = false;
        }else{
            YUD.addClass('save_close', 'hidden');
            YUD.addClass('save_close_label', 'disabled');
            YUD.get('save_close').disabled = true;
+       }
    })
    YUE.on('preview-btn', 'click', function(e){

0 comments (0 inline, 0 general)