kallithea Changeset - 1eeb3510917e

Changeset - 1eeb3510917e

Parent rev.

Child rev.

[Not reviewed]

stable

0 1 0

Mads Kiilerich - 10 years ago 2015-09-20 22:22:50
madski@unity3d.com

codemirror: remove the bad and hopefully unused CodeMirror.modeURL guessing

It should always be set in initCodeMirror before CodeMirror actually is used.

1 file changed with 0 insertions and 3 deletions:

kallithea/public/js/codemirror_loadmode.js

0 comments (0 inline, 0 general)

kallithea/public/js/codemirror_loadmode.js

➞

Show inline comments

 (function() {
   // FIXME: if this default value ever is used, it will probably be wrong
   if (!CodeMirror.modeURL) CodeMirror.modeURL = "../mode/%N/%N.js";
   var loading = {};
   function splitCallback(cont, n) {
     var countDown = n;
     return function() { if (--countDown == 0) cont(); };
+  }
   function ensureDeps(mode, cont) {
     var deps = CodeMirror.modes[mode].dependencies;
     if (!deps) return cont();
     var missing = [];
     for (var i = 0; i < deps.length; ++i) {
       if (!CodeMirror.modes.hasOwnProperty(deps[i]))
         missing.push(deps[i]);
+    }
     if (!missing.length) return cont();
     var split = splitCallback(cont, missing.length);
     for (var i = 0; i < missing.length; ++i)
       CodeMirror.requireMode(missing[i], split);
+  }
   CodeMirror.requireMode = function(mode, cont) {
     if (typeof mode != "string") mode = mode.mode;
     if (CodeMirror.modes.hasOwnProperty(mode)) return ensureDeps(mode, cont);
     if (loading.hasOwnProperty(mode)) return loading[mode].push(cont);

0 comments (0 inline, 0 general)