Changeset - 1f3e993156e4
[Not reviewed]
default
0 31 0
Mads Kiilerich - 6 years ago 2020-02-17 17:14:12
mads@kiilerich.com
js: omit redundant type="text/javascript"

We already used plain '<script>' in several places.

https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type :
"Authors should omit the attribute, instead of redundantly giving a JavaScript
MIME type."
31 files changed with 66 insertions and 66 deletions:
0 comments (0 inline, 0 general)
kallithea/templates/admin/admin_log.html
Show inline comments
 
@@ -37,7 +37,7 @@
 
    %endfor
 
</table>
 

	
 
<script type="text/javascript">
 
<script>
 
  $(document).ready(function(){
 
    var $user_log = $('#user_log');
 
    $user_log.on('click','.pager_link',function(e){
kallithea/templates/admin/gists/edit.html
Show inline comments
 
@@ -6,9 +6,9 @@
 
</%block>
 

	
 
<%block name="js_extra">
 
  <script type="text/javascript" src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/codemirror/mode/meta.js')}"></script>
 
  <script src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script src="${h.url('/codemirror/mode/meta.js')}"></script>
 
</%block>
 
<%block name="css_extra">
 
  <link rel="stylesheet" type="text/css" href="${h.url('/codemirror/lib/codemirror.css')}"/>
 
@@ -79,7 +79,7 @@
 
                </div>
 

	
 
                ## dynamic edit box.
 
                <script type="text/javascript">
 
                <script>
 
                    $(document).ready(function(){
 
                        var myCodeMirror = initCodeMirror(${h.js('editor_' + h.FID('f',file.path))}, ${h.jshtml(request.script_name)}, '');
 

	
kallithea/templates/admin/gists/new.html
Show inline comments
 
@@ -6,9 +6,9 @@
 
</%block>
 

	
 
<%block name="js_extra">
 
  <script type="text/javascript" src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/codemirror/mode/meta.js')}"></script>
 
  <script src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script src="${h.url('/codemirror/mode/meta.js')}"></script>
 
</%block>
 
<%block name="css_extra">
 
  <link rel="stylesheet" type="text/css" href="${h.url('/codemirror/lib/codemirror.css')}"/>
 
@@ -55,7 +55,7 @@
 
            ${h.reset('reset',_('Reset'),class_="btn btn-default btn-xs")}
 
            </div>
 
          ${h.end_form()}
 
          <script type="text/javascript">
 
          <script>
 
            $(document).ready(function(){
 
                var myCodeMirror = initCodeMirror('editor', ${h.jshtml(request.script_name)}, '');
 

	
kallithea/templates/admin/repo_groups/repo_group_edit_perms.html
Show inline comments
 
@@ -102,7 +102,7 @@ ${h.form(url('edit_repo_group_perms', gr
 
</div>
 
${h.end_form()}
 

	
 
<script type="text/javascript">
 
<script>
 
    function ajaxActionRevoke(obj_id, obj_type, field_id, obj_name) {
 
        url = ${h.jshtml(h.url('edit_repo_group_perms_delete', group_name=c.repo_group.group_name))};
 
        var revoke_msg = _TM['Confirm to revoke permission for {0}: {1} ?'].format(obj_type.replace('_', ' '), obj_name);
kallithea/templates/admin/repos/repo_edit_permissions.html
Show inline comments
 
@@ -87,7 +87,7 @@ ${h.form(url('edit_repo_perms_update', r
 
</div>
 
${h.end_form()}
 

	
 
<script type="text/javascript">
 
<script>
 
    function ajaxActionRevoke(obj_id, obj_type, field_id, obj_name) {
 
        url = ${h.js(h.url('edit_repo_perms_revoke',repo_name=c.repo_name))};
 
        var revoke_msg = _TM['Confirm to revoke permission for {0}: {1} ?'].format(obj_type.replace('_', ' '), obj_name);
kallithea/templates/admin/settings/settings_hooks.html
Show inline comments
 
@@ -50,7 +50,7 @@ ${h.form(url('admin_settings_hooks'), me
 
${h.end_form()}
 
% endif
 

	
 
<script type="text/javascript">
 
<script>
 
function delete_hook(hook_id, field_id) {
 
    var sUrl = ${h.js(h.url('admin_settings_hooks_delete'))};
 
    var success = function (o) {
kallithea/templates/admin/settings/settings_vcs.html
Show inline comments
 
@@ -69,7 +69,7 @@ ${h.form(url('admin_settings'), method='
 
    </div>
 
    ${h.end_form()}
 

	
 
    <script type="text/javascript">
 
    <script>
 
        $(document).ready(function(){
 
            $('#path_unlock').on('click', function(e){
 
                $('#path_unlock_icon').removeClass('icon-lock');
kallithea/templates/admin/user_groups/user_group_edit_perms.html
Show inline comments
 
@@ -92,7 +92,7 @@ ${h.form(url('edit_user_group_perms_upda
 
</div>
 
${h.end_form()}
 

	
 
<script type="text/javascript">
 
<script>
 
    function ajaxActionRevoke(obj_id, obj_type, field_id, obj_name) {
 
        url = ${h.js(h.url('edit_user_group_perms_delete', id=c.user_group.users_group_id))};
 
        var revoke_msg = _TM['Confirm to revoke permission for {0}: {1} ?'].format(obj_type.replace('_', ' '), obj_name);
kallithea/templates/admin/user_groups/user_group_edit_settings.html
Show inline comments
 
@@ -48,6 +48,6 @@ ${h.form(url('update_users_group', id=c.
 
                </div>
 
    </div>
 
${h.end_form()}
 
<script type="text/javascript">
 
<script>
 
  MultiSelectWidget('users_group_members','available_members','edit_users_group');
 
</script>
kallithea/templates/base/base.html
Show inline comments
 
@@ -177,7 +177,7 @@
 
    </div>
 
    </div>
 
  </nav>
 
  <script type="text/javascript">
 
  <script>
 
    $(document).ready(function() {
 
      var bcache = {};
 

	
 
@@ -399,7 +399,7 @@
 
    </li>
 
  </ul>
 

	
 
    <script type="text/javascript">
 
    <script>
 
        $(document).ready(function(){
 
            var visual_show_public_icon = ${h.js(c.visual.show_public_icon)};
 
            var cache = {}
 
@@ -527,7 +527,7 @@
 
        </div>
 
    </div>
 

	
 
    <script type="text/javascript">
 
    <script>
 
      $(document).ready(function(){
 
          activate_parent_child_links();
 
      });
kallithea/templates/base/root.html
Show inline comments
 
@@ -21,7 +21,7 @@
 
        <%block name="css_extra"/>
 

	
 
        ## JAVASCRIPT ##
 
        <script type="text/javascript">
 
        <script>
 
            ## JS translations map
 
            var TRANSLATION_MAP = {
 
                'Cancel': ${h.jshtml(_("Cancel"))},
 
@@ -67,17 +67,17 @@
 

	
 
            var _session_csrf_secret_token = ${h.js(h.session_csrf_secret_token())};
 
        </script>
 
        <script type="text/javascript" src="${h.url('/js/jquery.min.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/jquery.dataTables.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/dataTables.bootstrap.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/bootstrap.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/select2.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/jquery.caret.min.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/jquery.atwho.min.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript" src="${h.url('/js/base.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/jquery.min.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/jquery.dataTables.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/dataTables.bootstrap.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/bootstrap.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/select2.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/jquery.caret.min.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/jquery.atwho.min.js', ver=c.kallithea_version)}"></script>
 
        <script src="${h.url('/js/base.js', ver=c.kallithea_version)}"></script>
 
        ## EXTRA FOR JS
 
        <%block name="js_extra"/>
 
        <script type="text/javascript">
 
        <script>
 
            $(document).ready(function(){
 
              tooltip_activate();
 
              show_more_event();
kallithea/templates/changelog/changelog.html
Show inline comments
 
@@ -80,8 +80,8 @@ ${self.repo_context_bar('changelog', c.f
 

	
 
                ${c.cs_pagination.pager()}
 

	
 
        <script type="text/javascript" src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
        <script type="text/javascript">
 
        <script src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
        <script>
 
            var jsdata = ${h.js(c.jsdata)};
 
            var graph = new BranchRenderer('graph_canvas', 'graph_content', 'chg_');
 

	
kallithea/templates/changelog/changelog_table.html
Show inline comments
 
@@ -110,7 +110,7 @@
 
    </tbody>
 
    </table>
 

	
 
<script type="text/javascript">
 
<script>
 
  $(document).ready(function() {
 
    $('#changesets .expand_commit').on('click',function(e){
 
      $(this).next('.mid').find('.message > div').toggleClass('hidden');
kallithea/templates/changeset/changeset.html
Show inline comments
 
@@ -184,7 +184,7 @@ ${self.repo_context_bar('changelog', c.c
 
    </div>
 

	
 
    ## FORM FOR MAKING JS ACTION AS CHANGESET COMMENTS
 
    <script type="text/javascript">
 
    <script>
 
      $(document).ready(function(){
 
          $('.code-difftable').on('click', '.add-bubble', function(e){
 
              show_comment_form($(this));
kallithea/templates/changeset/diff_block.html
Show inline comments
 
@@ -96,7 +96,7 @@
 
</%def>
 

	
 
<%def name="diff_block_js()">
 
<script type="text/javascript">
 
<script>
 
$(document).ready(function(){
 
    $('.btn-image-diff-show').click(function(e){
 
        $('.btn-image-diff-show').hide();
kallithea/templates/compare/compare_cs.html
Show inline comments
 
@@ -63,10 +63,10 @@
 
%if c.is_ajax_preview:
 
<div id="jsdata" style="display:none">${h.js(c.jsdata)}</div>
 
%else:
 
<script type="text/javascript" src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
<script src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
%endif
 

	
 
<script type="text/javascript">
 
<script>
 
    var jsdata = ${h.js(c.jsdata)};
 
    var graph = new BranchRenderer('graph_canvas', 'graph_content_pr', 'chg_');
 

	
kallithea/templates/compare/compare_diff.html
Show inline comments
 
@@ -98,7 +98,7 @@ ${self.repo_context_bar('changelog')}
 
    </div>
 

	
 
</div>
 
    <script type="text/javascript">
 
    <script>
 

	
 
   $(document).ready(function(){
 
    var cache = {};
kallithea/templates/files/diff_2way.html
Show inline comments
 
@@ -3,8 +3,8 @@
 
<%inherit file="/base/base.html"/>
 

	
 
<%block name="js_extra">
 
  <script type="text/javascript" src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/js/mergely.js')}"></script>
 
  <script src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script src="${h.url('/js/mergely.js')}"></script>
 
</%block>
 
<%block name="css_extra">
 
  <link rel="stylesheet" type="text/css" href="${h.url('/codemirror/lib/codemirror.css')}"/>
kallithea/templates/files/files.html
Show inline comments
 
@@ -36,7 +36,7 @@ ${self.repo_context_bar('files', c.revis
 
    </div>
 
</div>
 

	
 
<script type="text/javascript">
 
<script>
 
var CACHE = {};
 
var CACHE_EXPIRE = 5*60*1000; //cache for 5*60s
 
//used to construct links from the search list
kallithea/templates/files/files_add.html
Show inline comments
 
@@ -5,9 +5,9 @@
 
</%block>
 

	
 
<%block name="js_extra">
 
  <script type="text/javascript" src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/codemirror/mode/meta.js')}"></script>
 
  <script src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script src="${h.url('/codemirror/mode/meta.js')}"></script>
 
</%block>
 
<%block name="css_extra">
 
  <link rel="stylesheet" type="text/css" href="${h.url('/codemirror/lib/codemirror.css')}"/>
 
@@ -70,7 +70,7 @@ ${self.repo_context_bar('files')}
 
              </div>
 
            </div>
 
            ${h.end_form()}
 
            <script type="text/javascript">
 
            <script>
 
                $(document).ready(function(){
 
                    var reset_url = ${h.jshtml(h.url('files_home',repo_name=c.repo_name,revision=c.cs.raw_id,f_path=c.f_path))};
 
                    var myCodeMirror = initCodeMirror('editor', ${h.jshtml(request.script_name)}, reset_url);
kallithea/templates/files/files_edit.html
Show inline comments
 
@@ -5,9 +5,9 @@
 
</%block>
 

	
 
<%block name="js_extra">
 
  <script type="text/javascript" src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script type="text/javascript" src="${h.url('/codemirror/mode/meta.js')}"></script>
 
  <script src="${h.url('/codemirror/lib/codemirror.js')}"></script>
 
  <script src="${h.url('/js/codemirror_loadmode.js')}"></script>
 
  <script src="${h.url('/codemirror/mode/meta.js')}"></script>
 
</%block>
 
<%block name="css_extra">
 
  <link rel="stylesheet" type="text/css" href="${h.url('/codemirror/lib/codemirror.css')}"/>
 
@@ -77,7 +77,7 @@ ${self.repo_context_bar('files')}
 
    </div>
 
</div>
 

	
 
<script type="text/javascript">
 
<script>
 
    $(document).ready(function(){
 
        var reset_url = ${h.jshtml(h.url('files_home',repo_name=c.repo_name,revision=c.cs.raw_id,f_path=c.file.path))};
 
        var myCodeMirror = initCodeMirror('editor', ${h.jshtml(request.script_name)}, reset_url);
kallithea/templates/followers/followers.html
Show inline comments
 
@@ -25,7 +25,7 @@ ${self.repo_context_bar('followers')}
 
        </div>
 
    </div>
 
</div>
 
<script type="text/javascript">
 
<script>
 
  $(document).ready(function(){
 
    var $followers = $('#followers');
 
    $followers.on('click','.pager_link',function(e){
kallithea/templates/forks/forks.html
Show inline comments
 
@@ -25,7 +25,7 @@ ${self.repo_context_bar('showforks')}
 
        </div>
 
    </div>
 
</div>
 
<script type="text/javascript">
 
<script>
 
  $(document).ready(function(){
 
      var $forks = $('#forks');
 
      $forks.on('click','.pager_link',function(e){
kallithea/templates/journal/journal.html
Show inline comments
 
@@ -41,7 +41,7 @@
 
        </div>
 
    </div>
 

	
 
<script type="text/javascript">
 
<script>
 

	
 
    $('#j_filter').click(function(){
 
        var $jfilter = $('#j_filter');
 
@@ -72,7 +72,7 @@
 

	
 
</script>
 

	
 
<script type="text/javascript">
 
<script>
 
    $(document).ready(function(){
 
        var $journal = $('#journal');
 
        $journal.on('click','.pager_link',function(e){
kallithea/templates/login.html
Show inline comments
 
@@ -64,7 +64,7 @@
 
            </div>
 
        </div>
 
        ${h.end_form()}
 
        <script type="text/javascript">
 
        <script>
 
        $(document).ready(function(){
 
            $('#username').focus();
 
        });
kallithea/templates/password_reset.html
Show inline comments
 
@@ -7,7 +7,7 @@
 

	
 
<%block name="js_extra">
 
    %if c.captcha_active:
 
        <script type="text/javascript" src="https://www.google.com/recaptcha/api.js"></script>
 
        <script src="https://www.google.com/recaptcha/api.js"></script>
 
    %endif
 
</%block>
 

	
 
@@ -53,7 +53,7 @@
 
                </div>
 
        </div>
 
        ${h.end_form()}
 
        <script type="text/javascript">
 
        <script>
 
         $(document).ready(function(){
 
            $('#email').focus();
 
         });
kallithea/templates/pullrequests/pullrequest.html
Show inline comments
 
@@ -91,8 +91,8 @@ ${self.repo_context_bar('showpullrequest
 

	
 
</div>
 

	
 
<script type="text/javascript" src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
<script type="text/javascript">
 
<script src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 
<script>
 
  pyroutes.register('pullrequest_repo_info', ${h.js(url('pullrequest_repo_info',repo_name='%(repo_name)s'))}, ['repo_name']);
 

	
 
  var pendingajax = undefined;
kallithea/templates/pullrequests/pullrequest_show.html
Show inline comments
 
@@ -343,7 +343,7 @@ ${self.repo_context_bar('showpullrequest
 
    ## main comment form and it status
 
    ${comment.comments(change_status=c.allowed_to_change_status)}
 

	
 
    <script type="text/javascript">
 
    <script>
 
      $(document).ready(function(){
 
          PullRequestAutoComplete($('#user'));
 
          SimpleUserAutoComplete($('#owner'));
kallithea/templates/register.html
Show inline comments
 
@@ -7,7 +7,7 @@
 

	
 
<%block name="js_extra">
 
    %if c.captcha_active:
 
        <script type="text/javascript" src="https://www.google.com/recaptcha/api.js"></script>
 
        <script src="https://www.google.com/recaptcha/api.js"></script>
 
    %endif
 
</%block>
 

	
 
@@ -90,7 +90,7 @@
 
                </div>
 
        </div>
 
        ${h.end_form()}
 
        <script type="text/javascript">
 
        <script>
 
        $(document).ready(function(){
 
            $('#username').focus();
 
        });
kallithea/templates/summary/statistics.html
Show inline comments
 
@@ -15,9 +15,9 @@
 
<%block name="head_extra">
 
  <link href="${h.url('atom_feed_home',repo_name=c.db_repo.repo_name,api_key=request.authuser.api_key)}" rel="alternate" title="${_('%s ATOM feed') % c.repo_name}" type="application/atom+xml" />
 
  <link href="${h.url('rss_feed_home',repo_name=c.db_repo.repo_name,api_key=request.authuser.api_key)}" rel="alternate" title="${_('%s RSS feed') % c.repo_name}" type="application/rss+xml" />
 
  <script type="text/javascript" src="${h.url('/js/jquery.flot.js', ver=c.kallithea_version)}"></script>
 
  <script type="text/javascript" src="${h.url('/js/jquery.flot.selection.js', ver=c.kallithea_version)}"></script>
 
  <script type="text/javascript" src="${h.url('/js/jquery.flot.time.js', ver=c.kallithea_version)}"></script>
 
  <script src="${h.url('/js/jquery.flot.js', ver=c.kallithea_version)}"></script>
 
  <script src="${h.url('/js/jquery.flot.selection.js', ver=c.kallithea_version)}"></script>
 
  <script src="${h.url('/js/jquery.flot.time.js', ver=c.kallithea_version)}"></script>
 
</%block>
 

	
 
<%def name="main()">
 
@@ -51,7 +51,7 @@ ${self.repo_context_bar('summary')}
 
    </div>
 
</div>
 

	
 
<script type="text/javascript">
 
<script>
 
var data = ${h.js(c.trending_languages)};
 
var total = 0;
 
var tbl = document.createElement('table');
 
@@ -118,7 +118,7 @@ for (var i=0;i<data.length;i++){
 
}
 

	
 
</script>
 
<script type="text/javascript">
 
<script>
 

	
 
/**
 
 * Plots summary graph
kallithea/templates/summary/summary.html
Show inline comments
 
@@ -238,7 +238,7 @@ hg push ${c.clone_repo_url}
 
</div>
 
%endif
 

	
 
<script type="text/javascript">
 
<script>
 
$(document).ready(function(){
 
    $('#clone-url input').click(function(e){
 
        if($(this).hasClass('selected')){
 
@@ -334,7 +334,7 @@ $(document).ready(function(){
 
</script>
 

	
 
%if c.show_stats:
 
<script type="text/javascript">
 
<script>
 
$(document).ready(function(){
 
    var data = ${h.js(c.trending_languages)};
 
    var total = 0;
0 comments (0 inline, 0 general)