kallithea Changeset - 1fa33126ed25

Changeset - 1fa33126ed25

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

domruf - 8 years ago 2017-10-30 01:26:31
dominikruf@gmail.com

less: make pull request 'next iteration' changeset table smaller and scrollable

This property was lost in 88ce09daea37.

When the whole list is made scrollable, the graph can no longer be positioned
absolute. Instead, make it relative so it scrolls with the content ... and 0
height (with the graph overflowing) so the table content will be shown next to
the overflowing graph.

2 files changed with 17 insertions and 2 deletions:

kallithea/public/css/style.css

kallithea/public/less/style.less

0 comments (0 inline, 0 general)

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -723,194 +723,195 @@ table#changesets tr > td.mid { @@
   width: 100%;
   padding: 0;
+}
 table#changesets .log-container {
   position: relative;
   margin-top: 8px;
+}
 table#changesets tr #singlerange,
 table#changesets tr .changeset_range {
   float: left;
   margin: 2px 0;
+}
 table#changesets tr > td.author img {
   vertical-align: middle;
+}
 table#changesets tr > td.author .user {
   color: #444444;
+}
 table#changesets tr > td.mid .message,
 #graph_content_pr .compare_view_commits .message {
   white-space: nowrap;
   padding: 0;
   overflow: hidden;
+}
 #graph_content_pr .compare_view_commits .message {
   padding: 0 !important;
+}
 table#changesets tr > td.mid .message.expanded,
 #graph_content_pr .compare_view_commits .message.expanded {
   height: auto;
   overflow: initial;
+}
 table#changesets tr .extra-container {
   display: block;
   position: absolute;
   top: -15px;
   right: 0;
   padding-left: 5px;
   background: #FFFFFF;
   height: 41px;
+}
 #pull_request_overview .comments-container,
 #changeset_compare_view_content .comments-container,
 table#changesets .comments-container,
 #shortlog_data .comments-container,
 table#changesets .logtags {
   display: block;
   float: left;
   overflow: hidden;
   padding: 0;
   margin: 0;
   white-space: nowrap;
+}
 table#changesets .comments-container {
   margin: 0.8em 0;
   margin-right: 0.5em;
+}
 table#changesets .tagcontainer {
   width: 80px;
   position: relative;
   float: right;
   height: 100%;
   top: 7px;
   margin-left: 0.5em;
+}
 table#changesets .logtags {
   min-width: 80px;
   height: 1.1em;
   position: absolute;
   left: 0px;
   width: auto;
   top: 0px;
+}
 table#changesets .logtags.tags {
   top: 14px;
+}
 table#changesets .logtags:hover {
   overflow: visible;
   position: absolute;
   width: auto;
   right: 0;
   left: initial;
+}
 table#changesets .logtags .booktag,
 table#changesets .logtags .tagtag {
   float: left;
   line-height: 1em;
   margin-bottom: 1px;
   margin-right: 1px;
   padding: 1px 3px;
   font-size: 10px;
+}
 table#changesets tr > td.mid .message a:hover {
   text-decoration: none;
+}
 #updaterevs-graph {
-  position: absolute;
+  position: relative;
   width: 40px;
   height: 0;
+}
 #updaterevs-table {
   margin-left: 40px !important;
+}
 .issue-tracker-link {
   color: #3F6F9F;
   font-weight: bold !important;
+}
 /* changeset statuses (must be the same name as the status) */
 .changeset-status-not_reviewed {
   color: #bababa;
+}
 .changeset-status-approved {
   color: #81ba51;
+}
 .changeset-status-rejected {
   color: #d06060;
+}
 .changeset-status-under_review {
   color: #ffc71e;
+}
 .pull-right .changes {
   clear: both;
+}
 .pull-right .changes .changed_total {
   display: block;
   float: right;
   text-align: center;
   min-width: 45px;
   cursor: pointer;
   color: #444444;
   background: #FEA;
   border-radius: 0px 0px 0px 6px;
   padding: 1px;
+}
 .pull-right .changes .added,
 .pull-right .changes .changed,
 .pull-right .changes .deleted {
   color: #444444;
+}
 .pull-right .changes .added {
   background: #CFC;
+}
 .pull-right .changes .changed {
   background: #FEA;
+}
 .pull-right .changes .deleted {
   background: #FAA;
+}
 .panel .search div.search_path {
   background: none repeat scroll 0 0 #EEE;
   border: 1px solid #CCC;
   color: blue;
   margin-bottom: 10px;
   padding: 10px 0;
+}
 .panel .search div.search_path div.link {
   font-weight: 700;
   margin-left: 25px;
+}
 .panel .search div.search_path div.link a {
   color: #577632;
   cursor: pointer;
   text-decoration: none;
+}
 .yui-overlay,
 .yui-panel-container {
   visibility: hidden;
   position: absolute;
   z-index: 2;
+}
 .ac {
   vertical-align: top;
+}
 .ac .yui-ac {
   position: inherit;
   font-size: 100%;
+}
 .ac .perm_ac {
   width: 20em;
+}
 .ac .yui-ac-input {
   width: 100%;
+}
 .ac .yui-ac-container {
   position: absolute;
   top: 1.6em;
   width: auto;
+}
 .ac .yui-ac-content {
   position: absolute;
   border: 1px solid gray;
   background: #fff;
   z-index: 9050;
+}
 .ac .yui-ac-shadow {
@@ @@ -1355,192 +1356,198 @@ form.comment-inline-form { @@
+}
 .comment-inline-form .comment-button {
   padding-top: 5px;
+}
 /** comment inline **/
 .inline-comments .comment {
   margin: 3px 3px 5px 5px;
+}
 .inline-comments #comments-general-comments .comment {
   margin-left: 0;
+}
 .inline-comments .add-button-row {
   padding: 2px 4px 8px 5px;
+}
 .inline-comments .comments-number {
   padding: 0px 0px 10px 0px;
   color: #666;
+}
 input.status_change_checkbox,
 input.status_change_radio {
   margin: 0 0 5px 15px;
+}
 .badge {
   padding: 4px 4px !important;
   text-align: center;
   color: #888 !important;
   background-color: #DEDEDE !important;
   border-radius: 4px !important;
+}
 @keyframes animated-comment-background {
 % {
     background-position: 0 0;
+  }
 % {
     background-position: 20px 0;
+  }
+}
 .comment-preview.failed .user,
 .comment-preview.failed .panel-body {
   color: #666;
+}
 .comment-preview .comment-submission-status {
   float: right;
+}
 .comment-preview .comment-submission-status .btn-group {
   margin-left: 10px;
+}
 .comment-preview.submitting .panel-body {
   background-image: linear-gradient(-45deg, #FAFAFA, #FAFAFA 25%, #FFF 25%, #FFF 50%, #FAFAFA 50%, #FAFAFA 75%, #FFF 75%, #FFF 100%);
   background-size: 20px 20px;
   animation: animated-comment-background 0.4s linear infinite;
+}
 /****
 PULL REQUESTS
 *****/
 div.pr-details-title.closed {
   color: #555;
   background: #eee;
+}
 div.pr {
   margin: 0px 15px;
   padding: 4px 4px;
+}
 tr.pr-closed td {
   background-color: #eee !important;
   color: #555 !important;
+}
 span.pr-closed-tag {
   margin-bottom: 1px;
   margin-right: 1px;
   padding: 1px 3px;
   font-size: 10px;
   color: #577632;
   white-space: nowrap;
   border-radius: 4px;
   border: 1px solid #d9e8f8;
   line-height: 1.5em;
+}
 .panel-body .pr-box {
   max-width: 978px;
   margin-right: 15px;
+}
 #s2id_org_ref,
 #s2id_other_ref,
 #s2id_org_repo,
 #s2id_other_repo {
   min-width: 150px;
   margin: 5px;
+}
 #pr-summary > .pr-not-edit {
   min-height: 50px !important;
+}
 #pr-edit-btn {
   margin: 20px 0 0 !important;
   position: absolute;
+}
 /* make 'next iteration' changeset table smaller and scrollable */
 #pr-summary #updaterevs {
   max-height: 200px;
   overflow-y: auto;
   overflow-x: hidden;
+}
 /****
   PERMS
 *****/
 .perm-gravatar-ac {
   vertical-align: middle;
   padding: 2px;
   width: 14px;
   height: 14px;
+}
 /* avoid gaps between the navbar and browser */
 .navbar.mainmenu {
   border-top-left-radius: 0;
   border-top-right-radius: 0;
+}
 .navbar.footer {
   border-bottom-left-radius: 0;
   border-bottom-right-radius: 0;
+}
 /* bootstrap progress bar has margin-bottom we don't want that in files list */
 .cs_files .progress {
   margin-bottom: 0;
+}
 /* progress bars should be aligned right */
 .cs_files .changes {
   float: right;
   color: #577632;
+}
 /* colors for changes */
 .cs_files .changes .added {
   color: inherit;
   background-color: #BBFFBB;
   float: left;
   text-align: center;
   font-size: 9px;
   padding: 2px 0px 2px 0px;
+}
 .cs_files .changes .deleted {
   background-color: #FF8888;
   float: left;
   text-align: center;
   font-size: 9px;
   padding: 2px 0px 2px 0px;
+}
 /* binary
 NEW_FILENODE = 1
 DEL_FILENODE = 2
 MOD_FILENODE = 3
 RENAMED_FILENODE = 4
 CHMOD_FILENODE = 5
 BIN_FILENODE = 6
 */
 .changes .bin {
   background-color: #BBFFBB;
   float: left;
   text-align: center;
   font-size: 9px;
   padding: 2px 0px 2px 0px;
+}
 /* added binary */
 .changes .bin.bin1 {
   background-color: #BBFFBB;
+}
 /* deleted binary*/
 .changes .bin.bin2 {
   background-color: #FF8888;
+}
 /* mod binary*/
 .changes .bin.bin3 {
   background-color: #DDDDDD;
+}
 /* rename file*/
 .changes .bin.bin4 {
   background-color: #6D99FF;
+}
 /* chmod file*/
 .changes .bin.bin5 {
   background-color: #6D99FF;
+}
 /* center collapse button */
 .diff-collapse {
   text-align: center;
   margin-bottom: 15px;
+}
 .code-difftable {
   /* the whole line should be colored */
   border-collapse: collapse;
   border-radius: 0px !important;
   width: 100%;
   /* line coloring */
   /* tabs */
   /* CR */
   /* whitespace characters */
   /* trailing spaces */
   /** LINE NUMBERS **/
   /** CODE **/
   /* leading +/- on changed lines */

kallithea/public/less/style.less

➞

Show inline comments

@@ @@ -520,194 +520,195 @@ table#changesets tr > td.mid { @@
   width: 100%;
   padding: 0;
+}
 table#changesets .log-container {
   position: relative;
   margin-top: 8px;
+}
 table#changesets tr #singlerange,
 table#changesets tr .changeset_range {
   float: left;
   margin: 2px 0;
+}
 table#changesets tr > td.author img {
   vertical-align: middle;
+}
 table#changesets tr > td.author .user {
   color: #444444;
+}
 table#changesets tr > td.mid .message,
 #graph_content_pr .compare_view_commits .message {
   white-space: nowrap;
   padding: 0;
   overflow: hidden;
+}
 #graph_content_pr .compare_view_commits .message {
   padding: 0 !important;
+}
 table#changesets tr > td.mid .message.expanded,
 #graph_content_pr .compare_view_commits .message.expanded {
   height: auto;
   overflow: initial;
+}
 table#changesets tr .extra-container {
   display: block;
   position: absolute;
   top: -15px;
   right: 0;
   padding-left: 5px;
   background: #FFFFFF;
   height: 41px;
+}
 #pull_request_overview .comments-container,
 #changeset_compare_view_content .comments-container,
 table#changesets .comments-container,
 #shortlog_data .comments-container,
 table#changesets .logtags {
   display: block;
   float: left;
   overflow: hidden;
   padding: 0;
   margin: 0;
   white-space: nowrap;
+}
 table#changesets .comments-container {
   margin: 0.8em 0;
   margin-right: 0.5em;
+}
 table#changesets .tagcontainer {
   width: 80px;
   position: relative;
   float: right;
   height: 100%;
   top: 7px;
   margin-left: 0.5em;
+}
 table#changesets .logtags {
   min-width: 80px;
   height: 1.1em;
   position: absolute;
   left: 0px;
   width: auto;
   top: 0px;
+}
 table#changesets .logtags.tags {
   top: 14px;
+}
 table#changesets .logtags:hover {
   overflow: visible;
   position: absolute;
   width: auto;
   right: 0;
   left: initial;
+}
 table#changesets .logtags .booktag,
 table#changesets .logtags .tagtag {
   float: left;
   line-height: 1em;
   margin-bottom: 1px;
   margin-right: 1px;
   padding: 1px 3px;
   font-size: 10px;
+}
 table#changesets tr > td.mid .message a:hover {
   text-decoration: none;
+}
 #updaterevs-graph {
-  position: absolute;
+  position: relative;
   width: 40px;
   height: 0;
+}
 #updaterevs-table {
   margin-left: 40px !important;
+}
 .issue-tracker-link {
   color: #3F6F9F;
   font-weight: bold !important;
+}
 /* changeset statuses (must be the same name as the status) */
 .changeset-status-not_reviewed {
   color: #bababa;
+}
 .changeset-status-approved {
   color: #81ba51;
+}
 .changeset-status-rejected {
   color: #d06060;
+}
 .changeset-status-under_review {
   color: #ffc71e;
+}
 .pull-right .changes {
   clear: both;
+}
 .pull-right .changes .changed_total {
   display: block;
   float: right;
   text-align: center;
   min-width: 45px;
   cursor: pointer;
   color: #444444;
   background: #FEA;
   border-radius: 0px 0px 0px 6px;
   padding: 1px;
+}
 .pull-right .changes .added,
 .pull-right .changes .changed,
 .pull-right .changes .deleted {
   color: #444444;
+}
 .pull-right .changes .added {
   background: #CFC;
+}
 .pull-right .changes .changed {
   background: #FEA;
+}
 .pull-right .changes .deleted {
   background: #FAA;
+}
 .panel .search div.search_path {
   background: none repeat scroll 0 0 #EEE;
   border: 1px solid #CCC;
   color: blue;
   margin-bottom: 10px;
   padding: 10px 0;
+}
 .panel .search div.search_path div.link {
   font-weight: 700;
   margin-left: 25px;
+}
 .panel .search div.search_path div.link a {
   color: #577632;
   cursor: pointer;
   text-decoration: none;
+}
 @import "yui-ac.less";
 #repo_size {
   display: block;
   margin-top: 4px;
   color: #666;
   float: right;
+}
 .currently_following {
   padding-left: 10px;
   padding-bottom: 5px;
+}
 #switch_repos {
   position: absolute;
   height: 25px;
   z-index: 1;
+}
 #switch_repos select {
   min-width: 150px;
   max-height: 250px;
   z-index: 1;
+}
 .breadcrumbs {
   border: medium none;
   color: #FFF;
   font-weight: 700;
   font-size: 14px;
+}
 table#permissions_manage span.private_repo_msg {
   font-size: 0.8em;
   opacity: 0.6;
@@ @@ -1050,192 +1051,199 @@ form.comment-inline-form { @@
+}
 .comment-inline-form .comment-button {
   padding-top: 5px;
+}
 /** comment inline **/
 .inline-comments .comment {
   margin: 3px 3px 5px 5px;
+}
 .inline-comments #comments-general-comments .comment {
   margin-left: 0;
+}
 .inline-comments .add-button-row {
   padding: 2px 4px 8px 5px;
+}
 .inline-comments .comments-number {
   padding: 0px 0px 10px 0px;
   color: #666;
+}
 input.status_change_checkbox,
 input.status_change_radio {
   margin: 0 0 5px 15px;
+}
 .badge {
   padding: 4px 4px !important;
   text-align: center;
   color: #888 !important;
   background-color: #DEDEDE !important;
   border-radius: 4px !important;
+}
 @keyframes animated-comment-background {
 % {
     background-position: 0 0;
+  }
 % {
     background-position: 20px 0;
+  }
+}
 .comment-preview.failed .user,
 .comment-preview.failed .panel-body {
   color: #666;
+}
 .comment-preview .comment-submission-status {
   float: right;
+}
 .comment-preview .comment-submission-status .btn-group {
   margin-left: 10px;
+}
 .comment-preview.submitting .panel-body {
   background-image: linear-gradient(-45deg, #FAFAFA, #FAFAFA 25%, #FFF 25%, #FFF 50%, #FAFAFA 50%, #FAFAFA 75%, #FFF 75%, #FFF 100%);
   background-size: 20px 20px;
   animation: animated-comment-background 0.4s linear infinite;
+}
 /****
 PULL REQUESTS
 *****/
 div.pr-details-title.closed {
   color: #555;
   background: #eee;
+}
 div.pr {
   margin: 0px 15px;
   padding: 4px 4px;
+}
 tr.pr-closed td {
   background-color: #eee !important;
   color: #555 !important;
+}
 span.pr-closed-tag {
   margin-bottom: 1px;
   margin-right: 1px;
   padding: 1px 3px;
   font-size: 10px;
   color: #577632;
   white-space: nowrap;
   border-radius: 4px;
   border: 1px solid #d9e8f8;
   line-height: 1.5em;
+}
 .panel-body .pr-box {
   max-width: 978px;
   margin-right: 15px;
+}
 #s2id_org_ref,
 #s2id_other_ref,
 #s2id_org_repo,
 #s2id_other_repo {
   min-width: 150px;
   margin: 5px;
+}
 #pr-summary > .pr-not-edit {
   min-height: 50px !important;
+}
 #pr-edit-btn {
   margin: 20px 0 0 !important;
   position: absolute;
+}
 /* make 'next iteration' changeset table smaller and scrollable */
 #pr-summary #updaterevs {
   max-height: 200px;
   overflow-y: auto;
   overflow-x: hidden;
+}
 /****
   PERMS
 *****/
 .perm-gravatar-ac {
   vertical-align: middle;
   padding: 2px;
   width: 14px;
   height: 14px;
+}
 /* avoid gaps between the navbar and browser */
 .navbar.mainmenu {
   border-top-left-radius: 0;
   border-top-right-radius: 0;
+}
 .navbar.footer {
   border-bottom-left-radius: 0;
   border-bottom-right-radius: 0;
+}
 @import "kallithea-diff.less";
 /* show some context of link targets - but only works when the link target
    can be extended with any visual difference */
 div.comment:target:before {
   display: block;
   height: 100px;
   margin: -100px 0 0;
   content: "";
+}
 div.comment:target > .panel {
   border: solid 2px #ee0 !important;
+}
 .lineno:target a {
   border: solid 2px #ee0 !important;
   margin: -2px;
+}
 .btn-image-diff-show,
 .btn-image-diff-swap {
   margin: 5px;
+}
 .img-diff {
   max-width: 45%;
   height: auto;
   margin: 5px;
   /* http://lea.verou.me/demos/css3-patterns.html */
   background-image: linear-gradient(45deg, #888 25%, transparent 25%, transparent), linear-gradient(-45deg, #888 25%, transparent 25%, transparent), linear-gradient(45deg, transparent 75%, #888 75%), linear-gradient(-45deg, transparent 75%, #888 75%);
   background-size: 10px 10px;
   background-color: #999;
+}
 .img-preview {
   max-width: 100%;
   height: auto;
   margin: 5px;
+}
 div.comment-prev-next-links div.prev-comment,
 div.comment-prev-next-links div.next-comment {
   display: inline-block;
   min-width: 150px;
   margin: 3px 6px;
+}
 #comments-general-comments div.comment-prev-next-links div.prev-comment,
 #comments-general-comments div.comment-prev-next-links div.next-comment {
   margin-left: 0;
+}
 body table.dataTable thead .sorting {
   background-image: none;
+}
 body table.dataTable thead .sorting_asc {
   background-image: none;
+}
 body table.dataTable thead .sorting_desc {
   background-image: none;
+}
 body table.dataTable thead .sorting_asc_disabled {
   background-image: none;
+}
 body table.dataTable thead .sorting_desc_disabled {
   background-image: none;
+}
 body table.dataTable thead .sorting_asc::after {
   font-family: "kallithea";
   content: "\23f6";
+}
 body table.dataTable thead .sorting_desc::after {
   font-family: "kallithea";
   content: "\23f7";
+}
 .dataTables_wrapper .dataTables_left {
   float: left !important;
+}
 .dataTables_wrapper .dataTables_right {
   float: right;
+}
 .dataTables_wrapper .dataTables_right > div {
   padding-left: 30px;

0 comments (0 inline, 0 general)