kallithea Changeset - 2a6c61a2e84e

Changeset - 2a6c61a2e84e

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 11 years ago 2015-01-06 00:54:36
madski@unity3d.com

pullrequests: show pending reviewer changes again - this time with "(not saved)"

b5795554c2ca lost some of the changes from 00c76c4e019c.

1 file changed with 2 insertions and 2 deletions:

kallithea/public/js/base.js

0 comments (0 inline, 0 general)

kallithea/public/js/base.js

➞

Show inline comments

@@ @@ -1468,13 +1468,13 @@ var addReviewMember = function(id,fname, @@
         '           </div>\n'+
         '         <div class="reviewer_gravatar gravatar"><img alt="gravatar" src="{0}"/> </div>\n'+
         '         <div style="float:left;">{1}</div>\n'+
         '         <input type="hidden" value="{2}" name="review_members" />\n'+
         '         <div class="reviewer_member_remove action_button" onclick="removeReviewMember({2})">\n'+
         '             <i class="icon-minus-circled" style="color: #FF4444;"></i>\n'+
         '         </div>\n'+
+        '         </div> (add not saved)\n'+
         '       </div>\n'+
         '     </li>\n'
         ).format(gravatar_link, displayname, id);
     // check if we don't have this ID already in
     var ids = [];
     $('#review_members').find('li').each(function() {
@@ @@ -1487,13 +1487,13 @@ var addReviewMember = function(id,fname, @@
+}
 var removeReviewMember = function(reviewer_id, repo_name, pull_request_id){
     var $li = $('#reviewer_{0}'.format(reviewer_id));
     $li.find('div div').css("text-decoration", "line-through");
     $li.find('input').remove();
-    $li.find('.reviewer_member_remove').remove();
+    $li.find('.reviewer_member_remove').replaceWith('&nbsp;(remove not saved)');
+}
 /* handle "Save Changes" of addReviewMember and removeReviewMember on PR */
 var updateReviewers = function(reviewers_ids, repo_name, pull_request_id){
     if (reviewers_ids === undefined){
         var reviewers_ids = [];

0 comments (0 inline, 0 general)