kallithea Changeset - 2ce0bc6e85f1

Changeset - 2ce0bc6e85f1

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 6 years ago 2019-08-04 18:35:21
mads@kiilerich.com

Grafted from: f31f91a755dd

cli: pass local argv to argparser instead of letting it use the global sys.argv

Fix pylint warning: "fix W0613(unused-argument) in argparser: Unused argument 'argv".

2 files changed with 2 insertions and 2 deletions:

kallithea/bin/kallithea_api.py

kallithea/bin/kallithea_gist.py

0 comments (0 inline, 0 general)

kallithea/bin/kallithea_api.py

➞

Show inline comments

@@ @@ -50,25 +50,25 @@ def argparser(argv): @@
     group.add_argument('--config', help='config file')
     group.add_argument('--save-config', action='store_true', help='save the given config into a file')
     group = parser.add_argument_group('API')
     group.add_argument('method', metavar='METHOD', nargs='?', type=str, default=None,
             help='API method name to call followed by key:value attributes',
+    )
     group.add_argument('--format', dest='format', type=str,
             help='output format default: `%s` can '
                  'be also `%s`' % (FORMAT_PRETTY, FORMAT_JSON),
             default=FORMAT_PRETTY
+    )
     args, other = parser.parse_known_args()
+    args, other = parser.parse_known_args(args=argv)
     return parser, args, other
 def main(argv=None):
     """
     Main execution function for cli
     :param argv:
     """
     if argv is None:
         argv = sys.argv

kallithea/bin/kallithea_gist.py

➞

Show inline comments

@@ @@ -59,25 +59,25 @@ def argparser(argv): @@
                        help='create private Gist')
     group.add_argument('-f', '--filename',
                        help='set uploaded gist filename, '
                             'also defines syntax highlighting')
     group.add_argument('-d', '--description', help='Gist description')
     group.add_argument('-l', '--lifetime', metavar='MINUTES',
                        help='gist lifetime in minutes, -1 (DEFAULT) is forever')
     group.add_argument('--format', dest='format', type=str,
                        help='output format DEFAULT: `%s` can '
                        'be also `%s`' % (FORMAT_PRETTY, FORMAT_JSON),
             default=FORMAT_PRETTY
+    )
     args, other = parser.parse_known_args()
+    args, other = parser.parse_known_args(args=argv)
     return parser, args, other
 def _run(argv):
     conf = None
     parser, args, other = argparser(argv)
     api_credentials_given = (args.apikey and args.apihost)
     if args.save_config:
         if not api_credentials_given:
             raise parser.error('--save-config requires --apikey and --apihost')
         conf = RcConf(config_location=args.config,

0 comments (0 inline, 0 general)