kallithea Changeset - 2f18ebfead0c

Changeset - 2f18ebfead0c

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 11 years ago 2014-09-24 14:24:40
madski@unity3d.com

vcs: close SubprocessIOChunker inputstream used for git (Issue #32)

git clone was leaking file descriptors

1 file changed with 5 insertions and 0 deletions:

kallithea/lib/vcs/subprocessio.py

0 comments (0 inline, 0 general)

kallithea/lib/vcs/subprocessio.py

➞

Show inline comments

@@ @@ -377,24 +377,25 @@ class SubprocessIOChunker(object): @@
             bg_out.stop()
             bg_err.stop()
             err = '%s' % ''.join(bg_err)
             if err:
                 raise EnvironmentError(
                     "Subprocess exited due to an error:\n" + err)
             raise EnvironmentError(
                 "Subprocess exited with non 0 ret code:%s" % _returncode)
         self.process = _p
         self.output = bg_out
         self.error = bg_err
         self.inputstream = inputstream
     def __iter__(self):
         return self
     def next(self):
         if self.process.poll():
             err = '%s' % ''.join(self.error)
             raise EnvironmentError("Subprocess exited due to an error:\n" + err)
         return self.output.next()
     def throw(self, type, value=None, traceback=None):
         if self.output.length or not self.output.done_reading:
@@ @@ -404,15 +405,19 @@ class SubprocessIOChunker(object): @@
         try:
             self.process.terminate()
         except:
             pass
         try:
             self.output.close()
         except:
             pass
         try:
             self.error.close()
         except:
             pass
         try:
             os.close(self.inputstream)
         except:
             pass
     def __del__(self):
         self.close()

0 comments (0 inline, 0 general)