kallithea Changeset - 2f9313074853

Changeset - 2f9313074853

Parent rev.

Child rev.

[Not reviewed]

default

0 6 0

Thomas De Schampheleire - 9 years ago 2017-03-15 21:00:40
thomas.de.schampheleire@gmail.com

controllers: remove empty __before__ methods

__before__ methods that only call the super __before__ method are redundant
and can be removed. The super's method will be called directly.

6 files changed with 0 insertions and 18 deletions:

kallithea/controllers/followers.py

kallithea/controllers/forks.py

kallithea/controllers/home.py

kallithea/controllers/login.py

kallithea/controllers/search.py

kallithea/controllers/summary.py

0 comments (0 inline, 0 general)

kallithea/controllers/followers.py

➞

Show inline comments

@@ @@ -37,15 +37,12 @@ from kallithea.model.db import UserFollo @@
 log = logging.getLogger(__name__)
 class FollowersController(BaseRepoController):
     def __before__(self):
         super(FollowersController, self).__before__()
     @LoginRequired()
     @HasRepoPermissionLevelDecorator('read')
     def followers(self, repo_name):
         p = safe_int(request.GET.get('page'), 1)
         repo_id = c.db_repo.repo_id
         d = UserFollowing.get_repo_followers(repo_id) \

kallithea/controllers/forks.py

➞

Show inline comments

@@ @@ -49,15 +49,12 @@ from kallithea.model.scm import ScmModel @@
 log = logging.getLogger(__name__)
 class ForksController(BaseRepoController):
     def __before__(self):
         super(ForksController, self).__before__()
     def __load_defaults(self):
         if HasPermissionAny('hg.create.write_on_repogroup.true')():
             repo_group_perm_level = 'write'
         else:
             repo_group_perm_level = 'admin'
         c.repo_groups = AvailableRepoGroupChoices(['hg.create.repository'], repo_group_perm_level)

kallithea/controllers/home.py

➞

Show inline comments

@@ @@ -42,15 +42,12 @@ from kallithea.model.repo import RepoMod @@
 log = logging.getLogger(__name__)
 class HomeController(BaseController):
     def __before__(self):
         super(HomeController, self).__before__()
     def about(self):
         return render('/about.html')
     @LoginRequired()
     def index(self):
         c.groups = self.scm_model.get_repo_groups()

kallithea/controllers/login.py

➞

Show inline comments

@@ @@ -50,15 +50,12 @@ from kallithea.model.meta import Session @@
 log = logging.getLogger(__name__)
 class LoginController(BaseController):
     def __before__(self):
         super(LoginController, self).__before__()
     def _validate_came_from(self, came_from,
             _re=re.compile(r"/(?!/)[-!#$%&'()*+,./:;=?@_~0-9A-Za-z]*$")):
         """Return True if came_from is valid and can and should be used.
         Determines if a URI reference is valid and relative to the origin;
         or in RFC 3986 terms, whether it matches this production:

kallithea/controllers/search.py

➞

Show inline comments

@@ @@ -46,15 +46,12 @@ from kallithea.model.repo import RepoMod @@
 log = logging.getLogger(__name__)
 class SearchController(BaseRepoController):
     def __before__(self):
         super(SearchController, self).__before__()
     @LoginRequired()
     def index(self, repo_name=None):
         c.repo_name = repo_name
         c.formated_results = []
         c.runtime = ''
         c.cur_query = request.GET.get('q', None)

kallithea/controllers/summary.py

➞

Show inline comments

@@ @@ -59,15 +59,12 @@ README_FILES = [''.join([x[0][0], x[1][0 @@
                     sorted(list(itertools.product(ALL_READMES, ALL_EXTS)),
                            key=lambda y:y[0][1] + y[1][1])]
 class SummaryController(BaseRepoController):
     def __before__(self):
         super(SummaryController, self).__before__()
     def __get_readme_data(self, db_repo):
         repo_name = db_repo.repo_name
         log.debug('Looking for README file')
         @cache_region('long_term', '_get_readme_from_cache')
         def _get_readme_from_cache(key, kind):

0 comments (0 inline, 0 general)