Changeset - 37ac2ac0a9ae
[Not reviewed]
default
0 1 0
Thomas De Schampheleire - 6 years ago 2019-10-27 21:01:52
thomas.de_schampheleire@nokia.com
scripts/validate-commits: use direct /bin/bash interpreter

Use of '#!/bin/bash' vs '#!/usr/bin/env bash' can be argued multiple ways.
For example, see:
https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash/21613039

It seems to be more common to use the first approach. And we don't have a
specific reason to prefer the latter. Moreover, other scripts in this repo,
like 'make-release' and 'whitespacecleanup.sh' use the former too.
1 file changed with 1 insertions and 1 deletions:
0 comments (0 inline, 0 general)
scripts/validate-commits
Show inline comments
 
#!/usr/bin/env bash
 
#!/bin/bash
 
# Validate the specified commits against test suite and other checks.
 

	
 
if [ -n "$VIRTUAL_ENV" ]; then
 
    echo "Please run this script from outside a virtualenv."
 
    exit 1
 
fi
0 comments (0 inline, 0 general)