kallithea Changeset - 395dfc93fe73

Changeset - 395dfc93fe73

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Aras Pranckevicius - 14 years ago 2012-01-09 21:52:13
aras@unity3d.com

changelog: simplify row expansion and fix for Firefox (parentElement->parentNode)

1 file changed with 4 insertions and 5 deletions:

rhodecode/templates/changelog/changelog.html

0 comments (0 inline, 0 general)

rhodecode/templates/changelog/changelog.html

➞

Show inline comments

@@ @@ -126,44 +126,43 @@ ${c.repo_name} ${_('Changelog')} - ${c.r @@
                         link = link.replace('__S',rev_start);
                         link = link.replace('__E',rev_end);
                         YUD.get('rev_range_container').innerHTML = link;
                         YUD.setStyle('rev_range_container','display','');
+                        }
                         else{
                         	YUD.setStyle('rev_range_container','display','none');
+                        }
                     });
                     var msgs = YUQ('.message');
-                    // get firts element height;
+                    // get first element height
                     var el = YUQ('.container')[0];
                     var row_h = el.clientHeight;
                     for(var i=0;i<msgs.length;i++){
                     	var m = msgs[i];
                     	var h = m.clientHeight;
                     	var pad = YUD.getStyle(m,'padding');
                     	if(h > row_h){
                     		YUD.setStyle(m.nextElementSibling,'display','block');
                     		YUD.setStyle(m.nextElementSibling,'margin-top',row_h-(h+14)+'px');
                     		YUD.setAttribute(m.nextElementSibling,'expand',h);
                     	};
+                    }
                     YUE.on(YUQ('.expand'),'click',function(e){
-                    	var elem = e.currentTarget.parentElement.parentElement;
+                    	var elem = e.currentTarget.parentNode.parentNode;
                     	YUD.setStyle(e.currentTarget,'display','none');
-                    	YUD.setStyle(elem,'height',YUD.getAttribute(e.currentTarget,'expand')+'px');
+                    	YUD.setStyle(elem,'height','auto');
                     	//redraw the graph max_w and jsdata are global vars
+                    	//redraw the graph, max_w and jsdata are global vars
                         set_canvas(max_w);
                         var r = new BranchRenderer();
                         r.render(jsdata,max_w);
                     })
                     // Fetch changeset details
                     YUE.on(YUD.getElementsByClassName('changed_total'),'click',function(e){
                     	var id = e.currentTarget.id
                     	var url = "${h.url('changelog_details',repo_name=c.repo_name,cs='__CS__')}"
                     	var url = url.replace('__CS__',id);

0 comments (0 inline, 0 general)