kallithea Changeset - 3bf8898ce66d

Changeset - 3bf8898ce66d

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 15 years ago 2011-02-11 11:32:10
marcin@python-works.com

removed immutable default argument from mailer

1 file changed with 4 insertions and 4 deletions:

rhodecode/lib/smtp_mailer.py

0 comments (0 inline, 0 general)

rhodecode/lib/smtp_mailer.py

➞

Show inline comments

@@ @@ -38,25 +38,25 @@ class SmtpMailer(object): @@
     def __init__(self, mail_from, user, passwd, mail_server,
                     mail_port=None, ssl=False, tls=False):
         self.mail_from = mail_from
         self.mail_server = mail_server
         self.mail_port = mail_port
         self.user = user
         self.passwd = passwd
         self.ssl = ssl
         self.tls = tls
         self.debug = False
-    def send(self, recipients=[], subject='', body='', attachment_files={}):
+    def send(self, recipients=[], subject='', body='', attachment_files=None):
         if isinstance(recipients, basestring):
             recipients = [recipients]
         if self.ssl:
             smtp_serv = smtplib.SMTP_SSL(self.mail_server, self.mail_port)
         else:
             smtp_serv = smtplib.SMTP(self.mail_server, self.mail_port)
         if self.tls:
             smtp_serv.ehlo()
             smtp_serv.starttls()
@@ @@ -121,23 +121,23 @@ class SmtpMailer(object): @@
                     # Encode the payload using Base64
                     encoders.encode_base64(msg)
                 # Set the filename parameter
                 file_part.add_header('Content-Disposition', 'attachment',
                                      filename=f_name)
                 file_part.add_header('Content-Type', ctype, name=f_name)
                 msg.attach(file_part)
         else:
             raise Exception('Attachment files should be'
                             'a dict in format {"filename":"filepath"}')
     def get_content(self, msg_file):
         '''
         Get content based on type, if content is a string do open first
         """Get content based on type, if content is a string do open first
         else just read because it's a probably open file object
         :param msg_file:
-        '''
+        """
         if isinstance(msg_file, str):
             return open(msg_file, "rb").read()
         else:
             #just for safe seek to 0
             msg_file.seek(0)
             return msg_file.read()

0 comments (0 inline, 0 general)