kallithea Changeset - 3bfd5852c218

Changeset - 3bfd5852c218

Parent rev.

Child rev.

[Not reviewed]

beta

0 4 0

Marcin Kuzminski - 13 years ago 2012-11-14 21:44:47
marcin@python-works.com

implements #649 added two seperate method for author and commiter to VCS changeset class
- switch author for git backed to be the real author not commiter

4 files changed with 36 insertions and 1 deletions:

rhodecode/lib/vcs/backends/base.py

rhodecode/lib/vcs/backends/git/changeset.py

rhodecode/lib/vcs/backends/hg/changeset.py

rhodecode/lib/vcs/nodes.py

0 comments (0 inline, 0 general)

rhodecode/lib/vcs/backends/base.py

➞

Show inline comments

@@ @@ -429,12 +429,36 @@ class BaseChangeset(object): @@
         Returns integer identifying this changeset.
         """
         raise NotImplementedError
     @LazyProperty
     def commiter(self):
         """
         Returns Commiter for given commit
         """
         raise NotImplementedError
     @LazyProperty
     def commiter_name(self):
         """
         Returns Author name for given commit
         """
         return author_name(self.commiter)
     @LazyProperty
     def commiter_email(self):
         """
         Returns Author email address for given commit
         """
         return author_email(self.commiter)
     @LazyProperty
     def author(self):
         """
         Returns Author for given commit
         """
         raise NotImplementedError

rhodecode/lib/vcs/backends/git/changeset.py

➞

Show inline comments

@@ @@ -38,24 +38,29 @@ class GitChangeset(BaseChangeset): @@
         self.id = self.raw_id
         self.short_id = self.raw_id[:12]
         self._commit = commit
         self._tree_id = commit.tree
         self._commiter_property = 'committer'
         self._author_property = 'author'
         self._date_property = 'commit_time'
         self._date_tz_property = 'commit_timezone'
         self.revision = repository.revisions.index(revision)
         self.message = safe_unicode(commit.message)
         self.nodes = {}
         self._paths = {}
     @LazyProperty
     def commiter(self):
         return safe_unicode(getattr(self._commit, self._commiter_property))
     @LazyProperty
     def author(self):
-        return safe_unicode(getattr(self._commit, self._commiter_property))
+        return safe_unicode(getattr(self._commit, self._author_property))
     @LazyProperty
     def date(self):
         return date_fromtimestamp(getattr(self._commit, self._date_property),
                                   getattr(self._commit, self._date_tz_property))

rhodecode/lib/vcs/backends/hg/changeset.py

➞

Show inline comments

@@ @@ -41,12 +41,16 @@ class MercurialChangeset(BaseChangeset): @@
     @LazyProperty
     def message(self):
         return safe_unicode(self._ctx.description())
     @LazyProperty
     def commiter(self):
         return safe_unicode(self.auhtor)
     @LazyProperty
     def author(self):
         return safe_unicode(self._ctx.user())
     @LazyProperty
     def date(self):
         return date_fromtimestamp(*self._ctx.date())

rhodecode/lib/vcs/nodes.py

➞

Show inline comments

@@ @@ -350,12 +350,13 @@ class FileNode(Node): @@
         full set of (type,encoding)
         """
         return self.get_mimetype()[0]
     @LazyProperty
     def mimetype_main(self):
         return ['', '']
         return self.mimetype.split('/')[0]
     @LazyProperty
     def lexer(self):
         """
         Returns pygment's lexer class. Would try to guess lexer taking file's
@@ @@ -407,12 +408,13 @@ class FileNode(Node): @@
     @property
     def is_binary(self):
         """
         Returns True if file has binary content.
         """
         return False
         _bin = '\0' in self._get_content()
         return _bin
     @LazyProperty
     def extension(self):
         """Returns filenode extension"""

0 comments (0 inline, 0 general)