kallithea Changeset - 3f017db297c4

Changeset - 3f017db297c4

Parent rev.

Child rev.

[Not reviewed]

default

0 7 0

Mads Kiilerich - 10 years ago 2015-08-26 17:28:59
madski@unity3d.com

javascript: use jQuery .prop instead of .attr for standard properties

7 files changed with 16 insertions and 16 deletions:

kallithea/public/js/base.js

kallithea/templates/admin/gists/edit.html

kallithea/templates/admin/gists/new.html

kallithea/templates/changeset/diff_block.html

kallithea/templates/files/files_add.html

kallithea/templates/files/files_edit.html

kallithea/templates/pullrequests/pullrequest.html

0 comments (0 inline, 0 general)

kallithea/public/js/base.js

➞

Show inline comments

@@ @@ -521,13 +521,13 @@ var _show_tooltip = function(e, tipText, @@
+    }
     if(tipText !== ''){
         // save org title
         $el.attr('tt_title', tipText);
         // reset title to not show org tooltips
-        $el.attr('title', '');
+        $el.prop('title', '');
         var $tipBox = $('#tip-box');
         if (safe) {
             $tipBox.html(tipText);
         } else {
             $tipBox.text(tipText);
@@ @@ -545,13 +545,13 @@ var _move_tooltip = function(e){ @@
 var _close_tooltip = function(e){
     e.stopImmediatePropagation();
     var $tipBox = $('#tip-box');
     $tipBox.hide();
     var el = e.currentTarget;
-    $(el).attr('title', $(el).attr('tt_title'));
+    $(el).prop('title', $(el).attr('tt_title'));
 };
 /**
  * Quick filter widget
+ *
  * @param target: filter input target
@@ @@ -764,27 +764,27 @@ function deleteComment(comment_id) { @@
 /**
  * Double link comments
  */
 var linkInlineComments = function($firstlinks, $comments){
     if ($comments.length > 0) {
-        $firstlinks.html('<a href="#{0}">First comment</a>'.format($comments.attr('id')));
+        $firstlinks.html('<a href="#{0}">First comment</a>'.format($comments.prop('id')));
+    }
     if ($comments.length <= 1) {
         return;
+    }
     $comments.each(function(i, e){
             var prev = '';
             if (i > 0){
-                var prev_anchor = $($comments.get(i-1)).attr('id');
+                var prev_anchor = $($comments.get(i-1)).prop('id');
                 prev = '<a href="#{0}">Previous comment</a>'.format(prev_anchor);
+            }
             var next = '';
             if (i+1 < $comments.length){
-                var next_anchor = $($comments.get(i+1)).attr('id');
+                var next_anchor = $($comments.get(i+1)).prop('id');
                 next = '<a href="#{0}">Next comment</a>'.format(next_anchor);
+            }
             $(this).find('.comment-prev-next-links').html(
                 '<div class="prev-comment">{0}</div>'.format(prev) +
                 '<div class="next-comment">{0}</div>'.format(next));
         });
@@ @@ -973,13 +973,13 @@ var getSelectionLink = function(e) { @@
                 $hl_div.html('');
             } else {
                 $hl_div = $('<div id="linktt" class="hl-tip-box">');
                 $('body').prepend($hl_div);
+            }
-            $hl_div.append($('<a>').html(_TM['Selection link']).attr('href', location.href.substring(0, location.href.indexOf('#')) + '#L' + ranges[0] + '-'+ranges[1]));
+            $hl_div.append($('<a>').html(_TM['Selection link']).prop('href', location.href.substring(0, location.href.indexOf('#')) + '#L' + ranges[0] + '-'+ranges[1]));
             var xy = $(till).offset();
             $hl_div.css('top', (xy.top + yoffset) + 'px').css('left', xy.left + 'px');
             $hl_div.show();
+        }
         else{
             $hl_div.hide();
@@ @@ -1181,13 +1181,13 @@ var MembersAutoComplete = function ($inp @@
     };
     var membersAC = autocompleteCreate($inputElement, $container, matchAll);
     // Handler for selection of an entry
     var itemSelectHandler = function (sType, aArgs) {
-        var nextId = $inputElement.attr('id').split('perm_new_member_name_')[1];
+        var nextId = $inputElement.prop('id').split('perm_new_member_name_')[1];
         var myAC = aArgs[0]; // reference back to the AC instance
         var elLI = aArgs[1]; // reference to the selected LI element
         var oData = aArgs[2]; // object literal of selected item's result data
         //fill the autocomplete with value
         if (oData.nname != undefined) {
             //users
@@ @@ -1324,13 +1324,13 @@ var addReviewMember = function(id,fname, @@
+    }
+}
 var removeReviewMember = function(reviewer_id, repo_name, pull_request_id){
     var $li = $('#reviewer_{0}'.format(reviewer_id));
     $li.find('div div').css("text-decoration", "line-through");
-    $li.find('input').attr('name', 'review_members_removed');
+    $li.find('input').prop('name', 'review_members_removed');
     $li.find('.reviewer_member_remove').replaceWith('&nbsp;(remove not saved)');
+}
 /* activate auto completion of users as PR reviewers */
 var PullRequestAutoComplete = function ($inputElement, $container, users_list) {
@@ @@ -1883,13 +1883,13 @@ var branchSort = function(results, conta @@
 // global hooks after DOM is loaded
 $(document).ready(function(){
     $('.diff-collapse-button').click(function(e) {
         var $button = $(e.currentTarget);
-        var $target = $('#' + $button.attr('target'));
+        var $target = $('#' + $button.prop('target'));
         if($target.hasClass('hidden')){
             $target.removeClass('hidden');
             $button.html("&uarr; {0} &uarr;".format(_TM['Collapse Diff']));
+        }
         else if(!$target.hasClass('hidden')){
             $target.addClass('hidden');

kallithea/templates/admin/gists/edit.html

➞

Show inline comments

@@ @@ -91,13 +91,13 @@ @@
                     for(var i=0;i<CodeMirror.modeInfo.length;i++) {
                         var m = CodeMirror.modeInfo[i];
                         var opt = new Option(m.name, m.mime);
                         $(opt).attr('mode', m.mode);
                         if (m.mime == 'text/plain') {
                             // default plain text
-                            $(opt).attr('selected', 'selected');
+                            $(opt).prop('selected', true);
                             modes_select.options[0] = opt;
                         } else {
                             modes_select.options[index++] = opt;
+                        }
+                    }
                 });

kallithea/templates/admin/gists/new.html

➞

Show inline comments

@@ @@ -69,13 +69,13 @@ @@
                 for(var i=0;i<CodeMirror.modeInfo.length;i++) {
                     var m = CodeMirror.modeInfo[i];
                     var opt = new Option(m.name, m.mime);
                     $(opt).attr('mode', m.mode);
                     if (m.mime == 'text/plain') {
                         // default plain text
-                        $(opt).attr('selected', 'selected');
+                        $(opt).prop('selected', true);
                         modes_select.options[0] = opt;
                     } else {
                         modes_select.options[index++] = opt;
+                    }
+                }
             });

kallithea/templates/changeset/diff_block.html

➞

Show inline comments

@@ @@ -131,13 +131,13 @@ @@
 $(document).ready(function(){
     $('.btn-image-diff-show').click(function(e){
         $('.btn-image-diff-show').hide();
         $('.btn-image-diff-swap').show();
         $('.img-diff-swapable')
             .each(function(i,e){
-                    $(e).attr('src', $(e).attr('realsrc'));
+                    $(e).prop('src', $(e).attr('realsrc'));
                 })
             .show();
         });
     $('.btn-image-diff-swap').mousedown(function(e){
         $('#'+e.currentTarget.id+'-img-a.img-diff-swapable')

kallithea/templates/files/files_add.html

➞

Show inline comments

@@ @@ -76,13 +76,13 @@ ${self.repo_context_bar('files')} @@
                 for(var i=0;i<CodeMirror.modeInfo.length;i++){
                     var m = CodeMirror.modeInfo[i];
                     var opt = new Option(m.name, m.mime);
                     $(opt).attr('mode', m.mode);
                     if (m.mime == 'text/plain') {
                         // default plain text
-                        $(opt).attr('selected', 'selected');
+                        $(opt).prop('selected', true);
                         modes_select.options[0] = opt;
                     } else {
                         modes_select.options[index++] = opt;
+                    }
+                }
             });

kallithea/templates/files/files_edit.html

➞

Show inline comments

@@ @@ -84,24 +84,24 @@ $(document).ready(function(){ @@
         for(var i=0;i<CodeMirror.modeInfo.length;i++){
             var m = CodeMirror.modeInfo[i];
             var opt = new Option(m.name, m.mime);
             $(opt).attr('mode', m.mode);
             if (m.mime == 'text/plain') {
                 // default plain text
-                $(opt).attr('selected', 'selected');
+                $(opt).prop('selected', true);
                 modes_select.options[0] = opt;
             } else {
                 modes_select.options[index++] = opt;
+            }
+        }
     });
     // try to detect the mode based on the file we edit
     var detected_mode = CodeMirror.findModeByExtension("${c.file.extension}");
     if(detected_mode){
         setCodeMirrorMode(myCodeMirror, detected_mode);
-        $($('#set_mode option[value="'+detected_mode.mime+'"]')[0]).attr("selected", "selected");
+        $($('#set_mode option[value="'+detected_mode.mime+'"]')[0]).prop('selected', true);
+    }
     $('#set_mode').on('change', function(e){
         var selected = e.currentTarget;
         var node = selected.options[selected.selectedIndex];
         var detected_mode = CodeMirror.findModeByMIME(node.value);

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -126,13 +126,13 @@ ${self.repo_context_bar('showpullrequest @@
               $('#other_repo_desc').html(data.description);
               // replace options of other_ref with the ones for the current other_repo
               $other_ref.empty();
               for(var i = 0; i < data.refs.length; i++)
+              {
-                var $optgroup = $('<optgroup/>').attr('label', data.refs[i][1]);
+                var $optgroup = $('<optgroup/>').prop('label', data.refs[i][1]);
                 var options = data.refs[i][0];
                 var length = options.length;
                 for(var j = 0; j < length; j++)
+                {
                   $optgroup.append($('<option/>').text(options[j][1]).val(options[j][0]));
+                }

0 comments (0 inline, 0 general)