Changeset - 4086efa27652
Parent rev.
Child rev.
[Not reviewed]
default
0 2 0
Thomas De Schampheleire - 8 years ago 2018-02-07 09:24:14
thomas.de_schampheleire@nokia.com
tests: notification: clarify that cs_target_repo is a URL

In analogy with the fake URLs used for pullrequest notification testing, use
an URL for cs_target_repo. When testing the resulting HTML in a real email
client, it will become obvious that the mail client transforms URLs to
something clickable, regardless of any present <a> tag.
2 files changed with 9 insertions and 9 deletions:
kallithea/tests/models/test_dump_html_mails.ref.html
8
8
kallithea/tests/models/test_notifications.py
1
1
0 comments (0 inline, 0 general)
kallithea/tests/models/test_dump_html_mails.ref.html
➞
Show inline comments
 
@@ -13,25 +13,25 @@ Subject: [Comment] repo/name changeset c
 
<pre>http://comment.org
 

			




	
	
	
		
 
Comment on Changeset "This changeset did something clever which is hard to explain"

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Opinionated User (jsmith):

			




	
	
	
		
 

			




	
	
	
		
 
This is the new comment.

			




	
	
	
		
 

			




	
	
	
		
 
 - and here it ends indented.

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Changeset on repo_target branch brunch:

			




	
	
	
		
 
Changeset on http://example.com/repo_target branch brunch:

			




	
	
	
		
 
"This changeset did something clever which is hard to explain" by u2 u3 (u2).

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
View Comment: http://comment.org

			




	
	
	
		
 
</pre>

			




	
	
	
		
 
<hr/>

			




	
	
	
		
 
<!--!doctype html-->

			




	
	
	
		
 
<!--html lang="en"-->

			




	
	
	
		
 
<!--head-->

			




	
	
	
		
 
    <!--title--><!--/title-->

			




	
	
	
		
 
    <!--meta name="viewport" content="width=device-width"-->

			




	
	
	
		
 
    <!--meta http-equiv="Content-Type" content="text/html; charset=UTF-8"-->

			




	
	
		
 
@@ -103,25 +103,25 @@ View Comment: http://comment.org

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
</table>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td height="30px" style="height:30px"></td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Changeset on

			




	
	
	
		
 
                <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="repo_target">repo_target</a>

			




	
	
	
		
 
                   href="http://example.com/repo_target">http://example.com/repo_target</a>

			




	
	
	
		
 
                branch

			




	
	
	
		
 
                <span style="color:#395fa0">brunch</span>:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                "<a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="http://changeset.com">This changeset did something clever which is hard to explain</a>"

			




	
	
	
		
 
                by

			




	
	
	
		
 
                <span style="color:#395fa0">u2 u3 (u2)</span>.

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
		
 
@@ -172,25 +172,25 @@ Subject: [Comment] repo/name changeset c

			




	
	
	
		
 
<pre>http://comment.org

			




	
	
	
		
 

			




	
	
	
		
 
Mention in Comment on Changeset "This changeset did something clever which is hard to explain"

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Opinionated User (jsmith):

			




	
	
	
		
 

			




	
	
	
		
 
This is the new comment.

			




	
	
	
		
 

			




	
	
	
		
 
 - and here it ends indented.

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Changeset on repo_target branch brunch:

			




	
	
	
		
 
Changeset on http://example.com/repo_target branch brunch:

			




	
	
	
		
 
"This changeset did something clever which is hard to explain" by u2 u3 (u2).

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
View Comment: http://comment.org

			




	
	
	
		
 
</pre>

			




	
	
	
		
 
<hr/>

			




	
	
	
		
 
<!--!doctype html-->

			




	
	
	
		
 
<!--html lang="en"-->

			




	
	
	
		
 
<!--head-->

			




	
	
	
		
 
    <!--title--><!--/title-->

			




	
	
	
		
 
    <!--meta name="viewport" content="width=device-width"-->

			




	
	
	
		
 
    <!--meta http-equiv="Content-Type" content="text/html; charset=UTF-8"-->

			




	
	
		
 
@@ -262,25 +262,25 @@ View Comment: http://comment.org

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
</table>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td height="30px" style="height:30px"></td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Changeset on

			




	
	
	
		
 
                <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="repo_target">repo_target</a>

			




	
	
	
		
 
                   href="http://example.com/repo_target">http://example.com/repo_target</a>

			




	
	
	
		
 
                branch

			




	
	
	
		
 
                <span style="color:#395fa0">brunch</span>:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                "<a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="http://changeset.com">This changeset did something clever which is hard to explain</a>"

			




	
	
	
		
 
                by

			




	
	
	
		
 
                <span style="color:#395fa0">u2 u3 (u2)</span>.

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
		
 
@@ -333,25 +333,25 @@ Subject: [Approved: Comment] repo/name c

			




	
	
	
		
 
Comment on Changeset "This changeset did something clever which is hard to explain"

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Opinionated User (jsmith):

			




	
	
	
		
 

			




	
	
	
		
 
Status change: Approved

			




	
	
	
		
 

			




	
	
	
		
 
This is the new comment.

			




	
	
	
		
 

			




	
	
	
		
 
 - and here it ends indented.

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Changeset on repo_target branch brunch:

			




	
	
	
		
 
Changeset on http://example.com/repo_target branch brunch:

			




	
	
	
		
 
"This changeset did something clever which is hard to explain" by u2 u3 (u2).

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
View Comment: http://comment.org

			




	
	
	
		
 
</pre>

			




	
	
	
		
 
<hr/>

			




	
	
	
		
 
<!--!doctype html-->

			




	
	
	
		
 
<!--html lang="en"-->

			




	
	
	
		
 
<!--head-->

			




	
	
	
		
 
    <!--title--><!--/title-->

			




	
	
	
		
 
    <!--meta name="viewport" content="width=device-width"-->

			




	
	
	
		
 
    <!--meta http-equiv="Content-Type" content="text/html; charset=UTF-8"-->

			




	
	
		
 
@@ -439,25 +439,25 @@ View Comment: http://comment.org

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
</table>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td height="30px" style="height:30px"></td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Changeset on

			




	
	
	
		
 
                <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="repo_target">repo_target</a>

			




	
	
	
		
 
                   href="http://example.com/repo_target">http://example.com/repo_target</a>

			




	
	
	
		
 
                branch

			




	
	
	
		
 
                <span style="color:#395fa0">brunch</span>:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                "<a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="http://changeset.com">This changeset did something clever which is hard to explain</a>"

			




	
	
	
		
 
                by

			




	
	
	
		
 
                <span style="color:#395fa0">u2 u3 (u2)</span>.

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
		
 
@@ -510,25 +510,25 @@ Subject: [Approved: Comment] repo/name c

			




	
	
	
		
 
Mention in Comment on Changeset "This changeset did something clever which is hard to explain"

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Opinionated User (jsmith):

			




	
	
	
		
 

			




	
	
	
		
 
Status change: Approved

			




	
	
	
		
 

			




	
	
	
		
 
This is the new comment.

			




	
	
	
		
 

			




	
	
	
		
 
 - and here it ends indented.

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
Changeset on repo_target branch brunch:

			




	
	
	
		
 
Changeset on http://example.com/repo_target branch brunch:

			




	
	
	
		
 
"This changeset did something clever which is hard to explain" by u2 u3 (u2).

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
View Comment: http://comment.org

			




	
	
	
		
 
</pre>

			




	
	
	
		
 
<hr/>

			




	
	
	
		
 
<!--!doctype html-->

			




	
	
	
		
 
<!--html lang="en"-->

			




	
	
	
		
 
<!--head-->

			




	
	
	
		
 
    <!--title--><!--/title-->

			




	
	
	
		
 
    <!--meta name="viewport" content="width=device-width"-->

			




	
	
	
		
 
    <!--meta http-equiv="Content-Type" content="text/html; charset=UTF-8"-->

			




	
	
		
 
@@ -616,25 +616,25 @@ View Comment: http://comment.org

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
</table>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td height="30px" style="height:30px"></td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




	
	
	
		
 
        <td>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                Changeset on

			




	
	
	
		
 
                <a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="repo_target">repo_target</a>

			




	
	
	
		
 
                   href="http://example.com/repo_target">http://example.com/repo_target</a>

			




	
	
	
		
 
                branch

			




	
	
	
		
 
                <span style="color:#395fa0">brunch</span>:

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
            <div>

			




	
	
	
		
 
                "<a style="color:#395fa0;text-decoration:none"

			




	
	
	
		
 
                   href="http://changeset.com">This changeset did something clever which is hard to explain</a>"

			




	
	
	
		
 
                by

			




	
	
	
		
 
                <span style="color:#395fa0">u2 u3 (u2)</span>.

			




	
	
	
		
 
            </div>

			




	
	
	
		
 
        </td>

			




	
	
	
		
 
    </tr>

			




	
	
	
		
 
    <tr>

			




        

    


    
    

    

        

                

                    kallithea/tests/models/test_notifications.py
                

                

                  
                      
                        

                      ➞

                      
                        
                  

                  
                      
                  
                      
                  
                      
                  
                      
                  
                  
                

                

                    Show inline comments
                    
                

        

        

            



	
	
		
 
@@ -211,25 +211,25 @@ class TestNotifications(TestController):

			




	
	
	
		
 
                    (Notification.TYPE_CHANGESET_COMMENT,

			




	
	
	
		
 
                     u'This is the new comment.\n\n - and here it ends indented.',

			




	
	
	
		
 
                     dict(

			




	
	
	
		
 
                        short_id='cafe1234',

			




	
	
	
		
 
                        raw_id='cafe1234c0ffeecafe',

			




	
	
	
		
 
                        branch='brunch',

			




	
	
	
		
 
                        cs_comment_user='Opinionated User (jsmith)',

			




	
	
	
		
 
                        cs_comment_url='http://comment.org',

			




	
	
	
		
 
                        is_mention=[False, True],

			




	
	
	
		
 
                        message='This changeset did something clever which is hard to explain',

			




	
	
	
		
 
                        message_short='This changeset did something cl...',

			




	
	
	
		
 
                        status_change=[None, 'Approved'],

			




	
	
	
		
 
                        cs_target_repo='repo_target',

			




	
	
	
		
 
                        cs_target_repo='http://example.com/repo_target',

			




	
	
	
		
 
                        cs_url='http://changeset.com',

			




	
	
	
		
 
                        cs_author=User.get(self.u2))),

			




	
	
	
		
 
                    (Notification.TYPE_MESSAGE,

			




	
	
	
		
 
                     u'This is the body of the test message\n - nothing interesting here except indentation.',

			




	
	
	
		
 
                     dict()),

			




	
	
	
		
 
                    #(Notification.TYPE_MENTION, '$body', None), # not used

			




	
	
	
		
 
                    (Notification.TYPE_REGISTRATION,

			




	
	
	
		
 
                     u'Registration body',

			




	
	
	
		
 
                     dict(

			




	
	
	
		
 
                        new_username='newbie',

			




	
	
	
		
 
                        registered_user_url='http://newbie.org',

			




	
	
	
		
 
                        new_email='new@email.com',

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.0,
        which is
        © 2010–2025 by various authors & licensed under GPLv3.