kallithea Changeset - 423a14349ef3

Changeset - 423a14349ef3

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 13 years ago 2012-09-03 17:33:21
marcin@python-works.com

Don't use .innerHTML for tr field, I'm looking at you IE

1 file changed with 11 insertions and 10 deletions:

rhodecode/public/js/rhodecode.js

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -372,18 +372,19 @@ var q_filter = function(target,nodes,dis @@
+	}
 };
 var tableTr = function(cls,body){
 	var tr = document.createElement('tr');
 	YUD.addClass(tr, cls);
 var tableTr = function(cls, body){
 	var _el = document.createElement('table');
 	var cont = new YAHOO.util.Element(body);
 	var comment_id = fromHTML(body).children[0].id.split('comment-')[1];
 	tr.id = 'comment-tr-{0}'.format(comment_id);
 	tr.innerHTML = '<td class="lineno-inline new-inline"></td>'+
     				 '<td class="lineno-inline old-inline"></td>'+
                      '<td>{0}</td>'.format(body);
 	return tr;
 	var id = 'comment-tr-{0}'.format(comment_id);
 	var _html = ('tbody><tr id="{0}" class="{1}">'+
 	              '<td class="lineno-inline new-inline"></td>'+
     			  '<td class="lineno-inline old-inline"></td>'+
                   '<td>{2}</td>'+
                  '</tr>').format(id, cls, body);
 	_el.innerHTML = _html;
 	return _el.children[0].children[0];
 };
 /** comments **/
@@ @@ -395,7 +396,7 @@ var createInlineForm = function(parent_t @@
 	var tmpl = YUD.get('comment-inline-form-template').innerHTML;
 	tmpl = tmpl.format(f_path, line);
 	var form = tableTr('comment-form-inline',tmpl)
 	// create event for hide button
 	form = new YAHOO.util.Element(form);
 	var form_hide_button = new YAHOO.util.Element(YUD.getElementsByClassName('hide-inline-form',null,form)[0]);

0 comments (0 inline, 0 general)