kallithea Changeset - 423a14349ef3

Changeset - 423a14349ef3

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 13 years ago 2012-09-03 17:33:21
marcin@python-works.com

Don't use .innerHTML for tr field, I'm looking at you IE

1 file changed with 8 insertions and 7 deletions:

rhodecode/public/js/rhodecode.js

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -352,59 +352,60 @@ var q_filter = function(target,nodes,dis @@
 	   var showing = 0;
        for (i=0;i<l;i++ ){
     	   var n = nodes[i];
     	   var target_element = display_element(n)
     	   if(req && n.innerHTML.toLowerCase().indexOf(req) == -1){
     		   hide_node(target_element);
+    	   }
     	   else{
     		   show_node(target_element);
     		   showing+=1;
+    	   }
+       }
 	   // if repo_count is set update the number
 	   var cnt = YUD.get('repo_count');
 	   if(cnt){
 		   YUD.get('repo_count').innerHTML = showing;
+	   }
+	}
 };
 var tableTr = function(cls,body){
 	var tr = document.createElement('tr');
 	YUD.addClass(tr, cls);
 	var _el = document.createElement('table');
 	var cont = new YAHOO.util.Element(body);
 	var comment_id = fromHTML(body).children[0].id.split('comment-')[1];
 	tr.id = 'comment-tr-{0}'.format(comment_id);
 	tr.innerHTML = '<td class="lineno-inline new-inline"></td>'+
 	var id = 'comment-tr-{0}'.format(comment_id);
 	var _html = ('tbody><tr id="{0}" class="{1}">'+
 	              '<td class="lineno-inline new-inline"></td>'+
     				 '<td class="lineno-inline old-inline"></td>'+
                      '<td>{0}</td>'.format(body);
 	return tr;
                   '<td>{2}</td>'+
                  '</tr>').format(id, cls, body);
 	_el.innerHTML = _html;
 	return _el.children[0].children[0];
 };
 /** comments **/
 var removeInlineForm = function(form) {
 	form.parentNode.removeChild(form);
 };
 var createInlineForm = function(parent_tr, f_path, line) {
 	var tmpl = YUD.get('comment-inline-form-template').innerHTML;
 	tmpl = tmpl.format(f_path, line);
 	var form = tableTr('comment-form-inline',tmpl)
 	// create event for hide button
 	form = new YAHOO.util.Element(form);
 	var form_hide_button = new YAHOO.util.Element(YUD.getElementsByClassName('hide-inline-form',null,form)[0]);
 	form_hide_button.on('click', function(e) {
 		var newtr = e.currentTarget.parentNode.parentNode.parentNode.parentNode.parentNode;
 		if(YUD.hasClass(newtr.nextElementSibling,'inline-comments-button')){
 			YUD.setStyle(newtr.nextElementSibling,'display','');
+		}
 		removeInlineForm(newtr);
 		YUD.removeClass(parent_tr, 'form-open');
 	});

0 comments (0 inline, 0 general)