kallithea Changeset - 42bbccdec0a0

Changeset - 42bbccdec0a0

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

domruf - 9 years ago 2017-04-04 15:22:48
dominikruf@gmail.com

auth: catch all exceptions while loading auth plugin - not just ImportError

A third party plugin could raise any kind of exception, so we should be
prepared for that.

1 file changed with 1 insertions and 1 deletions:

kallithea/lib/auth_modules/__init__.py

0 comments (0 inline, 0 general)

kallithea/lib/auth_modules/__init__.py

➞

Show inline comments

@@ @@ -344,7 +344,7 @@ def get_auth_plugins(): @@
     for plugin_name in Setting.get_by_name("auth_plugins").app_settings_value:
         try:
             plugin = loadplugin(plugin_name)
-        except ImportError as e:
+        except Exception:
             log.exception('Failed to load authentication module %s' % (plugin_name))
         else:
             auth_plugins.append(plugin)

0 comments (0 inline, 0 general)