kallithea Changeset - 42ce8e54bae5

Changeset - 42ce8e54bae5

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Søren Løvborg - 10 years ago 2015-08-13 21:52:18
sorenl@unity3d.com

pullrequests: remove reviewer list during PR creation

There is not much use for it before the actual diff is shown ... and removing
it also removes a bit of duplicated code that otherwise should be maintained in
two places.

2 files changed with 0 insertions and 29 deletions:

kallithea/controllers/pullrequests.py

kallithea/templates/pullrequests/pullrequest.html

0 comments (0 inline, 0 general)

kallithea/controllers/pullrequests.py

➞

Show inline comments

@@ @@ -67,12 +67,6 @@ log = logging.getLogger(__name__) @@
 class PullrequestsController(BaseRepoController):
     def __before__(self):
         super(PullrequestsController, self).__before__()
         repo_model = RepoModel()
         c.users_array = repo_model.get_users_js()
         c.user_groups_array = repo_model.get_user_groups_js()
     def _get_repo_refs(self, repo, rev=None, branch=None, branch_rev=None):
         """return a structure with repo's interesting changesets, suitable for
         the selectors in pullrequest.html

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -92,25 +92,6 @@ ${self.repo_context_bar('showpullrequest @@
         </div>
         ## Reviewers
         <div style="float:left; border-left:1px dashed #eee">
             <div class="pr-details-title">${_('Pull Request Reviewers')}</div>
             <div id="reviewers" style="padding:0px 0px 0px 15px">
               ## members goes here !
               <div>
                 <ul id="review_members" class="group_members">
                 </ul>
               </div>
               <div class='ac'>
                 <div class="reviewer_ac">
                    ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
                    <div id="reviewers_container"></div>
                 </div>
               </div>
             </div>
         </div>
         <div style="clear:both;padding: 0 0 30px 0;"></div>
         <h4>${_('Changesets')}</h4>
@@ @@ -128,10 +109,6 @@ ${self.repo_context_bar('showpullrequest @@
 <script type="text/javascript" src="${h.url('/js/graph.js', ver=c.kallithea_version)}"></script>
 <script type="text/javascript">
   var _USERS_AC_DATA = ${c.users_array|n};
   var _GROUPS_AC_DATA = ${c.user_groups_array|n};
   PullRequestAutoComplete($('#user'), $('#reviewers_container'), _USERS_AC_DATA);
   pyroutes.register('pullrequest_repo_info', "${url('pullrequest_repo_info',repo_name='%(repo_name)s')}", ['repo_name']);
   var pendingajax = undefined;

0 comments (0 inline, 0 general)