kallithea Changeset - 43c9da9eed11

Changeset - 43c9da9eed11

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

domruf - 8 years ago 2018-02-21 18:25:19
dominikruf@gmail.com

Grafted from: 3008c3a1ab0b

git: open submodule links in a new tab

Since you are leaving the project context (maybe even kallithea), sub module
links should open in a new tab.

2 files changed with 2 insertions and 2 deletions:

kallithea/templates/files/files_browser.html

kallithea/tests/other/test_vcs_operations.py

0 comments (0 inline, 0 general)

kallithea/templates/files/files_browser.html

➞

Show inline comments

@@ @@ -72,7 +72,7 @@ @@
             %for cnt,node in enumerate(c.file):
                 <tr class="parity${cnt%2}">
                      <td>
                          ${h.link_to(file_name(node),file_url(node,c),class_=file_class(node)+(" ypjax-link" if not node.is_submodule() else ""))}
+                         ${h.link_to(file_name(node),file_url(node,c),class_=file_class(node)+(" ypjax-link" if not node.is_submodule() else ""), target_="_blank" if node.is_submodule() else None)}
                      </td>
                      <td>
                      %if node.is_file():

kallithea/tests/other/test_vcs_operations.py

➞

Show inline comments

@@ @@ -688,7 +688,7 @@ class TestVCSOperations(TestController): @@
                                     repo_name=fork_name,
                                     revision='tip',
                                     f_path='/'))
         response.mustcontain('<a class="submodule-dir" href="%s"><i class="icon-file-submodule"></i><span>testsubmodule @ ' % clone_url)
+        response.mustcontain('<a class="submodule-dir" href="%s" target="_blank"><i class="icon-file-submodule"></i><span>testsubmodule @ ' % clone_url)
         # check that following a submodule link actually works - and redirects
         response = self.app.get(url(controller='files', action='index',

0 comments (0 inline, 0 general)