kallithea Changeset - 44ae84b422ad

Changeset - 44ae84b422ad

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 11 years ago 2014-08-12 13:08:23
madski@unity3d.com

pull requests: update select2 for target ref when the hidden select is changed because of repo change

1 file changed with 8 insertions and 7 deletions:

kallithea/templates/pullrequests/pullrequest.html

0 comments (0 inline, 0 general)

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -158,24 +158,32 @@ ${self.repo_context_bar('showpullrequest @@
       while (new_select.length > 0){ // children will be popped when appened to other_ref_selector
           other_ref_selector.appendChild(new_select.children[0]);
+      }
       // browsers lost track of selected when appendChild was used
       other_ref_selector.selectedIndex = new_selectedIndex;
       // reset && add the reviewer based on selected repo
       var _data = other_repos_info[repo_name];
       YUD.get('review_members').innerHTML = '';
       addReviewMember(_data.user.user_id, _data.user.firstname,
                       _data.user.lastname, _data.user.username,
                       _data.user.gravatar_link);
       // (re)populate the select2 thingie
       $("#other_ref").select2({
           dropdownAutoWidth: true,
       });
       $("#other_ref").on("change", function(e){
           loadPreview();
       });
+  }
   var loadPreview = function(){
       //url template
       var url = "${h.url('compare_url',
                          repo_name='__other_repo__',
                          org_ref_type='rev',
                          org_ref_name='__other_ref_name__',
                          other_repo='__org_repo__',
                          other_ref_type='rev',
                          other_ref_name='__org_ref_name__',
                          as_form=True,
@@ @@ -222,27 +230,20 @@ ${self.repo_context_bar('showpullrequest @@
       $("#org_ref").on("change", function(e){
           loadPreview();
       });
       $("#other_repo").select2({
           dropdownAutoWidth: true,
       });
       $("#other_repo").on("change", function(e){
           otherrepoChanged();
           loadPreview();
       });
       $("#other_ref").select2({
           dropdownAutoWidth: true,
       });
       $("#other_ref").on("change", function(e){
           loadPreview();
       });
       otherrepoChanged();
       //lazy load overview after 0.5s
       setTimeout(loadPreview, 500);
   });
 </script>
 </%def>

0 comments (0 inline, 0 general)