kallithea Changeset - 486cd40776c2

Changeset - 486cd40776c2

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Mads Kiilerich - 11 years ago 2014-07-18 18:44:54
madski@unity3d.com

pull requests: use html placeholders for hints in input fields

3 files changed with 5 insertions and 8 deletions:

kallithea/public/css/style.css

kallithea/templates/pullrequests/pullrequest.html

kallithea/templates/pullrequests/pullrequest_show.html

0 comments (0 inline, 0 general)

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -1402,7 +1402,7 @@ input.disabled { @@
 #content div.box div.form div.fields div.field div.textarea textarea {
     width: 100%;
     height: 220px;
-    overflow: hidden;
+    overflow-y: auto;
     background: #FFF;
     color: #000;
     font-size: 12px;

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -31,7 +31,7 @@ ${self.repo_context_bar('showpullrequest @@
                     <label for="pullrequest_title">${_('Title')}:</label>
                 </div>
                 <div class="input">
-                    ${h.text('pullrequest_title', class_="large")}
+                    ${h.text('pullrequest_title',class_="large",placeholder=_('Summarize the changes - or leave empty'))}
                 </div>
              </div>
@@ @@ -40,8 +40,7 @@ ${self.repo_context_bar('showpullrequest @@
                     <label for="pullrequest_desc">${_('Description')}:</label>
                 </div>
                 <div class="textarea text-area editor">
                     ${h.textarea('pullrequest_desc',size=30, style="height:100px")}
                     <span class="help-block">${_('Write a short description on this pull request')}</span>
                     ${h.textarea('pullrequest_desc',size=30,placeholder=_('Write a short description on this pull request'))}
                 </div>
             </div>
@@ @@ -116,8 +115,7 @@ ${self.repo_context_bar('showpullrequest @@
               <div class='ac'>
                 <div class="reviewer_ac">
                    ${h.text('user', class_='yui-ac-input')}
                    <span class="help-block">${_('Add reviewer to this pull request.')}</span>
                    ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
                    <div id="reviewers_container"></div>
                 </div>
               </div>

kallithea/templates/pullrequests/pullrequest_show.html

➞

Show inline comments

@@ @@ -165,8 +165,7 @@ ${self.repo_context_bar('showpullrequest @@
           <div class='ac'>
             %if h.HasPermissionAny('hg.admin')() or h.HasRepoPermissionAny('repository.admin')(c.repo_name) or c.pull_request.author.user_id == c.authuser.user_id:
             <div class="reviewer_ac">
                ${h.text('user', class_='yui-ac-input')}
                <span class="help-block">${_('Add or remove reviewer to this pull request.')}</span>
                ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
                <div id="reviewers_container"></div>
             </div>
             <div style="padding:0px 10px">

0 comments (0 inline, 0 general)