kallithea Changeset - 486cd40776c2

Changeset - 486cd40776c2

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Mads Kiilerich - 11 years ago 2014-07-18 18:44:54
madski@unity3d.com

pull requests: use html placeholders for hints in input fields

3 files changed with 5 insertions and 8 deletions:

kallithea/public/css/style.css

kallithea/templates/pullrequests/pullrequest.html

kallithea/templates/pullrequests/pullrequest_show.html

0 comments (0 inline, 0 general)

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -1393,25 +1393,25 @@ input.disabled { @@
     margin: 0 0 0 200px;
     padding: 7px 7px 6px;
+}
 #content div.box div.form div.fields div.field div.textarea-editor {
     border: 1px solid #ddd;
     padding: 0;
+}
 #content div.box div.form div.fields div.field div.textarea textarea {
     width: 100%;
     height: 220px;
-    overflow: hidden;
+    overflow-y: auto;
     background: #FFF;
     color: #000;
     font-size: 12px;
     outline: none;
     border-width: 0;
     margin: 0;
     padding: 0;
+}
 #content div.box-left div.form div.fields div.field div.textarea textarea, #content div.box-right div.form div.fields div.field div.textarea textarea {
     width: 100%;
     height: 100px;

kallithea/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -22,35 +22,34 @@ ${self.repo_context_bar('showpullrequest @@
     ${h.form(url('pullrequest', repo_name=c.repo_name), method='post', id='pull_request_form')}
     <div class="form">
         <!-- fields -->
         <div class="fields" style="float:left;width:50%;padding-right:30px;">
              <div class="field">
                 <div class="label">
                     <label for="pullrequest_title">${_('Title')}:</label>
                 </div>
                 <div class="input">
-                    ${h.text('pullrequest_title', class_="large")}
+                    ${h.text('pullrequest_title',class_="large",placeholder=_('Summarize the changes - or leave empty'))}
                 </div>
              </div>
             <div class="field">
                 <div class="label label-textarea">
                     <label for="pullrequest_desc">${_('Description')}:</label>
                 </div>
                 <div class="textarea text-area editor">
                     ${h.textarea('pullrequest_desc',size=30, style="height:100px")}
                     <span class="help-block">${_('Write a short description on this pull request')}</span>
                     ${h.textarea('pullrequest_desc',size=30,placeholder=_('Write a short description on this pull request'))}
                 </div>
             </div>
             <div class="field">
                 <div class="label label-textarea">
                     <label for="pullrequest_desc">${_('Changeset flow')}:</label>
                 </div>
                 <div class="input">
                     ##ORG
                     <div>
                         <div>
                             <div style="padding:5px 3px 3px 3px;">
@@ @@ -107,26 +106,25 @@ ${self.repo_context_bar('showpullrequest @@
                       <input type="hidden" value="${member['user_id']}" name="review_members" />
                       <span class="action_button" style="padding: 3px" onclick="removeReviewMember(${member['user_id']})" title="${_('Remove reviewer')}>
                           <i class="icon-remove-sign" style="color: #FF4444;"></i>
                       </span>
                     </div>
                   </li>
                 %endfor
                 </ul>
               </div>
               <div class='ac'>
                 <div class="reviewer_ac">
                    ${h.text('user', class_='yui-ac-input')}
                    <span class="help-block">${_('Add reviewer to this pull request.')}</span>
                    ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
                    <div id="reviewers_container"></div>
                 </div>
               </div>
             </div>
         </div>
         <div style="clear:both;padding: 0 0 30px 0;"></div>
         <h4>${_('Changesets')}</h4>
         <div style="float:left;padding:0px 30px 30px 30px">
            ## overview pulled by ajax
            <div style="float:left" id="pull_request_overview"></div>

kallithea/templates/pullrequests/pullrequest_show.html

➞

Show inline comments

@@ @@ -156,26 +156,25 @@ ${self.repo_context_bar('showpullrequest @@
                       <i class="icon-remove-sign" style="color: #FF4444;"></i>
                   </div>
                   %endif
                 </div>
               </li>
             %endfor
             </ul>
           </div>
           %if not c.pull_request.is_closed():
           <div class='ac'>
             %if h.HasPermissionAny('hg.admin')() or h.HasRepoPermissionAny('repository.admin')(c.repo_name) or c.pull_request.author.user_id == c.authuser.user_id:
             <div class="reviewer_ac">
                ${h.text('user', class_='yui-ac-input')}
                <span class="help-block">${_('Add or remove reviewer to this pull request.')}</span>
                ${h.text('user', class_='yui-ac-input',placeholder=_('Type name of reviewer to add'))}
                <div id="reviewers_container"></div>
             </div>
             <div style="padding:0px 10px">
              <span id="update_pull_request" class="btn btn-mini">${_('Save Changes')}</span>
             </div>
             %endif
           </div>
           %endif
         </div>
        </div>
     <div style="overflow: auto; clear: both">

0 comments (0 inline, 0 general)