kallithea Changeset - 4debfe3b50be

Changeset - 4debfe3b50be

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 13 years ago 2012-08-07 22:10:44
marcin@python-works.com

ie8 fixes for inline comments :/

1 file changed with 37 insertions and 19 deletions:

rhodecode/public/js/rhodecode.js

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -72,12 +72,26 @@ if(!Array.prototype.indexOf) { @@
+            }
+        }
         return -1;
     };
+}
 // IE(CRAP) doesn't support previousElementSibling
 var prevElementSibling = function( el ) {
     if( el.previousElementSibling ) {
         return el.previousElementSibling;
     } else {
         while( el = el.previousSibling ) {
             if( el.nodeType === 1 ) return el;
+        }
+    }
+}
 /**
  * SmartColorGenerator
+ *
  *usage::
  *	var CG = new ColorGenerator();
  *  var col = CG.getColor(key); //returns array of RGB
@@ @@ -480,22 +494,25 @@ var injectInlineForm = function(tr){ @@
 	  setTimeout(function(){
 		  // callbacks
 		  tooltip_activate();
 		  MentionsAutoComplete('text_'+lineno, 'mentions_container_'+lineno,
 	                         _USERS_AC_DATA, _GROUPS_AC_DATA);
 		  YUD.get('text_'+lineno).focus();
 		  var _e = YUD.get('text_'+lineno);
 		  if(_e){
 			  _e.focus();
+		  }
 	  },10)
 };
 var deleteComment = function(comment_id){
 	var url = AJAX_COMMENT_DELETE_URL.replace('__COMMENT_ID__',comment_id);
     var postData = {'_method':'delete'};
     var success = function(o){
         var n = YUD.get('comment-tr-'+comment_id);
-        var root = n.previousElementSibling.previousElementSibling;
+        var root = prevElementSibling(prevElementSibling(n));
         n.parentNode.removeChild(n);
         // scann nodes, and attach add button to last one
         placeAddButton(root);
+    }
     ajaxPOST(url,postData,success);
@@ @@ -1231,29 +1248,30 @@ var MentionsAutoComplete = function (div @@
 			var unam = re.exec(msg2)[1];
 			return [unam, chunks];
+		}
 		return [null, null];
     };
 	ownerAC.textboxKeyUpEvent.subscribe(function(type, args){
 		var ac_obj = args[0];
 		var currentMessage = args[1];
 		var currentCaretPosition = args[0]._elTextbox.selectionStart;
 		var unam = ownerAC.get_mention(currentMessage, currentCaretPosition);
 		var curr_search = null;
 		if(unam[0]){
 			curr_search = unam[0];
+		}
 		ownerAC.dataSource.chunks = unam[1];
 		ownerAC.dataSource.mentionQuery = curr_search;
 	})
     if (ownerAC.textboxKeyUpEvent){
 		ownerAC.textboxKeyUpEvent.subscribe(function(type, args){
 			var ac_obj = args[0];
 			var currentMessage = args[1];
 			var currentCaretPosition = args[0]._elTextbox.selectionStart;
 			var unam = ownerAC.get_mention(currentMessage, currentCaretPosition);
 			var curr_search = null;
 			if(unam[0]){
 				curr_search = unam[0];
+			}
 			ownerAC.dataSource.chunks = unam[1];
 			ownerAC.dataSource.mentionQuery = curr_search;
 		})
+	}
     return {
         ownerDS: ownerDS,
         ownerAC: ownerAC,
     };
+}

0 comments (0 inline, 0 general)