kallithea Changeset - 4f4a73acd6b3

Changeset - 4f4a73acd6b3

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Søren Løvborg - 9 years ago 2016-07-15 16:02:13
sorenl@unity3d.com

db: remove redundant unique constraint for repository groups

There's already a unique constraint on 'group_name' alone, no need for
one on the combination of 'group_name' and 'group_parent_id'. (The extra
constraint likely stems from confusion over what exactly goes into
group_name; add comment to clarify that it is the full group path.)

1 file changed with 1 insertions and 2 deletions:

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -1484,7 +1484,6 @@ class Repository(Base, BaseModel): @@
 class RepoGroup(Base, BaseModel):
     __tablename__ = 'groups'
     __table_args__ = (
         UniqueConstraint('group_name', 'group_parent_id'),
         CheckConstraint('group_id != group_parent_id'),
         _table_args_default_dict,
+    )
@@ @@ -1493,7 +1492,7 @@ class RepoGroup(Base, BaseModel): @@
     SEP = ' &raquo; '
     group_id = Column(Integer(), primary_key=True)
     group_name = Column(Unicode(255), nullable=False, unique=True)
+    group_name = Column(Unicode(255), nullable=False, unique=True) # full path
     group_parent_id = Column(Integer(), ForeignKey('groups.group_id'), nullable=True)
     group_description = Column(Unicode(10000), nullable=False)
     enable_locking = Column(Boolean(), nullable=False, default=False)

0 comments (0 inline, 0 general)