kallithea Changeset - 572855f7a392

Changeset - 572855f7a392

Parent rev.

Child rev.

[Not reviewed]

beta

0 2 0

Marcin Kuzminski - 14 years ago 2012-02-28 06:08:42
marcin@python-works.com

reverted git fix as it broke pushing

2 files changed with 16 insertions and 9 deletions:

docs/changelog.rst

rhodecode/lib/middleware/simplegit.py

0 comments (0 inline, 0 general)

docs/changelog.rst

➞

Show inline comments

@@ @@ -17,13 +17,13 @@ news @@
 fixes
 +++++
 - fixed git protocol issues with repos-groups
 - fixed git remote repos validator that prevented from cloning remote git repos
 - fixes #370 ending slashes fixes for repo and groups
 - fixes #368 improved git-protocol detection to handle other clients
+#- fixes #368 improved git-protocol detection to handle other clients
 - fixes #366 When Setting Repository Group To Blank Repo Group Wont Be
   Moved To Root
 .3.1 (**2012-02-27**)
 ----------------------

rhodecode/lib/middleware/simplegit.py

➞

Show inline comments

@@ @@ -80,25 +80,28 @@ from webob.exc import HTTPNotFound, HTTP @@
 log = logging.getLogger(__name__)
 GIT_PROTO_PAT = re.compile(r'git-upload-pack|git-receive-pack|info\/refs')
 def is_git(action):
     return action in ['pull','push']
 def is_git(environ):
     """Returns True if request's target is git server.
     ``HTTP_USER_AGENT`` would then have git client version given.
     :param environ:
     """
     http_user_agent = environ.get('HTTP_USER_AGENT')
     if http_user_agent and http_user_agent.startswith('git'):
         return True
     return False
 class SimpleGit(BaseVCSController):
     def _handle_request(self, environ, start_response):
         #======================================================================
         # GET ACTION PULL or PUSH
         #======================================================================
         action = self.__get_action(environ)
         if not is_git(action):
         if not is_git(environ):
             return self.application(environ, start_response)
         proxy_key = 'HTTP_X_REAL_IP'
         def_key = 'REMOTE_ADDR'
         ipaddr = environ.get(proxy_key, environ.get(def_key, '0.0.0.0'))
         username = None
@@ @@ -111,12 +114,16 @@ class SimpleGit(BaseVCSController): @@
         try:
             repo_name = self.__get_repository(environ)
             log.debug('Extracted repo name is %s' % repo_name)
         except:
             return HTTPInternalServerError()(environ, start_response)
         #======================================================================
         # GET ACTION PULL or PUSH
         #======================================================================
         action = self.__get_action(environ)
         #======================================================================
         # CHECK ANONYMOUS PERMISSION
         #======================================================================
         if action in ['pull', 'push']:
             anonymous_user = self.__get_user('default')

0 comments (0 inline, 0 general)