Changeset - 5dfaa9f1fdb2
Parent rev.
Child rev.
[Not reviewed]
default
0 1 0
Mads Kiilerich - 9 years ago 2016-07-28 16:28:34
madski@unity3d.com
templates: disable special mako error handler - ironically this gives better stack traces

Errors in templates could give truncated stack traces pointing at the mako
error handler:

...
File '.../kallithea/kallithea/controllers/files.py', line 202 in index
return render('files/files.html')
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 244 in render_mako
cache_type=cache_type, cache_expire=cache_expire)
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 219 in cached_template
return render_func()
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 241 in render_template
return literal(template.render_unicode(**globs))
File '.../kallithea-venv/lib/python2.7/site-packages/mako/template.py', line 452 in render_unicode
as_unicode=True)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 803 in _render
**_kwargs_for_callable(callable_, data))
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 835 in _render_context
_exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 855 in _exec_template
_render_error(template, context, compat.exception_as())
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 864 in _render_error
result = template.error_handler(context, error)
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/error.py', line 22 in handle_mako_error
raise (exc, None, sys.exc_info()[2])
AttributeError: 'tuple' object has no attribute 'node'

Without the mako error handler we get a full and useful stack trace - including
calls in generated but readable .html.py files.

File '.../kallithea/kallithea/controllers/files.py', line 202 in index
return render('files/files.html')
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 244 in render_mako
cache_type=cache_type, cache_expire=cache_expire)
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 219 in cached_template
return render_func()
File '.../kallithea-venv/lib/python2.7/site-packages/pylons/templating.py', line 241 in render_template
return literal(template.render_unicode(**globs))
File '.../kallithea-venv/lib/python2.7/site-packages/mako/template.py', line 452 in render_unicode
as_unicode=True)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 803 in _render
**_kwargs_for_callable(callable_, data))
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 835 in _render_context
_exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 860 in _exec_template
callable_(context, *args, **kwargs)
File '.../data/templates/base/root.html.py', line 219 in render_body
__M_writer(escape(next.body()))
File '.../data/templates/base/base.html.py', line 57 in render_body
__M_writer(escape(next.main()))
File '.../data/templates/files/files.html.py', line 121 in render_main
runtime._include_file(context, u'files_ypjax.html', _template_uri)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 730 in _include_file
callable_(ctx, **_kwargs_for_include(callable_, context._data, **kwargs))
File '.../data/templates/files/files_ypjax.html.py', line 57 in render_body
runtime._include_file(context, u'files_source.html', _template_uri)
File '.../kallithea-venv/lib/python2.7/site-packages/mako/runtime.py', line 730 in _include_file
callable_(ctx, **_kwargs_for_include(callable_, context._data, **kwargs))
File '.../data/templates/files/files_source.html.py', line 117 in render_body
__M_writer(escape(h.pygmentize_annotation(c.repo_name,c.file,linenos=True,anchorlinenos=True,lineanchors='L',cssclass="code-highlight")))
File '.../kallithea/kallithea/lib/helpers.py', line 360 in pygmentize_annotation
return literal(markup_whitespace(annotate_highlight(filenode, url_func(repo_name), **kwargs)))
File '.../kallithea/kallithea/lib/annotate.py', line 57 in annotate_highlight
highlighted = highlight(filenode.content, lexer, formatter)
File '.../kallithea-venv/lib/python2.7/site-packages/pygments/__init__.py', line 87 in highlight
return format(lex(code, lexer), formatter, outfile)
File '.../kallithea-venv/lib/python2.7/site-packages/pygments/__init__.py', line 66 in format
formatter.format(tokens, realoutfile)
File '.../kallithea-venv/lib/python2.7/site-packages/pygments/formatter.py', line 95 in format
return self.format_unencoded(tokensource, outfile)
File '.../kallithea-venv/lib/python2.7/site-packages/pygments/formatters/html.py', line 850 in format_unencoded
for t, piece in source:
File '.../kallithea/kallithea/lib/annotate.py', line 168 in _wrap_tablelinenos
for el in self.filenode.annotate))
File '.../kallithea/kallithea/lib/annotate.py', line 167 in <genexpr>
annotate = ''.join((self.annotate_from_changeset(el[2]())
File '.../kallithea/kallithea/lib/vcs/backends/hg/changeset.py', line 273 in get_file_annotate
sha = hex(annotate_data[0].node())
1 file changed with 0 insertions and 1 deletions:
kallithea/config/environment.py
1
0 comments (0 inline, 0 general)
kallithea/config/environment.py
➞
Show inline comments
 
@@ -36,97 +36,96 @@ from kallithea.lib import helpers
 
from kallithea.lib.auth import set_available_permissions
 
from kallithea.lib.utils import repo2db_mapper, make_ui, set_app_settings, \
 
    load_rcextensions, check_git_version, set_vcs_config, set_indexer_config
 
from kallithea.lib.utils2 import engine_from_config, str2bool
 
from kallithea.lib.db_manage import DbManage
 
from kallithea.model import init_model
 
from kallithea.model.scm import ScmModel
 

			




	
	
	
		
 
log = logging.getLogger(__name__)

			




	
	
	
		
 

			




	
	
	
		
 

			




	
	
	
		
 
def load_environment(global_conf, app_conf, initial=False,

			




	
	
	
		
 
                     test_env=None, test_index=None):

			




	
	
	
		
 
    """

			




	
	
	
		
 
    Configure the Pylons environment via the ``pylons.config``

			




	
	
	
		
 
    object

			




	
	
	
		
 
    """

			




	
	
	
		
 
    config = pylons.configuration.PylonsConfig()

			




	
	
	
		
 

			




	
	
	
		
 
    # Pylons paths

			




	
	
	
		
 
    root = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

			




	
	
	
		
 
    paths = dict(

			




	
	
	
		
 
        root=root,

			




	
	
	
		
 
        controllers=os.path.join(root, 'controllers'),

			




	
	
	
		
 
        static_files=os.path.join(root, 'public'),

			




	
	
	
		
 
        templates=[os.path.join(root, 'templates')]

			




	
	
	
		
 
    )

			




	
	
	
		
 

			




	
	
	
		
 
    # Initialize config with the basic options

			




	
	
	
		
 
    config.init_app(global_conf, app_conf, package='kallithea', paths=paths)

			




	
	
	
		
 

			




	
	
	
		
 
    # store some globals into kallithea

			




	
	
	
		
 
    kallithea.CELERY_ON = str2bool(config['app_conf'].get('use_celery'))

			




	
	
	
		
 
    kallithea.CELERY_EAGER = str2bool(config['app_conf'].get('celery.always.eager'))

			




	
	
	
		
 

			




	
	
	
		
 
    config['routes.map'] = make_map(config)

			




	
	
	
		
 
    config['pylons.app_globals'] = app_globals.Globals(config)

			




	
	
	
		
 
    config['pylons.h'] = helpers

			




	
	
	
		
 
    kallithea.CONFIG = config

			




	
	
	
		
 

			




	
	
	
		
 
    load_rcextensions(root_path=config['here'])

			




	
	
	
		
 

			




	
	
	
		
 
    # Setup cache object as early as possible

			




	
	
	
		
 
    pylons.cache._push_object(config['pylons.app_globals'].cache)

			




	
	
	
		
 

			




	
	
	
		
 
    # Create the Mako TemplateLookup, with the default auto-escaping

			




	
	
	
		
 
    config['pylons.app_globals'].mako_lookup = mako.lookup.TemplateLookup(

			




	
	
	
		
 
        directories=paths['templates'],

			




	
	
	
		
 
        error_handler=pylons.error.handle_mako_error,

			




	
	
	
		
 
        strict_undefined=True,

			




	
	
	
		
 
        module_directory=os.path.join(app_conf['cache_dir'], 'templates'),

			




	
	
	
		
 
        input_encoding='utf-8', default_filters=['escape'],

			




	
	
	
		
 
        imports=['from webhelpers.html import escape'])

			




	
	
	
		
 

			




	
	
	
		
 
    # sets the c attribute access when don't existing attribute are accessed

			




	
	
	
		
 
    config['pylons.strict_tmpl_context'] = True

			




	
	
	
		
 
    test = os.path.split(config['__file__'])[-1] == 'test.ini'

			




	
	
	
		
 
    if test:

			




	
	
	
		
 
        if test_env is None:

			




	
	
	
		
 
            test_env = not int(os.environ.get('KALLITHEA_NO_TMP_PATH', 0))

			




	
	
	
		
 
        if test_index is None:

			




	
	
	
		
 
            test_index = not int(os.environ.get('KALLITHEA_WHOOSH_TEST_DISABLE', 0))

			




	
	
	
		
 
        if os.environ.get('TEST_DB'):

			




	
	
	
		
 
            # swap config if we pass enviroment variable

			




	
	
	
		
 
            config['sqlalchemy.db1.url'] = os.environ.get('TEST_DB')

			




	
	
	
		
 

			




	
	
	
		
 
        from kallithea.lib.utils import create_test_env, create_test_index

			




	
	
	
		
 
        from kallithea.tests import TESTS_TMP_PATH

			




	
	
	
		
 
        #set KALLITHEA_NO_TMP_PATH=1 to disable re-creating the database and

			




	
	
	
		
 
        #test repos

			




	
	
	
		
 
        if test_env:

			




	
	
	
		
 
            create_test_env(TESTS_TMP_PATH, config)

			




	
	
	
		
 
        #set KALLITHEA_WHOOSH_TEST_DISABLE=1 to disable whoosh index during tests

			




	
	
	
		
 
        if test_index:

			




	
	
	
		
 
            create_test_index(TESTS_TMP_PATH, config, True)

			




	
	
	
		
 

			




	
	
	
		
 
    DbManage.check_waitress()

			




	
	
	
		
 
    # MULTIPLE DB configs

			




	
	
	
		
 
    # Setup the SQLAlchemy database engine

			




	
	
	
		
 
    sa_engine_db1 = engine_from_config(config, 'sqlalchemy.db1.')

			




	
	
	
		
 
    init_model(sa_engine_db1)

			




	
	
	
		
 

			




	
	
	
		
 
    set_available_permissions(config)

			




	
	
	
		
 
    repos_path = make_ui('db').configitems('paths')[0][1]

			




	
	
	
		
 
    config['base_path'] = repos_path

			




	
	
	
		
 
    set_app_settings(config)

			




	
	
	
		
 

			




	
	
	
		
 
    instance_id = kallithea.CONFIG.get('instance_id', '*')

			




	
	
	
		
 
    if instance_id == '*':

			




	
	
	
		
 
        instance_id = '%s-%s' % (platform.uname()[1], os.getpid())

			




	
	
	
		
 
        kallithea.CONFIG['instance_id'] = instance_id

			




	
	
	
		
 

			




	
	
	
		
 
    # CONFIGURATION OPTIONS HERE (note: all config options will override

			




	
	
	
		
 
    # any Pylons config options)

			




	
	
	
		
 

			




	
	
	
		
 
    # store config reference into our module to skip import magic of

			




	
	
	
		
 
    # pylons

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.0,
        which is
        © 2010–2025 by various authors & licensed under GPLv3.