kallithea Changeset - 60335b702a00

Changeset - 60335b702a00

Parent rev.

Child rev.

[Not reviewed]

beta

0 3 0

Mads Kiilerich - 13 years ago 2013-04-03 15:56:12
madski@unity3d.com

Grafted from: a941f32fc5a6

invalidation: don't create CacheInvalidation records on startup

Creating the records early gave an advantage before lightweight was introduced.
With lightweight it is no longer necessary.

The records will be created on demand anyway and there is no reason to create and
maintain them before they are used.

3 files changed with 4 insertions and 6 deletions:

rhodecode/controllers/summary.py

rhodecode/lib/utils.py

rhodecode/tests/api/api_base.py

0 comments (0 inline, 0 general)

rhodecode/controllers/summary.py

➞

Show inline comments

@@ @@ -126,7 +126,7 @@ class SummaryController(BaseRepoControll @@
         kind = 'README'
         valid = CacheInvalidation.test_and_set_valid(repo_name, kind)
-		if not valid:
+        if not valid:
             region_invalidate(_get_readme_from_cache, None, repo_name, kind)
         return _get_readme_from_cache(repo_name, kind)

rhodecode/lib/utils.py

➞

Show inline comments

@@ @@ -472,11 +472,6 @@ def repo2db_mapper(initial_repo_list, re @@
         elif install_git_hook:
             if db_repo.repo_type == 'git':
                 ScmModel().install_git_hook(db_repo.scm_instance)
         # during starting install all cache keys for all repositories in the
         # system, this will register all repos and multiple instances
         cache_key = CacheInvalidation._get_cache_key(name)
         log.debug("Creating invalidation cache key for %s: %s", name, cache_key)
         CacheInvalidation.test_and_set_valid(name, None)
     sa.commit()
     removed = []

rhodecode/tests/api/api_base.py

➞

Show inline comments

@@ @@ -264,6 +264,9 @@ class BaseTestApi(object): @@
         self._compare_error(id_, expected, given=response.body)
     def test_api_invalidate_cache(self):
         repo = RepoModel().get_by_repo_name(self.REPO)
         repo.scm_instance_cached() # seed cache
         id_, params = _build_data(self.apikey, 'invalidate_cache',
                                   repoid=self.REPO)
         response = api_call(self, params)

0 comments (0 inline, 0 general)