kallithea Changeset - 60bf1b171015

Changeset - 60bf1b171015

Parent rev.

Child rev.

[Not reviewed]

default

0 5 0

Mads Kiilerich - 9 years ago 2016-08-04 14:23:36
madski@unity3d.com

routing: use POST to 'edit_user_ips_update' instead of PUT

5 files changed with 6 insertions and 6 deletions:

kallithea/config/routing.py

kallithea/templates/admin/permissions/permissions_ips.html

kallithea/templates/admin/users/user_edit_ips.html

kallithea/tests/functional/test_admin_permissions.py

kallithea/tests/functional/test_admin_users.py

0 comments (0 inline, 0 general)

kallithea/config/routing.py

➞

Show inline comments

@@ @@ -209,8 +209,8 @@ def make_map(config): @@
         m.connect("edit_user_ips", "/users/{id}/edit/ips",
                   action="edit_ips", conditions=dict(method=["GET"]))
         m.connect("edit_user_ips", "/users/{id}/edit/ips",
                   action="add_ip", conditions=dict(method=["PUT"]))
         m.connect("edit_user_ips_update", "/users/{id}/edit/ips",
                   action="add_ip", conditions=dict(method=["POST"]))
         m.connect("edit_user_ips_delete", "/users/{id}/edit/ips/delete",
                   action="delete_ip", conditions=dict(method=["POST"]))

kallithea/templates/admin/permissions/permissions_ips.html

➞

Show inline comments

@@ @@ -21,7 +21,7 @@ @@
       </table>
 </div>
-${h.form(url('edit_user_ips', id=c.user.user_id),method='put')}
+${h.form(url('edit_user_ips_update', id=c.user.user_id))}
     <div class="form">
         <!-- fields -->
         <div class="fields">

kallithea/templates/admin/users/user_edit_ips.html

➞

Show inline comments

@@ @@ -33,7 +33,7 @@ @@
 </div>
 <div>
-    ${h.form(url('edit_user_ips', id=c.user.user_id),method='put')}
+    ${h.form(url('edit_user_ips_update', id=c.user.user_id))}
     <div class="form">
         <!-- fields -->
         <div class="fields">

kallithea/tests/functional/test_admin_permissions.py

➞

Show inline comments

@@ @@ -19,7 +19,7 @@ class TestAdminPermissionsController(Tes @@
     def test_add_ips(self):
         self.log_user()
         default_user_id = User.get_default_user().user_id
-        response = self.app.put(url('edit_user_ips', id=default_user_id),
+        response = self.app.post(url('edit_user_ips_update', id=default_user_id),
                                  params=dict(new_ip='127.0.0.0/24',
                                  _authentication_token=self.authentication_token()))

kallithea/tests/functional/test_admin_users.py

➞

Show inline comments

@@ @@ -401,7 +401,7 @@ class TestAdminUsersController(TestContr @@
         user = User.get_by_username(TEST_USER_REGULAR_LOGIN)
         user_id = user.user_id
-        response = self.app.put(url('edit_user_ips', id=user_id),
+        response = self.app.post(url('edit_user_ips_update', id=user_id),
                                 params=dict(new_ip=ip, _authentication_token=self.authentication_token()))
         if failure:

0 comments (0 inline, 0 general)