kallithea Changeset - 6678b977f859

Changeset - 6678b977f859

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 11 years ago 2015-01-06 00:54:36
madski@unity3d.com

db: just fail badly if a repo can't be loaded (probably missing in file systems)

The error condition could perhaps be reported to the user in a better way, but
propagating the VCS error seems like a better approximation of that than just
logging it and failing silent.

1 file changed with 5 insertions and 11 deletions:

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -1434,17 +1434,11 @@ class Repository(Base, BaseModel): @@
     def __get_instance(self):
         repo_full_path = self.repo_full_path
         try:
             alias = get_scm(repo_full_path)[0]
             log.debug('Creating instance of %s repository from %s'
                       % (alias, repo_full_path))
             backend = get_backend(alias)
         except VCSError:
             log.error(traceback.format_exc())
             log.error('Perhaps this repository is in db and not in '
                       'filesystem run rescan repositories with '
                       '"destroy old data " option from admin panel')
             return
         alias = get_scm(repo_full_path)[0]
         log.debug('Creating instance of %s repository from %s'
                   % (alias, repo_full_path))
         backend = get_backend(alias)
         if alias == 'hg':
             repo = backend(safe_str(repo_full_path), create=False,

0 comments (0 inline, 0 general)