kallithea Changeset - 68764bdff7c9

Changeset - 68764bdff7c9

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 10 years ago 2016-03-23 18:27:45
madski@unity3d.com

status: refactor internal dict for mapping status string to description

Slightly better performance ... but more importantly: do it "the right way".

2 files changed with 3 insertions and 2 deletions:

kallithea/lib/helpers.py

kallithea/model/db.py

0 comments (0 inline, 0 general)

kallithea/lib/helpers.py

➞

Show inline comments

@@ @@ -1435,13 +1435,13 @@ def link_to_ref(repo_name, ref_type, ref @@
 def changeset_status(repo, revision):
     return ChangesetStatusModel().get_status(repo, revision)
 def changeset_status_lbl(changeset_status):
-    return dict(ChangesetStatus.STATUSES).get(changeset_status)
+    return ChangesetStatus.get_status_lbl(changeset_status)
 def get_permission_name(key):
     return dict(Permission.PERMS).get(key)

kallithea/model/db.py

➞

Show inline comments

@@ @@ -2235,12 +2235,13 @@ class ChangesetStatus(Base, BaseModel): @@
     STATUSES = [
         (STATUS_NOT_REVIEWED, _("Not reviewed")),  # (no icon) and default
         (STATUS_APPROVED, _("Approved")),
         (STATUS_REJECTED, _("Rejected")),
         (STATUS_UNDER_REVIEW, _("Under review")),
+    ]
     STATUSES_DICT = dict(STATUSES)
     changeset_status_id = Column(Integer(), unique=True, primary_key=True)
     repo_id = Column(Integer(), ForeignKey('repositories.repo_id'), nullable=False)
     user_id = Column(Integer(), ForeignKey('users.user_id'), nullable=False)
     revision = Column(String(40), nullable=True)
     status = Column(String(128), nullable=False, default=DEFAULT)
@@ @@ -2259,13 +2260,13 @@ class ChangesetStatus(Base, BaseModel): @@
             self.__class__.__name__,
             self.status, self.author
+        )
     @classmethod
     def get_status_lbl(cls, value):
-        return dict(cls.STATUSES).get(value)
+        return cls.STATUSES_DICT.get(value)
     @property
     def status_lbl(self):
         return ChangesetStatus.get_status_lbl(self.status)

0 comments (0 inline, 0 general)