kallithea Changeset - 6afa528ee30e

Changeset - 6afa528ee30e

Parent rev.

Child rev.

[Not reviewed]

default

0 7 0

Mads Kiilerich - 10 years ago 2016-03-14 16:17:46
madski@unity3d.com

db: get rid of vcs_full_cache - it should always be used

It might make tests less deterministic, but it makes sure that we test what we actually use.

7 files changed with 7 insertions and 31 deletions:

development.ini

docs/usage/performance.rst

kallithea/bin/template.ini.mako

kallithea/config/deployment.ini_tmpl

kallithea/model/db.py

kallithea/tests/test.ini

scripts/generate-ini.py

0 comments (0 inline, 0 general)

development.ini

➞

Show inline comments

@@ @@ -199,9 +199,6 @@ app_instance_uuid = development-not-secr @@
 ## cut off limit for large diffs (size in bytes)
 cut_off_limit = 256000
 ## use cache version of scm repo everywhere
 vcs_full_cache = true
 ## force https in Kallithea, fixes https redirects, assumes it's always https
 force_https = false

docs/usage/performance.rst

➞

Show inline comments

@@ @@ -9,21 +9,17 @@ performing slower than expected. Because @@
 amounts of data from version control systems, here are some tips on how to get
 the best performance.
 * Kallithea is often I/O bound, and hence a fast disk (SSD/SAN) is
   usually more important than a fast CPU.
 * Sluggish loading of the front page can easily be fixed by grouping repositories or by
   increasing cache size (see below). This includes using the lightweight dashboard
   option and ``vcs_full_cache`` setting in .ini file.
 Follow these few steps to improve performance of Kallithea system.
 . Increase cache
 .  Kallithea is often I/O bound, and hence a fast disk (SSD/SAN) is
     usually more important than a fast CPU.
 . Increase cache
     Tweak beaker cache settings in the ini file. The actual effect of that
     is questionable.
-. Switch from SQLite to PostgreSQL or MySQL
+. Switch from SQLite to PostgreSQL or MySQL
     SQLite is a good option when having a small load on the system. But due to
     locking issues with SQLite, it is not recommended to use it for larger
@@ @@ -31,7 +27,7 @@ Follow these few steps to improve perfor @@
     performance increase. A tool like SQLAlchemyGrate_ can be used for
     migrating to another database platform.
-. Scale Kallithea horizontally
+. Scale Kallithea horizontally
     Scaling horizontally can give huge performance benefits when dealing with
     large amounts of traffic (many users, CI servers, etc.). Kallithea can be

kallithea/bin/template.ini.mako

➞

Show inline comments

@@ @@ -196,9 +196,6 @@ app_instance_uuid = ${uuid()} @@
 <%text>## cut off limit for large diffs (size in bytes)</%text>
 cut_off_limit = 256000
 <%text>## use cache version of scm repo everywhere</%text>
 vcs_full_cache = true
 <%text>## force https in Kallithea, fixes https redirects, assumes it's always https</%text>
 force_https = false

kallithea/config/deployment.ini_tmpl

➞

Show inline comments

@@ @@ -192,9 +192,6 @@ app_instance_uuid = ${app_instance_uuid} @@
 ## cut off limit for large diffs (size in bytes)
 cut_off_limit = 256000
 ## use cache version of scm repo everywhere
 vcs_full_cache = true
 ## force https in Kallithea, fixes https redirects, assumes it's always https
 force_https = false

kallithea/model/db.py

➞

Show inline comments

@@ @@ -1439,11 +1439,7 @@ class Repository(Base, BaseModel): @@
     @property
     def scm_instance(self):
         import kallithea
         full_cache = str2bool(kallithea.CONFIG.get('vcs_full_cache'))
         if full_cache:
             return self.scm_instance_cached()
         return self.__get_instance()
         return self.scm_instance_cached()
     def scm_instance_cached(self, valid_cache_keys=None):
         @cache_region('long_term', 'scm_instance_cached')

kallithea/tests/test.ini

➞

Show inline comments

@@ @@ -2,7 +2,6 @@ @@
 ################################################################################
 # Kallithea - config for tests:                                                #
 # initial_repo_scan = true                                                     #
 # vcs_full_cache = false                                                       #
 # sqlalchemy and kallithea_test.sqlite                                         #
 # custom logging                                                               #
 #                                                                              #
@@ @@ -198,10 +197,6 @@ app_instance_uuid = test @@
 ## cut off limit for large diffs (size in bytes)
 cut_off_limit = 256000
 ## use cache version of scm repo everywhere
 #vcs_full_cache = true
 vcs_full_cache = false
 ## force https in Kallithea, fixes https redirects, assumes it's always https
 force_https = false

scripts/generate-ini.py

➞

Show inline comments

@@ @@ -40,7 +40,6 @@ ini_files = [ @@
         '''
         Kallithea - config for tests:
         initial_repo_scan = true
         vcs_full_cache = false
         sqlalchemy and kallithea_test.sqlite
         custom logging
@@ @@ -53,7 +52,6 @@ ini_files = [ @@
             '[app:main]': {
                 'initial_repo_scan': 'true',
                 'app_instance_uuid': 'test',
                 'vcs_full_cache': 'false',
                 'show_revision_number': 'true',
                 'beaker.cache.sql_cache_short.expire': '1',
                 'beaker.session.secret': '{74e0cd75-b339-478b-b129-07dd221def1f}',

0 comments (0 inline, 0 general)