kallithea Changeset - 6eafa1e06d71

Changeset - 6eafa1e06d71

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Mads Kiilerich - 11 years ago 2014-07-18 19:22:01
madski@unity3d.com

passwords: disable autocomplete - admin's browser should not offer to store passwords

3 files changed with 4 insertions and 4 deletions:

kallithea/templates/admin/auth/auth_settings.html

kallithea/templates/admin/users/user_add.html

kallithea/templates/register.html

0 comments (0 inline, 0 general)

kallithea/templates/admin/auth/auth_settings.html

➞

Show inline comments

@@ @@ -43,49 +43,49 @@ @@
                           ${_('enabled') if plugin_path in c.enabled_plugins else _('disabled')}</span>${plugin_path}
                       </div>
                     </li>
                %endfor
                </ul>
            </div>
        </div>
        <div class="buttons">
           ${h.submit('save',_('Save'),class_="btn")}
        </div>
     </div>
     %for cnt, module in enumerate(c.auth_plugins):
         <% pluginName = c.auth_plugins_shortnames[module] %>
         <h1>${_('Plugin')}: ${pluginName}</h1>
         <div class="fields">
         ## autoform generation, based on plugin definition from it's settings
         %for setting in c.plugin_settings[module]:
             <% fullsetting = "auth_%s_%s" % (pluginName, setting["name"]) %>
             <% displayname = (setting["formname"] if ("formname" in setting) else setting["name"]) %>
             %if setting["type"] == "password":
             <div class="field">
                 <div class="label"><label for="${fullsetting}">${_(displayname)}</label></div>
                 <div class="input">
                     ${h.password(fullsetting,class_='small')}
+                    ${h.password(fullsetting,class_='small',autocomplete="off")}
                     <span class="help-block">${setting["description"]}</span>
                 </div>
             </div>
             %elif setting["type"] in ["string", "int"]:
             <div class="field">
                 <div class="label"><label for="${fullsetting}">${_(displayname)}</label></div>
                 <div class="input">
                     ${h.text(fullsetting,class_='small')}
                     <span class="help-block">${setting["description"]}</span>
                 </div>
             </div>
             %elif setting["type"] == "bool":
             <div class="field">
                 <div class="label label-checkbox"><label for="${fullsetting}">${_(displayname)}</label></div>
                 <div class="checkboxes">
                     <div class="checkbox">${h.checkbox(fullsetting,True,class_='small')}</div>
                     <span class="help-block">${setting["description"]}</span>
                 </div>
             </div>
             %elif setting["type"] == "select":
             <div class="field">
                 <div class="label"><label for="${fullsetting}">${_(displayname)}</label></div>
                 <div class="select">
                     ${h.select(fullsetting,setting['values'][0],setting['values'],class_='small')}

kallithea/templates/admin/users/user_add.html

➞

Show inline comments

@@ @@ -23,49 +23,49 @@ @@
 <div class="box">
     <!-- box / title -->
     <div class="title">
         ${self.breadcrumbs()}
     </div>
     <!-- end box / title -->
     ${h.form(url('users'))}
     <div class="form">
         <!-- fields -->
         <div class="fields">
              <div class="field">
                 <div class="label">
                     <label for="username">${_('Username')}:</label>
                 </div>
                 <div class="input">
                     ${h.text('username',class_='small')}
                 </div>
              </div>
              <div class="field">
                 <div class="label">
                     <label for="password">${_('Password')}:</label>
                 </div>
                 <div class="input">
                     ${h.password('password',class_='small')}
+                    ${h.password('password',class_='small',autocomplete="off")}
                 </div>
              </div>
              <div class="field">
                 <div class="label">
                     <label for="password_confirmation">${_('Password confirmation')}:</label>
                 </div>
                 <div class="input">
                     ${h.password('password_confirmation',class_="small",autocomplete="off")}
                 </div>
              </div>
              <div class="field">
                 <div class="label">
                     <label for="firstname">${_('First Name')}:</label>
                 </div>
                 <div class="input">
                     ${h.text('firstname',class_='small')}
                 </div>
              </div>
              <div class="field">
                 <div class="label">
                     <label for="lastname">${_('Last Name')}:</label>

kallithea/templates/register.html

➞

Show inline comments

@@ @@ -28,58 +28,58 @@ @@
             <h5>${_('Sign Up to %s') % c.site_name}</h5>
         %else:
             <h5>${_('Sign Up')}</h5>
         %endif
     </div>
     <div class="inner">
         ${h.form(url('register'))}
         <div class="form">
             <!-- fields -->
             <div class="fields">
                 <div class="field">
                     <div class="label">
                         <label for="username">${_('Username')}:</label>
                     </div>
                     <div class="input">
                         ${h.text('username',class_="medium")}
                     </div>
                 </div>
                 <div class="field">
                     <div class="label">
                         <label for="password">${_('Password')}:</label>
                     </div>
                     <div class="input">
                         ${h.password('password',class_="medium")}
+                        ${h.password('password',class_="medium",autocomplete="off")}
                     </div>
                 </div>
                 <div class="field">
                     <div class="label">
                         <label for="password">${_('Re-enter password')}:</label>
                     </div>
                     <div class="input">
                         ${h.password('password_confirmation',class_="medium")}
+                        ${h.password('password_confirmation',class_="medium",autocomplete="off")}
                     </div>
                 </div>
                 <div class="field">
                     <div class="label">
                         <label for="firstname">${_('First Name')}:</label>
                     </div>
                     <div class="input">
                         ${h.text('firstname',class_="medium")}
                     </div>
                 </div>
                 <div class="field">
                     <div class="label">
                         <label for="lastname">${_('Last Name')}:</label>
                     </div>
                     <div class="input">
                         ${h.text('lastname',class_="medium")}
                     </div>
                 </div>
                 <div class="field">
                     <div class="label">
                         <label for="email">${_('Email')}:</label>

0 comments (0 inline, 0 general)