Changeset - 7590b93aac9a
Parent rev.
Child rev.
[Not reviewed]
default
0 1 0
Mads Kiilerich - 11 years ago 2014-09-24 14:24:40
madski@unity3d.com
javascript: fix issues found with strict mode
1 file changed with 35 insertions and 39 deletions:
kallithea/public/js/base.js
35
39
0 comments (0 inline, 0 general)
kallithea/public/js/base.js
➞
Show inline comments
 
@@ -277,13 +277,13 @@ var pyroutes = (function() {
 
                        throw new Error(route[1][i] + ' missing in "' + route_name + '" route generation');
 
                }
 
                result = sprintf(route[0], params);
 

			




	
	
	
		
 
                var ret = [];

			




	
	
	
		
 
                //extra params => GET

			




	
	
	
		
 
                for(param in params){

			




	
	
	
		
 
                for(var param in params){

			




	
	
	
		
 
                    if (route[1].indexOf(param) == -1){

			




	
	
	
		
 
                        ret.push(encodeURIComponent(param) + "=" + encodeURIComponent(params[param]));

			




	
	
	
		
 
                    }

			




	
	
	
		
 
                }

			




	
	
	
		
 
                var _parts = ret.join("&");

			




	
	
	
		
 
                if(_parts){

			




	
	
		
 
@@ -294,20 +294,18 @@ var pyroutes = (function() {

			




	
	
	
		
 
            return result;

			




	
	
	
		
 
        },

			




	
	
	
		
 
        'register': function(route_name, route_tmpl, req_params) {

			




	
	
	
		
 
            if (typeof(req_params) != 'object') {

			




	
	
	
		
 
                req_params = [];

			




	
	
	
		
 
            }

			




	
	
	
		
 
            //fix escape

			




	
	
	
		
 
            route_tmpl = unescape(route_tmpl);

			




	
	
	
		
 
            keys = [];

			




	
	
	
		
 
            var keys = [];

			




	
	
	
		
 
            for (var i=0; i < req_params.length; i++) {

			




	
	
	
		
 
                keys.push(req_params[i])

			




	
	
	
		
 
            }

			




	
	
	
		
 
            matchlist[route_name] = [

			




	
	
	
		
 
                route_tmpl,

			




	
	
	
		
 
                unescape(route_tmpl),

			




	
	
	
		
 
                keys

			




	
	
	
		
 
            ]

			




	
	
	
		
 
        },

			




	
	
	
		
 
        '_routes': function(){

			




	
	
	
		
 
            return matchlist;

			




	
	
	
		
 
        }

			




	
	
		
 
@@ -470,25 +468,25 @@ var _onSuccessFollow = function(target){

			




	
	
	
		
 
            $f_cnt.html(cnt);

			




	
	
	
		
 
        }

			




	
	
	
		
 
    }

			




	
	
	
		
 
}

			




	
	
	
		
 

			




	
	
	
		
 
var toggleFollowingRepo = function(target, follows_repo_id, token, user_id){

			




	
	
	
		
 
    args = 'follows_repo_id='+follows_repo_id;

			




	
	
	
		
 
    args+= '&amp;auth_token='+token;

			




	
	
	
		
 
    var args = 'follows_repo_id=' + follows_repo_id;

			




	
	
	
		
 
    args += '&amp;auth_token=' + token;

			




	
	
	
		
 
    if(user_id != undefined){

			




	
	
	
		
 
        args+="&amp;user_id="+user_id;

			




	
	
	
		
 
        args +="&amp;user_id=" + user_id;

			




	
	
	
		
 
    }

			




	
	
	
		
 
    $.post(TOGGLE_FOLLOW_URL, args, function(data){

			




	
	
	
		
 
            _onSuccessFollow(target);

			




	
	
	
		
 
        });

			




	
	
	
		
 
    return false;

			




	
	
	
		
 
};

			




	
	
	
		
 

			




	
	
	
		
 
var showRepoSize = function(target, repo_name, token){

			




	
	
	
		
 
    var args= 'auth_token='+token;

			




	
	
	
		
 
    var args = 'auth_token=' + token;

			




	
	
	
		
 

			




	
	
	
		
 
    if(!$("#" + target).hasClass('loaded')){

			




	
	
	
		
 
        $("#" + target).html(_TM['Loading ...']);

			




	
	
	
		
 
        var url = pyroutes.url('repo_size', {"repo_name":repo_name});

			




	
	
	
		
 
        $.post(url, args, function(data) {

			




	
	
	
		
 
            $("#" + target).html(data);

			




	
	
		
 
@@ -646,13 +644,13 @@ var _createInlineForm = function(parent_

			




	
	
	
		
 

			




	
	
	
		
 
/**

			




	
	
	
		
 
 * Inject inline comment for an given TR. This tr should always be a .line .

			




	
	
	
		
 
 * The form will be inject after any comments.

			




	
	
	
		
 
 */

			




	
	
	
		
 
var injectInlineForm = function(tr){

			




	
	
	
		
 
    $tr = $(tr);

			




	
	
	
		
 
    var $tr = $(tr);

			




	
	
	
		
 
    if(!$tr.hasClass('line')){

			




	
	
	
		
 
        return

			




	
	
	
		
 
    }

			




	
	
	
		
 
    var submit_url = AJAX_COMMENT_URL;

			




	
	
	
		
 
    var $td = $tr.find('.code');

			




	
	
	
		
 
    if($tr.hasClass('form-open') || $tr.hasClass('context') || $td.hasClass('no-comment')){

			




	
	
		
 
@@ -817,13 +815,13 @@ var _renderInlineComment = function(json

			




	
	
	
		
 
}

			




	
	
	
		
 

			




	
	
	
		
 
/**

			




	
	
	
		
 
 * Iterates over all the inlines, and places them inside proper blocks of data

			




	
	
	
		
 
 */

			




	
	
	
		
 
var renderInlineComments = function(file_comments){

			




	
	
	
		
 
    for (f in file_comments){

			




	
	
	
		
 
    for (var f in file_comments){

			




	
	
	
		
 
        // holding all comments for a FILE

			




	
	
	
		
 
        var box = file_comments[f];

			




	
	
	
		
 

			




	
	
	
		
 
        var target_id = $(box).attr('target_id');

			




	
	
	
		
 
        // actual comments with line numbers

			




	
	
	
		
 
        var comments = box.children;

			




	
	
		
 
@@ -1037,17 +1035,17 @@ var _getIdentNode = function(n){

			




	
	
	
		
 
 * This is a mouseup handler for hlcode from CodeHtmlFormatter and pygmentize */

			




	
	
	
		
 
var getSelectionLink = function(e) {

			




	
	
	
		
 
    //get selection from start/to nodes

			




	
	
	
		
 
    if (typeof window.getSelection != "undefined") {

			




	
	
	
		
 
        s = window.getSelection();

			




	
	
	
		
 

			




	
	
	
		
 
        from = _getIdentNode(s.anchorNode);

			




	
	
	
		
 
        till = _getIdentNode(s.focusNode);

			




	
	
	
		
 
        var from = _getIdentNode(s.anchorNode);

			




	
	
	
		
 
        var till = _getIdentNode(s.focusNode);

			




	
	
	
		
 

			




	
	
	
		
 
        f_int = parseInt(from.id.replace('L',''));

			




	
	
	
		
 
        t_int = parseInt(till.id.replace('L',''));

			




	
	
	
		
 
        var f_int = parseInt(from.id.replace('L',''));

			




	
	
	
		
 
        var t_int = parseInt(till.id.replace('L',''));

			




	
	
	
		
 

			




	
	
	
		
 
        var yoffset = 35;

			




	
	
	
		
 
        var ranges = [parseInt(from.id.replace('L','')), parseInt(till.id.replace('L',''))];

			




	
	
	
		
 
        if (ranges[0] > ranges[1]){

			




	
	
	
		
 
            //highlight from bottom

			




	
	
	
		
 
            yoffset = -yoffset;

			




	
	
		
 
@@ -1061,13 +1059,13 @@ var getSelectionLink = function(e) {

			




	
	
	
		
 
            } else {

			




	
	
	
		
 
                $hl_div = $('<div id="linktt" class="hl-tip-box">');

			




	
	
	
		
 
                $('body').prepend($hl_div);

			




	
	
	
		
 
            }

			




	
	
	
		
 

			




	
	
	
		
 
            $hl_div.append($('<a>').html(_TM['Selection link']).attr('href', location.href.substring(0, location.href.indexOf('#')) + '#L' + ranges[0] + '-'+ranges[1]));

			




	
	
	
		
 
            xy = $(till).offset();

			




	
	
	
		
 
            var xy = $(till).offset();

			




	
	
	
		
 
            $hl_div.css('top', (xy.top + yoffset) + 'px').css('left', xy.left + 'px');

			




	
	
	
		
 
            $hl_div.show();

			




	
	
	
		
 
        }

			




	
	
	
		
 
        else{

			




	
	
	
		
 
            $hl_div.hide();

			




	
	
	
		
 
        }

			




	
	
		
 
@@ -1121,13 +1119,13 @@ var _MembersAutoComplete = function (div

			




	
	
	
		
 
            var i = 0;

			




	
	
	
		
 
            var l = myUsers.length;

			




	
	
	
		
 
            var matches = [];

			




	
	
	
		
 

			




	
	
	
		
 
            // Match against each name of each contact

			




	
	
	
		
 
            for (; i < l; i++) {

			




	
	
	
		
 
                contact = myUsers[i];

			




	
	
	
		
 
                var contact = myUsers[i];

			




	
	
	
		
 
                if (((contact.fname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.lname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.nname) && ((contact.nname).toLowerCase().indexOf(query) > -1))) {

			




	
	
	
		
 
                    matches[matches.length] = contact;

			




	
	
	
		
 
                }

			




	
	
	
		
 
            }

			




	
	
		
 
@@ -1141,24 +1139,24 @@ var _MembersAutoComplete = function (div

			




	
	
	
		
 
            var i = 0;

			




	
	
	
		
 
            var l = myGroups.length;

			




	
	
	
		
 
            var matches = [];

			




	
	
	
		
 

			




	
	
	
		
 
            // Match against each name of each contact

			




	
	
	
		
 
            for (; i < l; i++) {

			




	
	
	
		
 
                matched_group = myGroups[i];

			




	
	
	
		
 
                var matched_group = myGroups[i];

			




	
	
	
		
 
                if (matched_group.grname.toLowerCase().indexOf(query) > -1) {

			




	
	
	
		
 
                    matches[matches.length] = matched_group;

			




	
	
	
		
 
                }

			




	
	
	
		
 
            }

			




	
	
	
		
 
            return matches;

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    //match all

			




	
	
	
		
 
    var matchAll = function (sQuery) {

			




	
	
	
		
 
            u = matchUsers(sQuery);

			




	
	
	
		
 
            g = matchGroups(sQuery);

			




	
	
	
		
 
            var u = matchUsers(sQuery);

			




	
	
	
		
 
            var g = matchGroups(sQuery);

			




	
	
	
		
 
            return u.concat(g);

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    // DataScheme for members

			




	
	
	
		
 
    var memberDS = new YAHOO.util.FunctionDataSource(matchAll);

			




	
	
	
		
 
    memberDS.responseSchema = {

			




	
	
		
 
@@ -1199,13 +1197,13 @@ var _MembersAutoComplete = function (div

			




	
	
	
		
 
    var custom_formatter = function (oResultData, sQuery, sResultMatch) {

			




	
	
	
		
 
            var query = sQuery.toLowerCase();

			




	
	
	
		
 
            var _gravatar = function(res, em, group){

			




	
	
	
		
 
                if (group !== undefined){

			




	
	
	
		
 
                    em = '/images/icons/group.png'

			




	
	
	
		
 
                }

			




	
	
	
		
 
                tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                var tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                return tmpl.format(em,res)

			




	
	
	
		
 
            }

			




	
	
	
		
 
            // group

			




	
	
	
		
 
            if (oResultData.grname != undefined) {

			




	
	
	
		
 
                var grname = oResultData.grname;

			




	
	
	
		
 
                var grmembers = oResultData.grmembers;

			




	
	
		
 
@@ -1302,26 +1300,25 @@ var MentionsAutoComplete = function (div

			




	
	
	
		
 
            var i = 0;

			




	
	
	
		
 
            var l = myUsers.length;

			




	
	
	
		
 
            var matches = [];

			




	
	
	
		
 

			




	
	
	
		
 
            // Match against each name of each contact

			




	
	
	
		
 
            for (; i < l; i++) {

			




	
	
	
		
 
                contact = myUsers[i];

			




	
	
	
		
 
                var contact = myUsers[i];

			




	
	
	
		
 
                if (((contact.fname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.lname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.nname) && ((contact.nname).toLowerCase().indexOf(query) > -1))) {

			




	
	
	
		
 
                    matches[matches.length] = contact;

			




	
	
	
		
 
                }

			




	
	
	
		
 
            }

			




	
	
	
		
 
            return matches

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    //match all

			




	
	
	
		
 
    var matchAll = function (sQuery) {

			




	
	
	
		
 
            u = matchUsers(sQuery);

			




	
	
	
		
 
            return u

			




	
	
	
		
 
            return matchUsers(sQuery);

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    // DataScheme for owner

			




	
	
	
		
 
    var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers);

			




	
	
	
		
 

			




	
	
	
		
 
    ownerDS.responseSchema = {

			




	
	
		
 
@@ -1337,15 +1334,15 @@ var MentionsAutoComplete = function (div

			




	
	
	
		
 
    ownerAC.animHoriz = false;

			




	
	
	
		
 
    ownerAC.animSpeed = 0.1;

			




	
	
	
		
 

			




	
	
	
		
 
    // Helper highlight function for the formatter

			




	
	
	
		
 
    var highlightMatch = function (full, snippet, matchindex) {

			




	
	
	
		
 
            return full.substring(0, matchindex)

			




	
	
	
		
 
            + "<span class='match'>"

			




	
	
	
		
 
            + full.substr(matchindex, snippet.length)

			




	
	
	
		
 
            + "</span>" + full.substring(matchindex + snippet.length);

			




	
	
	
		
 
                + "<span class='match'>"

			




	
	
	
		
 
                + full.substr(matchindex, snippet.length)

			




	
	
	
		
 
                + "</span>" + full.substring(matchindex + snippet.length);

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    // Custom formatter to highlight the matching letters

			




	
	
	
		
 
    ownerAC.formatResult = function (oResultData, sQuery, sResultMatch) {

			




	
	
	
		
 
            var org_sQuery = sQuery;

			




	
	
	
		
 
            if(this.dataSource.mentionQuery != null){

			




	
	
		
 
@@ -1354,13 +1351,13 @@ var MentionsAutoComplete = function (div

			




	
	
	
		
 

			




	
	
	
		
 
            var query = sQuery.toLowerCase();

			




	
	
	
		
 
            var _gravatar = function(res, em, group){

			




	
	
	
		
 
                if (group !== undefined){

			




	
	
	
		
 
                    em = '/images/icons/group.png'

			




	
	
	
		
 
                }

			




	
	
	
		
 
                tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                var tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                return tmpl.format(em,res)

			




	
	
	
		
 
            }

			




	
	
	
		
 
            if (oResultData.nname != undefined) {

			




	
	
	
		
 
                var fname = oResultData.fname || "";

			




	
	
	
		
 
                var lname = oResultData.lname || "";

			




	
	
	
		
 
                var nname = oResultData.nname;

			




	
	
		
 
@@ -1449,13 +1446,13 @@ var MentionsAutoComplete = function (div

			




	
	
	
		
 
            var unam = re.exec(msg2)[1];

			




	
	
	
		
 
            return [unam, chunks];

			




	
	
	
		
 
        }

			




	
	
	
		
 
        return [null, null];

			




	
	
	
		
 
    };

			




	
	
	
		
 

			




	
	
	
		
 
    $divid = $('#'+divid);

			




	
	
	
		
 
    var $divid = $('#'+divid);

			




	
	
	
		
 
    $divid.keyup(function(e){

			




	
	
	
		
 
            var currentMessage = $divid.val();

			




	
	
	
		
 
            var currentCaretPosition = $divid[0].selectionStart;

			




	
	
	
		
 

			




	
	
	
		
 
            var unam = ownerAC.get_mention(currentMessage, currentCaretPosition);

			




	
	
	
		
 
            var curr_search = null;

			




	
	
		
 
@@ -1533,13 +1530,13 @@ var PullRequestAutoComplete = function (

			




	
	
	
		
 
            var i = 0;

			




	
	
	
		
 
            var l = myUsers.length;

			




	
	
	
		
 
            var matches = [];

			




	
	
	
		
 

			




	
	
	
		
 
            // Match against each name of each contact

			




	
	
	
		
 
            for (; i < l; i++) {

			




	
	
	
		
 
                contact = myUsers[i];

			




	
	
	
		
 
                var contact = myUsers[i];

			




	
	
	
		
 
                if (((contact.fname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.lname+"").toLowerCase().indexOf(query) > -1) ||

			




	
	
	
		
 
                     ((contact.nname) && ((contact.nname).toLowerCase().indexOf(query) > -1))) {

			




	
	
	
		
 
                    matches[matches.length] = contact;

			




	
	
	
		
 
                }

			




	
	
	
		
 
            }

			




	
	
		
 
@@ -1563,14 +1560,13 @@ var PullRequestAutoComplete = function (

			




	
	
	
		
 
            }

			




	
	
	
		
 
            return matches;

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    //match all

			




	
	
	
		
 
    var matchAll = function (sQuery) {

			




	
	
	
		
 
            u = matchUsers(sQuery);

			




	
	
	
		
 
            return u

			




	
	
	
		
 
            return matchUsers(sQuery);

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    // DataScheme for owner

			




	
	
	
		
 
    var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers);

			




	
	
	
		
 

			




	
	
	
		
 
    ownerDS.responseSchema = {

			




	
	
		
 
@@ -1586,15 +1582,15 @@ var PullRequestAutoComplete = function (

			




	
	
	
		
 
    reviewerAC.animHoriz = false;

			




	
	
	
		
 
    reviewerAC.animSpeed = 0.1;

			




	
	
	
		
 

			




	
	
	
		
 
    // Helper highlight function for the formatter

			




	
	
	
		
 
    var highlightMatch = function (full, snippet, matchindex) {

			




	
	
	
		
 
            return full.substring(0, matchindex)

			




	
	
	
		
 
            + "<span class='match'>"

			




	
	
	
		
 
            + full.substr(matchindex, snippet.length)

			




	
	
	
		
 
            + "</span>" + full.substring(matchindex + snippet.length);

			




	
	
	
		
 
                + "<span class='match'>"

			




	
	
	
		
 
                + full.substr(matchindex, snippet.length)

			




	
	
	
		
 
                + "</span>" + full.substring(matchindex + snippet.length);

			




	
	
	
		
 
        };

			




	
	
	
		
 

			




	
	
	
		
 
    // Custom formatter to highlight the matching letters

			




	
	
	
		
 
    reviewerAC.formatResult = function (oResultData, sQuery, sResultMatch) {

			




	
	
	
		
 
            var org_sQuery = sQuery;

			




	
	
	
		
 
            if(this.dataSource.mentionQuery != null){

			




	
	
		
 
@@ -1603,13 +1599,13 @@ var PullRequestAutoComplete = function (

			




	
	
	
		
 

			




	
	
	
		
 
            var query = sQuery.toLowerCase();

			




	
	
	
		
 
            var _gravatar = function(res, em, group){

			




	
	
	
		
 
                if (group !== undefined){

			




	
	
	
		
 
                    em = '/images/icons/group.png'

			




	
	
	
		
 
                }

			




	
	
	
		
 
                tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                var tmpl = '<div class="ac-container-wrap"><img class="perm-gravatar-ac" src="{0}"/>{1}</div>'

			




	
	
	
		
 
                return tmpl.format(em,res)

			




	
	
	
		
 
            }

			




	
	
	
		
 
            if (oResultData.nname != undefined) {

			




	
	
	
		
 
                var fname = oResultData.fname || "";

			




	
	
	
		
 
                var lname = oResultData.lname || "";

			




	
	
	
		
 
                var nname = oResultData.nname;

			




	
	
		
 
@@ -1740,18 +1736,18 @@ function ajaxActionRevokePermission(url,

			




	
	
	
		
 
            $('#' + field_id).remove();

			




	
	
	
		
 
        },

			




	
	
	
		
 
        failure: function (o) {

			




	
	
	
		
 
            alert(_TM['Failed to revoke permission'] + ": " + o.status);

			




	
	
	
		
 
        }

			




	
	
	
		
 
    };

			




	
	
	
		
 
    query_params = {

			




	
	
	
		
 
    var query_params = {

			




	
	
	
		
 
        '_method': 'delete'

			




	
	
	
		
 
    }

			




	
	
	
		
 
    // put extra data into POST

			




	
	
	
		
 
    if (extra_data !== undefined && (typeof extra_data === 'object')){

			




	
	
	
		
 
        for(k in extra_data){

			




	
	
	
		
 
        for(var k in extra_data){

			




	
	
	
		
 
            query_params[k] = extra_data[k];

			




	
	
	
		
 
        }

			




	
	
	
		
 
    }

			




	
	
	
		
 

			




	
	
	
		
 
    if (obj_type=='user'){

			




	
	
	
		
 
        query_params['user_id'] = obj_id;

			




	
	
		
 
@@ -2128,13 +2124,13 @@ var YUI_datatable = function(data, field

			




	
	
	
		
 
        quick_repo_menu();

			




	
	
	
		
 
        });

			




	
	
	
		
 

			




	
	
	
		
 
    var filterTimeout = null;

			




	
	
	
		
 
    var $q_filter = $('#q_filter');

			




	
	
	
		
 

			




	
	
	
		
 
    updateFilter  = function () {

			




	
	
	
		
 
    var updateFilter = function () {

			




	
	
	
		
 
        // Reset timeout

			




	
	
	
		
 
        filterTimeout = null;

			




	
	
	
		
 

			




	
	
	
		
 
        // Reset sort

			




	
	
	
		
 
        var state = myDataTable.getState();

			




	
	
	
		
 
        state.sortedBy = {key:sortkey, dir:YAHOO.widget.DataTable.CLASS_ASC};

			




        

    



    


    



    



      

      





    
    0 comments (0 inline, 0 general)
    





    


  

  







  


    




    








    
        
    
    
        This site is powered by
            Kallithea 0.7.0,
        which is
        © 2010–2025 by various authors & licensed under GPLv3.