kallithea Changeset - 780c1aab1357

Changeset - 780c1aab1357

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Thomas De Schampheleire - 11 years ago 2015-03-03 21:48:53
thomas.de.schampheleire@gmail.com

pullrequest overview: remove custom handling of 'my pullrequests'

Re-use the same displaying code for the 'my pullrequests' overview as for
the repository pullrequests overview. Remove the now unused CSS styling as
well.

This removes the 'delete' button on the author's pullrequests. One could
argue whether the pullrequest overview is the right place for this button,
while it does not appear on the pull request page itself.

3 files changed with 7 insertions and 75 deletions:

kallithea/public/css/style.css

kallithea/templates/pullrequests/pullrequest_show_my.html

kallithea/templates/pullrequests/pullrequest_show_my_data.html

0 comments (0 inline, 0 general)

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -4639,50 +4639,46 @@ form.comment-inline-form { @@
+}
 .notification-body {
     clear: both;
     margin: 34px 2px 2px 8px
+}
 /****
 PULL REQUESTS
 *****/
 .pullrequests_section_head {
     padding: 10px 10px 10px 0px;
     margin: 0 20px;
     font-size: 16px;
     font-weight: bold;
+}
 div.pr-details-title.closed,
 #pullrequests_container li.closed div div
+ {
 div.pr-details-title.closed {
     color: #555;
     background: #eee;
+}
 div.pr-details-title {
     font-size: 1.6em;
     padding: 5px 0px 5px 10px;
+}
 div.pr {
     margin: 0px 20px;
     padding: 4px 4px;
+}
 div.pr-desc {
     margin: 0px 20px;
+}
 div.pr-closed {
     background-color: #eee;
+}
 tr.pr-closed td {
     background-color: #eee !important;
     color: #555 !important;
+}
 span.pr-closed-tag {
     margin-bottom: 1px;
     margin-right: 1px;
     padding: 1px 3px;
     font-size: 10px;
     padding: 1px 3px 1px 3px;
     font-size: 10px;

kallithea/templates/pullrequests/pullrequest_show_my.html

➞

Show inline comments

@@ @@ -21,18 +21,16 @@ @@
     </div>
     <div class="normal-indent">
         <div>
         %if c.closed:
             ${h.link_to(_('Hide closed pull requests (only show open pull requests)'), h.url('my_pullrequests'))}
         %else:
             ${h.link_to(_('Show closed pull requests (in addition to open pull requests)'), h.url('my_pullrequests',closed=1))}
         %endif
         </div>
     </div>
     <div id="pullrequests_container" class="table">
         <%include file='pullrequest_show_my_data.html'/>
     </div>
     <%include file='pullrequest_show_my_data.html'/>
 </div>
 </%def>

kallithea/templates/pullrequests/pullrequest_show_my_data.html

➞

Show inline comments

 <%namespace name="pullrequests" file="/pullrequests/pullrequest_data.html"/>
 <div class="pullrequests_section_head">${_('Pull Requests Created by Me')}</div>
 <ul>
   %if c.my_pull_requests:
     %for pull_request in c.my_pull_requests:
       <li class="${'closed' if pull_request.is_closed() else ''}">
         <div style="height: 12px">
             %if pull_request.last_review_status:
               <i class="icon-circle changeset-status-${pull_request.last_review_status}" title="${_("Someone voted: %s") % pull_request.last_review_status}"></i>
             %else:
               <i class="icon-circle changeset-status-not_reviewed" title="${_("Nobody voted")}"></i>
             %endif
             <a href="${pull_request.url()}">
               ${pull_request.title or _("(no title)")}
             </a>
             ${_('created on %s from') % (h.fmt_date(pull_request.created_on))}
             <% org_ref_name=pull_request.org_ref.rsplit(':', 2)[-2] %>
             <a href="${h.url('summary_home', repo_name=pull_request.org_repo.repo_name, anchor=org_ref_name)}">
               ${pull_request.org_repo.repo_name}#${org_ref_name}
             </a>
             %if pull_request.is_closed():
               (${_('Closed')})
             %endif
             ${h.form(url('pullrequest_delete', repo_name=pull_request.other_repo.repo_name, pull_request_id=pull_request.pull_request_id),method='delete', style="display:inline-block")}
             <button class="action_button"
                     id="remove_${pull_request.pull_request_id}"
                     name="remove_${pull_request.pull_request_id}"
                     title="${_('Delete Pull Request')}"
                     onclick="return confirm('${_('Confirm to delete this pull request')}');">
               <i class="icon-minus-circled"></i>
             </button>
             ${h.end_form()}
         </div>
       </li>
     %endfor
   %else:
     <li><span class="empty_data">${_('Nothing here yet')}</span></li>
   %endif
 </ul>
 ${pullrequests.pullrequest_overview(c.my_pull_requests)}
 <div class="pullrequests_section_head" style="clear:both">${_('Pull Requests I Participate In')}</div>
 <ul>
   %if c.participate_in_pull_requests:
     %for pull_request in c.participate_in_pull_requests:
       <li class="${'closed' if pull_request.is_closed() else ''}">
         <div style="height: 12px">
             %if pull_request.last_review_status:
               <i class="icon-circle changeset-status-${pull_request.last_review_status}" title="${_("Someone voted: %s") % pull_request.last_review_status}"></i>
             %else:
               <i class="icon-circle changeset-status-not_reviewed" title="${_("Nobody voted")}"></i>
             %endif
             <a href="${pull_request.url()}">
               ${pull_request.title or _("(no title)")}
             </a>
             ${_('from')}
             <% org_ref_name=pull_request.org_ref.rsplit(':', 2)[-2] %>
             <a href="${h.url('summary_home', repo_name=pull_request.org_repo.repo_name, anchor=org_ref_name)}">
               ${pull_request.org_repo.repo_name}#${org_ref_name}
             </a>
             ${_('created on %s') % (h.fmt_date(pull_request.created_on))}
             %if pull_request.is_closed():
               (${_('Closed')})
             %endif
         </div>
       </li>
     %endfor
   %else:
     <li><span class="empty_data">${_('Nothing here yet')}</span></li>
   %endif
 </ul>
 ${pullrequests.pullrequest_overview(c.participate_in_pull_requests)}

0 comments (0 inline, 0 general)