kallithea Changeset - 78a4bbc24b42

Changeset - 78a4bbc24b42

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Søren Løvborg - 9 years ago 2016-10-27 18:37:14
sorenl@unity3d.com

db: it should be "PullRequestReviewer" (singular)

sed -i 's/\bPullRequestReviewers\b/PullRequestReviewer/g' $(hg files)

Just as it's "User", "PullRequest", etc. It's not a collection.

3 files changed with 14 insertions and 14 deletions:

kallithea/controllers/pullrequests.py

kallithea/model/db.py

kallithea/model/pull_request.py

0 comments (0 inline, 0 general)

kallithea/controllers/pullrequests.py

➞

Show inline comments

@@ @@ -49,7 +49,7 @@ from kallithea.lib.vcs.exceptions import @@
 from kallithea.lib.vcs.utils import safe_str
 from kallithea.lib.vcs.utils.hgcompat import unionrepo
 from kallithea.model.db import PullRequest, ChangesetStatus, ChangesetComment, \
-    PullRequestReviewers, User
+    PullRequestReviewer, User
 from kallithea.model.pull_request import PullRequestModel
 from kallithea.model.meta import Session
 from kallithea.model.repo import RepoModel
@@ @@ -182,9 +182,9 @@ class PullrequestsController(BaseRepoCon @@
             return False
         owner = self.authuser.user_id == pull_request.owner_id
         reviewer = PullRequestReviewers.query() \
             .filter(PullRequestReviewers.pull_request == pull_request) \
             .filter(PullRequestReviewers.user_id == self.authuser.user_id) \
         reviewer = PullRequestReviewer.query() \
             .filter(PullRequestReviewer.pull_request == pull_request) \
             .filter(PullRequestReviewer.user_id == self.authuser.user_id) \
             .count() != 0
         return self.authuser.admin or owner or reviewer

kallithea/model/db.py

➞

Show inline comments

@@ @@ -2330,7 +2330,7 @@ class PullRequest(Base, BaseDbModel): @@
         return self.other_ref.split(':')
     owner = relationship('User')
-    reviewers = relationship('PullRequestReviewers',
+    reviewers = relationship('PullRequestReviewer',
                              cascade="all, delete-orphan")
     org_repo = relationship('Repository', primaryjoin='PullRequest.org_repo_id==Repository.repo_id')
     other_repo = relationship('Repository', primaryjoin='PullRequest.other_repo_id==Repository.repo_id')
@@ @@ -2351,7 +2351,7 @@ class PullRequest(Base, BaseDbModel): @@
         q = super(PullRequest, cls).query()
         if reviewer_id is not None:
-            q = q.join(PullRequestReviewers).filter(PullRequestReviewers.user_id == reviewer_id)
+            q = q.join(PullRequestReviewer).filter(PullRequestReviewer.user_id == reviewer_id)
         if not include_closed:
             q = q.filter(PullRequest.status != PullRequest.STATUS_CLOSED)
@@ @@ -2364,9 +2364,9 @@ class PullRequest(Base, BaseDbModel): @@
     def get_reviewer_users(self):
         """Like .reviewers, but actually returning the users"""
         return User.query() \
             .join(PullRequestReviewers) \
             .filter(PullRequestReviewers.pull_request == self) \
             .order_by(PullRequestReviewers.pull_request_reviewers_id) \
             .join(PullRequestReviewer) \
             .filter(PullRequestReviewer.pull_request == self) \
             .order_by(PullRequestReviewer.pull_request_reviewers_id) \
             .all()
     def is_closed(self):
@@ @@ -2411,7 +2411,7 @@ class PullRequest(Base, BaseDbModel): @@
         return h.url('pullrequest_show', repo_name=self.other_repo.repo_name,
                      pull_request_id=self.pull_request_id, **kwargs)
-class PullRequestReviewers(Base, BaseDbModel):
+class PullRequestReviewer(Base, BaseDbModel):
     __tablename__ = 'pull_request_reviewers'
     __table_args__ = (
         Index('pull_request_reviewers_user_id_idx', 'user_id'),

kallithea/model/pull_request.py

➞

Show inline comments

@@ @@ -36,7 +36,7 @@ from kallithea.model.meta import Session @@
 from kallithea.lib import helpers as h
 from kallithea.lib.exceptions import UserInvalidException
 from kallithea.model.base import BaseModel
-from kallithea.model.db import PullRequest, PullRequestReviewers, Notification, \
+from kallithea.model.db import PullRequest, PullRequestReviewer, Notification, \
     ChangesetStatus, User
 from kallithea.model.notification import NotificationModel
 from kallithea.lib.utils2 import extract_mentioned_users, safe_unicode
@@ @@ -108,7 +108,7 @@ class PullRequestModel(BaseModel): @@
         reviewer_users = set(self._get_valid_reviewers(reviewers))
         #members
         for reviewer in reviewer_users:
-            prr = PullRequestReviewers(reviewer, pr)
+            prr = PullRequestReviewer(reviewer, pr)
             Session().add(prr)
         #notification to reviewers
@@ @@ -180,9 +180,9 @@ class PullRequestModel(BaseModel): @@
     def remove_reviewers(self, user, pull_request, reviewer_ids):
         """Remove users in the given user_id list from being reviewers of the PR."""
-        PullRequestReviewers.query() \
+        PullRequestReviewer.query() \
             .filter_by(pull_request=pull_request) \
-            .filter(PullRequestReviewers.user_id.in_(reviewer_ids)) \
+            .filter(PullRequestReviewer.user_id.in_(reviewer_ids)) \
             .delete(synchronize_session='fetch') # the default of 'evaluate' is not available
     def delete(self, pull_request):

0 comments (0 inline, 0 general)