kallithea Changeset - 7edd336f88d7

Changeset - 7edd336f88d7

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

domruf - 9 years ago 2016-06-14 21:32:43
dominikruf@gmail.com

hooks: don't catch ImportError Exceptions in git hooks

These hooks are important. Being friendly and hiding errors is not the good
kind of friendliness. It is better if they just fail if the Kallithea
module can't be imported.

2 files changed with 6 insertions and 32 deletions:

kallithea/config/post_receive_tmpl.py

kallithea/config/pre_receive_tmpl.py

0 comments (0 inline, 0 general)

kallithea/config/post_receive_tmpl.py

➞

Show inline comments

 import os
 import sys
 try:
     import kallithea
     KALLITHEA_HOOK_VER = '_TMPL_'
     os.environ['KALLITHEA_HOOK_VER'] = KALLITHEA_HOOK_VER
     from kallithea.lib.hooks import handle_git_post_receive as _handler
 except ImportError:
     if os.environ.get('RC_DEBUG_GIT_HOOK'):
         import traceback
         print traceback.format_exc()
     kallithea = None
 KALLITHEA_HOOK_VER = '_TMPL_'
 os.environ['KALLITHEA_HOOK_VER'] = KALLITHEA_HOOK_VER
 from kallithea.lib.hooks import handle_git_post_receive as _handler
 def main():
     if kallithea is None:
         # exit with success if we cannot import kallithea !!
         # this allows simply push to this repo even without
         # kallithea
         sys.exit(0)
     repo_path = os.path.abspath('.')
     push_data = sys.stdin.readlines()
     # os.environ is modified here by a subprocess call that

kallithea/config/pre_receive_tmpl.py

➞

Show inline comments

 import os
 import sys
 try:
     import kallithea
     KALLITHEA_HOOK_VER = '_TMPL_'
     os.environ['KALLITHEA_HOOK_VER'] = KALLITHEA_HOOK_VER
     from kallithea.lib.hooks import handle_git_pre_receive as _handler
 except ImportError:
     if os.environ.get('RC_DEBUG_GIT_HOOK'):
         import traceback
         print traceback.format_exc()
     kallithea = None
 KALLITHEA_HOOK_VER = '_TMPL_'
 os.environ['KALLITHEA_HOOK_VER'] = KALLITHEA_HOOK_VER
 from kallithea.lib.hooks import handle_git_pre_receive as _handler
 def main():
     if kallithea is None:
         # exit with success if we cannot import kallithea !!
         # this allows simply push to this repo even without
         # kallithea
         sys.exit(0)
     repo_path = os.path.abspath('.')
     push_data = sys.stdin.readlines()
     # os.environ is modified here by a subprocess call that

0 comments (0 inline, 0 general)