kallithea Changeset - 872d5f0aafe4

Changeset - 872d5f0aafe4

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 14 years ago 2012-02-26 18:30:47
marcin@python-works.com

don't crash whole migrations if we cannot drop constraints. Those aren't so important. It might happen
than older versions of rhodecode don't have those.

1 file changed with 19 insertions and 5 deletions:

rhodecode/lib/dbmigrate/versions/005_version_1_3_0.py

0 comments (0 inline, 0 general)

rhodecode/lib/dbmigrate/versions/005_version_1_3_0.py

➞

Show inline comments

@@ @@ -23,43 +23,57 @@ def upgrade(migrate_engine): @@
     # Change unique constraints of table `repo_to_perm`
     #==========================================================================
     from rhodecode.lib.dbmigrate.schema.db_1_3_0 import UserRepoToPerm
     tbl = UserRepoToPerm().__table__
     new_cons = UniqueConstraint('user_id', 'repository_id', 'permission_id', table=tbl)
     new_cons.create()
+    old_cons = None
     if migrate_engine.name in ['mysql']:
         old_cons = UniqueConstraint('user_id', 'repository_id', table=tbl, name="user_id")
         old_cons.drop()
     elif migrate_engine.name in ['postgresql']:
         old_cons = UniqueConstraint('user_id', 'repository_id', table=tbl)
         old_cons.drop()
     else:
         # sqlite doesn't support dropping constraints...
         print """Please manually drop UniqueConstraint('user_id', 'repository_id')"""
     if old_cons:
         try:
             old_cons.drop()
         except Exception, e:
             # we don't care if this fails really... better to pass migration than
             # leave this in intermidiate state
             print 'Failed to remove Unique for user_id, repository_id reason %s' % e
     #==========================================================================
     # fix uniques of table `user_repo_group_to_perm`
     #==========================================================================
     from rhodecode.lib.dbmigrate.schema.db_1_3_0 import UserRepoGroupToPerm
     tbl = UserRepoGroupToPerm().__table__
     new_cons = UniqueConstraint('group_id', 'permission_id', 'user_id', table=tbl)
     new_cons.create()
     old_cons = None
     # fix uniqueConstraints
     if migrate_engine.name in ['mysql']:
         #mysql is givinig troubles here...
         old_cons = UniqueConstraint('group_id', 'permission_id', table=tbl, name="group_id")
         old_cons.drop()
     elif migrate_engine.name in ['postgresql']:
         old_cons = UniqueConstraint('group_id', 'permission_id', table=tbl, name='group_to_perm_group_id_permission_id_key')
         old_cons.drop()
     else:
         # sqlite doesn't support dropping constraints...
         print """Please manually drop UniqueConstraint('group_id', 'permission_id')"""
     if old_cons:
         try:
             old_cons.drop()
         except Exception, e:
             # we don't care if this fails really... better to pass migration than
             # leave this in intermidiate state
             print 'Failed to remove Unique for user_id, repository_id reason %s' % e
     return
 def downgrade(migrate_engine):
     meta = MetaData()
     meta.bind = migrate_engine

0 comments (0 inline, 0 general)