kallithea Changeset - 8c0a57a4b89b

Changeset - 8c0a57a4b89b

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 15 years ago 2011-03-27 00:23:44
marcin@python-works.com

Journal Should not return 500 errors on failure, rather better is to return bad request error

1 file changed with 4 insertions and 4 deletions:

rhodecode/controllers/journal.py

0 comments (0 inline, 0 general)

rhodecode/controllers/journal.py

➞

Show inline comments

@@ @@ -31,7 +31,7 @@ from sqlalchemy.orm import joinedload, m @@
 from webhelpers.paginate import Page
 from itertools import groupby
-from paste.httpexceptions import HTTPInternalServerError
+from paste.httpexceptions import HTTPBadRequest
 from pylons import request, tmpl_context as c, response, url
 from pylons.i18n.translation import _
 from webhelpers.feedgenerator import Atom1Feed, Rss201rev2Feed
@@ @@ -132,7 +132,7 @@ class JournalController(BaseController): @@
                                                     self.rhodecode_user.user_id)
                     return 'ok'
                 except:
-                    raise HTTPInternalServerError()
+                    raise HTTPBadRequest()
             repo_id = request.POST.get('follows_repo_id')
             if repo_id:
@@ @@ -141,11 +141,11 @@ class JournalController(BaseController): @@
                                                     self.rhodecode_user.user_id)
                     return 'ok'
                 except:
-                    raise HTTPInternalServerError()
+                    raise HTTPBadRequest()
         log.debug('token mismatch %s vs %s', cur_token, token)
-        raise HTTPInternalServerError()
+        raise HTTPBadRequest()

0 comments (0 inline, 0 general)