kallithea Changeset - 916be70ff883

Changeset - 916be70ff883

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 12 years ago 2013-12-10 19:30:37
madski@unity3d.com

helpers: urlify_commit requires a repo - it might crash without

1 file changed with 2 insertions and 2 deletions:

kallithea/lib/helpers.py

0 comments (0 inline, 0 general)

kallithea/lib/helpers.py

➞

Show inline comments

@@ @@ -1259,25 +1259,25 @@ def urlify_changesets(text_, repository) @@
          'pref': pref,
          'cls': 'revision-link',
          'url': url('changeset_home', repo_name=repository, revision=rev),
          'rev': rev,
          'suf': suf
+        }
     newtext = URL_PAT.sub(url_func, text_)
     return newtext
-def urlify_commit(text_, repository=None, link_=None):
 def urlify_commit(text_, repository, link_=None):
     """
     Parses given text message and makes proper links.
     issues are linked to given issue-server, and rest is a changeset link
     if link_ is given, in other case it's a plain text
     :param text_:
     :param repository:
     :param link_: changeset link
     """
     import traceback
     from pylons import url  # doh, we need to re-import url to mock it later
@@ @@ -1286,25 +1286,25 @@ def urlify_commit(text_, repository=None @@
     def linkify_others(t, l):
         urls = re.compile(r'(\<a.*?\<\/a\>)',)
         links = []
         for e in urls.split(t):
             if not urls.match(e):
                 links.append('<a class="message-link" href="%s">%s</a>' % (l, e))
             else:
                 links.append(e)
         return ''.join(links)
-    # urlify changesets - extrac revisions and make link out of them
+    # urlify changesets - extract revisions and make link out of them
     newtext = urlify_changesets(escaper(text_), repository)
     # extract http/https links and make them real urls
     newtext = urlify_text(newtext, safe=False)
     try:
         from kallithea import CONFIG
         conf = CONFIG
         # allow multiple issue servers to be used
         valid_indices = [
             x.group(1)

0 comments (0 inline, 0 general)