kallithea Changeset - 97b8db701355

Changeset - 97b8db701355

Parent rev.

Child rev.

[Not reviewed]

default

0 4 0

Mads Kiilerich - 9 years ago 2017-01-06 01:43:50
mads@kiilerich.com

templates: replace invalid metatag attributes with data attributes

(We could also use plain classes ... but stick to the plan ...)

4 files changed with 28 insertions and 28 deletions:

kallithea/lib/helpers.py

kallithea/public/css/style.css

kallithea/templates/admin/settings/settings_visual.html

kallithea/tests/other/test_libs.py

0 comments (0 inline, 0 general)

kallithea/lib/helpers.py

➞

Show inline comments

@@ @@ -1020,20 +1020,20 @@ def urlify_text(s, repo_name=None, link_ @@
         if stylize:
             seen = match_obj.group('seen')
             if seen:
                 return '<div class="metatag" tag="see">see =&gt; %s</div>' % seen
+                return '<div class="metatag" data-tag="see">see =&gt; %s</div>' % seen
             license = match_obj.group('license')
             if license:
                 return '<div class="metatag" tag="license"><a href="http:\/\/www.opensource.org/licenses/%s">%s</a></div>' % (license, license)
+                return '<div class="metatag" data-tag="license"><a href="http:\/\/www.opensource.org/licenses/%s">%s</a></div>' % (license, license)
             tagtype = match_obj.group('tagtype')
             if tagtype:
                 tagvalue = match_obj.group('tagvalue')
                 return '<div class="metatag" tag="%s">%s =&gt; <a href="/%s">%s</a></div>' % (tagtype, tagtype, tagvalue, tagvalue)
+                return '<div class="metatag" data-tag="%s">%s =&gt; <a href="/%s">%s</a></div>' % (tagtype, tagtype, tagvalue, tagvalue)
             lang = match_obj.group('lang')
             if lang:
                 return '<div class="metatag" tag="lang">%s</div>' % lang
+                return '<div class="metatag" data-tag="lang">%s</div>' % lang
             tag = match_obj.group('tag')
             if tag:
                 return '<div class="metatag" tag="%s">%s</div>' % (tag, tag)
+                return '<div class="metatag" data-tag="%s">%s</div>' % (tag, tag)
         return match_obj.group(0)
     def _urlify(s):

kallithea/public/css/style.css

➞

Show inline comments

@@ @@ -1238,40 +1238,40 @@ div.form div.form-horizontal div.form-gr @@
     background-color: #DEF;
+}
 .metatag[tag="dead"] {
+.metatag[data-tag="dead"] {
     background-color: #E44;
+}
 .metatag[tag="stale"] {
+.metatag[data-tag="stale"] {
     background-color: #EA4;
+}
 .metatag[tag="featured"] {
+.metatag[data-tag="featured"] {
     background-color: #AEA;
+}
 .metatag[tag="requires"] {
+.metatag[data-tag="requires"] {
     background-color: #9CF;
+}
 .metatag[tag="recommends"] {
+.metatag[data-tag="recommends"] {
     background-color: #BDF;
+}
 .metatag[tag="lang"] {
+.metatag[data-tag="lang"] {
     background-color: #FAF474;
+}
 .metatag[tag="license"] {
+.metatag[data-tag="license"] {
     border: solid 1px #9CF;
     background-color: #DEF;
+}
 .metatag[tag="see"] {
+.metatag[data-tag="see"] {
     border: solid 1px #CBD;
     background-color: #EDF;
+}
 a.metatag[tag="license"]:hover {
+a.metatag[data-tag="license"]:hover {
     background-color: #577632;
     color: #FFF;
     text-decoration: none;

kallithea/templates/admin/settings/settings_visual.html

➞

Show inline comments

@@ @@ -98,14 +98,14 @@ ${h.form(url('admin_settings_visual'), m @@
                     <div>
                         ${_('Stylify recognised meta tags:')}
                         <ul> <!-- Fix style here -->
                             <li>[featured] <span class="metatag" tag="featured">featured</span></li>
                             <li>[stale] <span class="metatag" tag="stale">stale</span></li>
                             <li>[dead] <span class="metatag" tag="dead">dead</span></li>
                             <li>[lang =&gt; lang] <span class="metatag" tag="lang" >lang</span></li>
                             <li>[license =&gt; License] <span class="metatag" tag="license"><a href="http://www.opensource.org/licenses/License" >License</a></span></li>
                             <li>[requires =&gt; Repo] <span class="metatag" tag="requires" >requires =&gt; <a href="#" >Repo</a></span></li>
                             <li>[recommends =&gt; Repo] <span class="metatag" tag="recommends" >recommends =&gt; <a href="#" >Repo</a></span></li>
                             <li>[see =&gt; URI] <span class="metatag" tag="see">see =&gt; <a href="#">URI</a> </span></li>
                             <li>[featured] <span class="metatag" data-tag="featured">featured</span></li>
                             <li>[stale] <span class="metatag" data-tag="stale">stale</span></li>
                             <li>[dead] <span class="metatag" data-tag="dead">dead</span></li>
                             <li>[lang =&gt; lang] <span class="metatag" data-tag="lang">lang</span></li>
                             <li>[license =&gt; License] <span class="metatag" data-tag="license"><a href="http://www.opensource.org/licenses/License">License</a></span></li>
                             <li>[requires =&gt; Repo] <span class="metatag" data-tag="requires">requires =&gt; <a href="#">Repo</a></span></li>
                             <li>[recommends =&gt; Repo] <span class="metatag" data-tag="recommends">recommends =&gt; <a href="#">Repo</a></span></li>
                             <li>[see =&gt; URI] <span class="metatag" data-tag="see">see =&gt; <a href="#">URI</a> </span></li>
                         </ul>
                     </div>
                  </div>

kallithea/tests/other/test_libs.py

➞

Show inline comments

@@ @@ -213,12 +213,12 @@ class TestLibs(TestController): @@
+        )
         from kallithea.lib.helpers import urlify_text
         res = urlify_text(sample, stylize=True)
         assert '<div class="metatag" tag="tag">tag</div>' in res
         assert '<div class="metatag" tag="obsolete">obsolete</div>' in res
         assert '<div class="metatag" tag="stale">stale</div>' in res
         assert '<div class="metatag" tag="lang">python</div>' in res
         assert '<div class="metatag" tag="requires">requires =&gt; <a href="/url">url</a></div>' in res
         assert '<div class="metatag" tag="tag">tag</div>' in res
         assert '<div class="metatag" data-tag="tag">tag</div>' in res
         assert '<div class="metatag" data-tag="obsolete">obsolete</div>' in res
         assert '<div class="metatag" data-tag="stale">stale</div>' in res
         assert '<div class="metatag" data-tag="lang">python</div>' in res
         assert '<div class="metatag" data-tag="requires">requires =&gt; <a href="/url">url</a></div>' in res
         assert '<div class="metatag" data-tag="tag">tag</div>' in res
     def test_alternative_gravatar(self):
         from kallithea.lib.helpers import gravatar_url

0 comments (0 inline, 0 general)