kallithea Changeset - 9988ec8c33e5

Changeset - 9988ec8c33e5

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Lars Kruse - 8 years ago 2017-08-25 14:34:58
devel@sumpfralle.de

codingstyle: replace "not ... is ..." with "... is not ..."

Reported by flake8.

1 file changed with 2 insertions and 2 deletions:

kallithea/model/repo_permission.py

0 comments (0 inline, 0 general)

kallithea/model/repo_permission.py

➞

Show inline comments

@@ @@ -36,50 +36,50 @@ class RepositoryPermissionModel(object): @@
         repository = Repository.guess_instance(repository)
         user = User.guess_instance(user)
         return UserRepoToPerm.query() \
                 .filter(UserRepoToPerm.user == user) \
                 .filter(UserRepoToPerm.repository == repository) \
                 .scalar()
     def update_user_permission(self, repository, user, permission):
         permission = Permission.get_by_key(permission)
         current = self.get_user_permission(repository, user)
         if current:
-            if not current.permission is permission:
+            if current.permission is not permission:
                 current.permission = permission
         else:
             p = UserRepoToPerm()
             p.user = user
             p.repository = repository
             p.permission = permission
             Session().add(p)
     def delete_user_permission(self, repository, user):
         current = self.get_user_permission(repository, user)
         if current:
             Session().delete(current)
     def get_users_group_permission(self, repository, users_group):
         return UserGroupRepoToPerm.query() \
                 .filter(UserGroupRepoToPerm.users_group == users_group) \
                 .filter(UserGroupRepoToPerm.repository == repository) \
                 .scalar()
     def update_users_group_permission(self, repository, users_group,
                                       permission):
         permission = Permission.get_by_key(permission)
         current = self.get_users_group_permission(repository, users_group)
         if current:
-            if not current.permission is permission:
+            if current.permission is not permission:
                 current.permission = permission
         else:
             p = UserGroupRepoToPerm()
             p.users_group = users_group
             p.repository = repository
             p.permission = permission
             Session().add(p)
     def delete_users_group_permission(self, repository, users_group):
         current = self.get_users_group_permission(repository, users_group)
         if current:
             Session().delete(current)

0 comments (0 inline, 0 general)