kallithea Changeset - 9fdd5ec8bc11

Changeset - 9fdd5ec8bc11

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 11 years ago 2014-08-21 23:46:55
madski@unity3d.com

cleanup: be less verbose and less aggressive when catching exceptions

2 files changed with 2 insertions and 4 deletions:

kallithea/controllers/files.py

kallithea/lib/vcs/backends/hg/repository.py

0 comments (0 inline, 0 general)

kallithea/controllers/files.py

➞

Show inline comments

@@ @@ -94,7 +94,6 @@ class FilesController(BaseRepoController @@
                     category='warning')
             raise HTTPNotFound()
         except(ChangesetDoesNotExistError, LookupError), e:
             log.error(traceback.format_exc())
             msg = _('Such revision does not exist for this repository')
             h.flash(msg, category='error')
             raise HTTPNotFound()
@@ @@ -115,7 +114,6 @@ class FilesController(BaseRepoController @@
             if file_node.is_dir():
                 raise RepositoryError('given path is a directory')
         except(ChangesetDoesNotExistError,), e:
             log.error(traceback.format_exc())
             msg = _('Such revision does not exist for this repository')
             h.flash(msg, category='error')
             raise HTTPNotFound()

kallithea/lib/vcs/backends/hg/repository.py

➞

Show inline comments

@@ @@ -463,10 +463,10 @@ class MercurialRepository(BaseRepository @@
         rev_spec = "%%s & %s(%%s)" % _revset_predicates[ref_type]
         try:
             revs = self._repo.revs(rev_spec, ref_name, ref_name)
-        except (LookupError, ):
         except LookupError:
             msg = ("Ambiguous identifier %s:%s for %s" % (ref_type, ref_name, self.name))
             raise ChangesetDoesNotExistError(msg)
-        except (IndexError, ValueError, RepoLookupError, TypeError):
         except RepoLookupError:
             msg = ("Revision %s:%s does not exist for %s" % (ref_type, ref_name, self.name))
             raise ChangesetDoesNotExistError(msg)
         if revs:

0 comments (0 inline, 0 general)