kallithea Changeset - a1b3f392032b

Changeset - a1b3f392032b

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich - 9 years ago 2016-08-12 03:04:48
madski@unity3d.com

pullrequests: drop 'Closing.' comment when closing a PR - the semantic change is shown clearly everywhere

Things have changed since 9cfc66a665ae.

1 file changed with 0 insertions and 2 deletions:

kallithea/controllers/pullrequests.py

0 comments (0 inline, 0 general)

kallithea/controllers/pullrequests.py

➞

Show inline comments

@@ @@ -763,26 +763,24 @@ class PullrequestsController(BaseRepoCon @@
                 ) and not pull_request.is_closed():
                 PullRequestModel().delete(pull_request)
                 Session().commit()
                 h.flash(_('Successfully deleted pull request %s') % pull_request_id,
                         category='success')
                 return {
                    'location': url('my_pullrequests'), # or repo pr list?
+                }
                 raise HTTPFound(location=url('my_pullrequests')) # or repo pr list?
             raise HTTPForbidden()
         text = request.POST.get('text', '').strip()
         if close_pr:
             text = _('Closing.') + '\n' + text
         comment = create_comment(
             text,
             status,
             pull_request_id=pull_request_id,
             f_path=f_path,
             line_no=line_no,
             closing_pr=close_pr,
+        )
         action_logger(self.authuser,
                       'user_commented_pull_request:%s' % pull_request_id,

0 comments (0 inline, 0 general)