kallithea Changeset - a2218bdbf45d

Changeset - a2218bdbf45d

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich - 12 years ago 2013-06-12 12:23:20
madski@unity3d.com

Grafted from: ba4fa8a6c4b0

pull requests: make title optional - generate one automatically

2 files changed with 3 insertions and 1 deletions:

rhodecode/controllers/pullrequests.py

rhodecode/model/forms.py

0 comments (0 inline, 0 general)

rhodecode/controllers/pullrequests.py

➞

Show inline comments

@@ @@ -332,12 +332,14 @@ class PullrequestsController(BaseRepoCon @@
         other_repo = _form['other_repo']
         other_ref = 'rev:ancestor:%s' % _form['ancestor_rev'] # could be calculated from other_ref ...
         revisions = [x for x in reversed(_form['revisions'])]
         reviewers = _form['review_members']
         title = _form['pullrequest_title']
         if not title:
             title = '%s#%s to %s' % (org_repo, org_ref.split(':', 2)[1], other_repo)
         description = _form['pullrequest_desc']
         try:
             pull_request = PullRequestModel().create(
                 self.rhodecode_user.user_id, org_repo, org_ref, other_repo,
                 other_ref, revisions, reviewers, title, description
+            )

rhodecode/model/forms.py

➞

Show inline comments

@@ @@ -412,13 +412,13 @@ def PullRequestForm(repo_id): @@
         other_repo = v.UnicodeString(strip=True, required=True)
         other_ref = v.UnicodeString(strip=True, required=True)
         revisions = All(#v.NotReviewedRevisions(repo_id)(),
                         v.UniqueList(not_empty=True))
         review_members = v.UniqueList(not_empty=True)
-        pullrequest_title = v.UnicodeString(strip=True, required=True, min=3)
         pullrequest_title = v.UnicodeString(strip=True, required=True)
         pullrequest_desc = v.UnicodeString(strip=True, required=False)
         ancestor_rev = v.UnicodeString(strip=True, required=True)
         merge_rev = v.UnicodeString(strip=True, required=True)
     return _PullRequestForm

0 comments (0 inline, 0 general)