kallithea Changeset - a93c07ade43a

Changeset - a93c07ade43a

Parent rev.

Child rev.

[Not reviewed]

beta

0 1 0

Marcin Kuzminski - 13 years ago 2012-09-02 23:29:07
marcin@python-works.com

Added huge diff protection for RSS/ATOM feeds.
It can really be a performance killer for huge diffs.

1 file changed with 8 insertions and 2 deletions:

rhodecode/controllers/feed.py

0 comments (0 inline, 0 general)

rhodecode/controllers/feed.py

➞

Show inline comments

@@ @@ -38,50 +38,56 @@ from rhodecode.lib.diffs import DiffProc @@
 log = logging.getLogger(__name__)
 class FeedController(BaseRepoController):
     @LoginRequired(api_access=True)
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')
     def __before__(self):
         super(FeedController, self).__before__()
         #common values for feeds
         self.description = _('Changes on %s repository')
         self.title = self.title = _('%s %s feed') % (c.rhodecode_name, '%s')
         self.language = 'en-us'
         self.ttl = "5"
         self.feed_nr = 20
     def _get_title(self, cs):
         return "%s" % (
             h.shorter(cs.message, 160)
+        )
     def __changes(self, cs):
         changes = []
         diffprocessor = DiffProcessor(cs.diff())
         _diff = cs.diff()
         # we need to protect from parsing huge diffs here other way
         # we can kill the server, 32*1024 chars is a reasonable limit
         HUGE_DIFF = 32 * 1024
         if len(_diff) > HUGE_DIFF:
             changes = ['\n ' + _('Changeset was too big and was cut off...')]
             return changes
         diffprocessor = DiffProcessor(_diff)
         stats = diffprocessor.prepare(inline_diff=False)
         for st in stats:
             st.update({'added': st['stats'][0],
                        'removed': st['stats'][1]})
             changes.append('\n %(operation)s %(filename)s '
                            '(%(added)s lines added, %(removed)s lines removed)'
                             % st)
         return changes
     def __get_desc(self, cs):
         desc_msg = []
         desc_msg.append('%s %s %s:<br/>' % (cs.author, _('commited on'),
                                            h.fmt_date(cs.date)))
         desc_msg.append('<pre>')
         desc_msg.append(cs.message)
         desc_msg.append('\n')
         desc_msg.extend(self.__changes(cs))
         desc_msg.append('</pre>')
         return desc_msg
     def atom(self, repo_name):
         """Produce an atom-1.0 feed via feedgenerator module"""
         feed = Atom1Feed(
              title=self.title % repo_name,

0 comments (0 inline, 0 general)