kallithea Changeset - ad3573d744ef

Changeset - ad3573d744ef

Parent rev.

Child rev.

[Not reviewed]

beta

0 2 0

Marcin Kuzminski - 13 years ago 2012-07-15 19:17:00
marcin@python-works.com

added option to remove members added using autocomplete widget from pull
request

2 files changed with 17 insertions and 8 deletions:

rhodecode/public/js/rhodecode.js

rhodecode/templates/pullrequests/pullrequest.html

0 comments (0 inline, 0 general)

rhodecode/public/js/rhodecode.js

➞

Show inline comments

@@ @@ -628,6 +628,12 @@ var renderInlineComments = function(file @@
+    }
+}
 var removeReviewer = function(reviewer_id){
 	var el = YUD.get('reviewer_{0}'.format(reviewer_id));
 	if (el.parentNode !== undefined){
 		el.parentNode.removeChild(el);
+	}
+}
 var fileBrowserListeners = function(current_url, node_list_url, url_base){
@@ @@ -1381,11 +1387,12 @@ var PullRequestAutoComplete = function ( @@
             		return
+            	}
             	var tmpl = '<li>'+
+            	var tmpl = '<li id="reviewer_{2}">'+
 		                      '<div class="reviewers_member">'+
 		                        '<div class="gravatar"><img alt="gravatar" src="{0}"/> </div>'+
 		                        '<div style="float:left">{1}</div>'+
 		                        '<input type="hidden" value="{2}" name="review_members" />'+
 		                        '<span class="delete_icon action_button" onclick="removeReviewer({2})"></span>'+
 		                      '</div>'+
 		                   '</li>'
@@ @@ -1393,6 +1400,7 @@ var PullRequestAutoComplete = function ( @@
             	var element = tmpl.format(oData.gravatar_lnk,displayname,oData.id);
             	members.innerHTML += element;
             	myAC.dataSource.cache.push(oData.id);
             	YUD.get('user').value = ''
+            }
     	});
+    }

rhodecode/templates/pullrequests/pullrequest.html

➞

Show inline comments

@@ @@ -73,13 +73,14 @@ @@
           <div class="group_members_wrap">
             <ul id="review_members" class="group_members">
             %for member in c.review_members:
                   <li>
                     <div class="reviewers_member">
                       <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(member.email,14)}"/> </div>
                       <div style="float:left">${member.full_name} (${_('owner')})</div>
                       <input type="hidden" value="${member.user_id}" name="review_members" />
                     </div>
                  </li>
               <li id="reviewer_${member.user_id}">
                 <div class="reviewers_member">
                   <div class="gravatar"><img alt="gravatar" src="${h.gravatar_url(member.email,14)}"/> </div>
                   <div style="float:left">${member.full_name} (${_('owner')})</div>
                   <input type="hidden" value="${member.user_id}" name="review_members" />
                   <span class="delete_icon action_button" onclick="removeReviewer(${member.user_id})"></span>
                 </div>
               </li>
             %endfor
             </ul>
           </div>

0 comments (0 inline, 0 general)